Re: [Cellar] I-D Action: draft-ietf-cellar-ffv1-15.txt

"Murray S. Kucherawy" <superuser@gmail.com> Thu, 25 June 2020 16:25 UTC

Return-Path: <superuser@gmail.com>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 518673A0C81 for <cellar@ietfa.amsl.com>; Thu, 25 Jun 2020 09:25:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.097
X-Spam-Level:
X-Spam-Status: No, score=-2.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id szI21jamVk2W for <cellar@ietfa.amsl.com>; Thu, 25 Jun 2020 09:25:10 -0700 (PDT)
Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 643CC3A0C39 for <cellar@ietf.org>; Thu, 25 Jun 2020 09:25:10 -0700 (PDT)
Received: by mail-vs1-xe30.google.com with SMTP id k13so3867679vsm.13 for <cellar@ietf.org>; Thu, 25 Jun 2020 09:25:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3zEZJy2TR3R86wOZDnhA2k60rObsH63DvsNcpQuVuVU=; b=nIFXnSCWnP1ZzFP+e2PN7JpO5NLS1IHA7zhgdkj4YmLvTXLpEGAn34nK7uRpwbynty xDPcDtuEZMWFceGGM7VZ01ZEsE3Lr7ybwmF4p59np99OjZKgFC/MGTY/cKYQdLGkcwq2 K2xdSSF6tjDpqbaFY0yRxJlWwHCBhUYuSZW84twJMWX0dYeyGMtTjuTF9I7101ry0AfN RJ5uW6k2z6GvgjkJe36aXJZM5TXZjA3btDF45lQBuyZi7VVSDeOdvPcQQUHpli6mrq/R 1gfMwFs9vnVqsWgvVjvdj/1Lh98uUtwZ83axxyDeIMIKNwSyCc4jaSX1DL6hlOp4lNv0 89ig==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3zEZJy2TR3R86wOZDnhA2k60rObsH63DvsNcpQuVuVU=; b=Yo19Kls5byO9dL4V3HRDveGjsFdSUTtTAqpP3QRgq6h9cPvWHw7ZtzujL6C/366QOH xjbR74Tef6tXR9EBCJ6FlwBkn8CicZmmScFMSFmRvJIFVQdILJKZgb88MkabVVvkYSGp dOwV379HAeqaTqHSkfGmXS43AmIMZ/ihzgXBeQDfFdNsXVzD1KvJAIfBo9KBxF5KLN9b zRr936hqj8itzgqWE0395Cyd2ttRbPiNBA4+zEI7omMn2NGdwORduN+H8kbmGLXYSdEh SWrAzw1Wvf4u1IZgTsEylhYzpplw2jiC23pa9VxYse80ZoKm81I62jdP2P1rcP+1dSvM tmgA==
X-Gm-Message-State: AOAM5329D9PWK0DUZ2dIP1nnZNQh51x7IFOCxGFgIG6CUoZ6BRquvi54 MXu25/5mXnNVpi8d2mXZ7Bicrf7f+N6Zr7bjBH0=
X-Google-Smtp-Source: ABdhPJyvQJ4soE6u+iZyJP+VJRAXccpMhjqPdIFQS4QKonT5lw6aXCyg5XyWfJsQlc7Hs8Pe/+5GRNUrSI2edDa9re0=
X-Received: by 2002:a67:7dcd:: with SMTP id y196mr28050749vsc.13.1593102309043; Thu, 25 Jun 2020 09:25:09 -0700 (PDT)
MIME-Version: 1.0
References: <159293956986.23437.659003564832844414@ietfa.amsl.com> <CAKKJt-csgcrjsekG8VDPNPUip3_4T1Nuv-1DSje2WkdsrjfxkA@mail.gmail.com>
In-Reply-To: <CAKKJt-csgcrjsekG8VDPNPUip3_4T1Nuv-1DSje2WkdsrjfxkA@mail.gmail.com>
From: "Murray S. Kucherawy" <superuser@gmail.com>
Date: Thu, 25 Jun 2020 09:24:57 -0700
Message-ID: <CAL0qLwZugn7HZN6-QT6CYjuPV89q8Suz_Jujn92Jya6ez7gG3g@mail.gmail.com>
To: Spencer Dawkins at IETF <spencerdawkins.ietf@gmail.com>
Cc: Codec Encoding for LossLess Archiving and Realtime transmission <cellar@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000038b26f05a8eb0950"
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/HX150cPg_nG0qRgJ6HIbG3mwAJw>
Subject: Re: [Cellar] I-D Action: draft-ietf-cellar-ffv1-15.txt
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Jun 2020 16:25:12 -0000

Hi, thanks for this.  I'm looking now only at the diff between -13 (the
last version I looked at) and this one.

First and foremost, this is mostly better.  Kudos for putting the work in.

Hooray, most of those "type" columns are gone!  But, alas, not all of
them.  They're still present in Sections 4.1 and below.  I counted at least
seven of them just in the diff I'm reviewing.  As before, they should also
be removed, or at least explained.

A minor point: Prior to Section 3.8.2.3, it looks like all of the examples
are in C.  After that, they switch to pseudo code.  Any reason we can't be
consistent?

I suggest that the prose below Table 8, which is a mix of pseudocode and
English, would be better broken apart.

Chairs: RFC 4732 is a downref; please make sure the shepherd calls this out
in the writeup.

There are a few code expressions that would benefit from being wrapped
differently.  For example:

(chroma_planes == 1 && (p == 1 || p == 2)) ? ceil(slice_pixel_height
/ (1 << log2_v_chroma_subsample)) : slice_pixel_height

Maybe this?

chroma_planes == 1 && (p == 1 || p == 2)
  ? ceil(slice_pixel_height / (1 << log2_v_chroma_subsample))
  : slice_pixel_height

-MSK

On Tue, Jun 23, 2020 at 12:26 PM Spencer Dawkins at IETF <
spencerdawkins.ietf@gmail.com> wrote:

> Hi, Murray,
>
> We just confirmed during the Cellar virtual meeting that -15 IS actually
> ready for you to check and confirm that we've addressed the AD comments on
> this draft.
>
> Best,
>
> Spencer
>
> On Tue, Jun 23, 2020 at 2:12 PM <internet-drafts@ietf.org> wrote:
>
>>
>> A New Internet-Draft is available from the on-line Internet-Drafts
>> directories.
>> This draft is a work item of the Codec Encoding for LossLess Archiving
>> and Realtime transmission WG of the IETF.
>>
>>         Title           : FFV1 Video Coding Format Version 0, 1, and 3
>>         Authors         : Michael Niedermayer
>>                           Dave Rice
>>                           Jerome Martinez
>>         Filename        : draft-ietf-cellar-ffv1-15.txt
>>         Pages           : 53
>>         Date            : 2020-06-23
>>
>> Abstract:
>>    This document defines FFV1, a lossless intra-frame video encoding
>>    format.  FFV1 is designed to efficiently compress video data in a
>>    variety of pixel formats.  Compared to uncompressed video, FFV1
>>    offers storage compression, frame fixity, and self-description, which
>>    makes FFV1 useful as a preservation or intermediate video format.
>>
>>
>> The IETF datatracker status page for this draft is:
>> https://datatracker.ietf.org/doc/draft-ietf-cellar-ffv1/
>>
>> There are also htmlized versions available at:
>> https://tools.ietf.org/html/draft-ietf-cellar-ffv1-15
>> https://datatracker.ietf.org/doc/html/draft-ietf-cellar-ffv1-15
>>
>> A diff from the previous version is available at:
>> https://www.ietf.org/rfcdiff?url2=draft-ietf-cellar-ffv1-15
>>
>>
>> Please note that it may take a couple of minutes from the time of
>> submission
>> until the htmlized version and diff are available at tools.ietf.org.
>>
>> Internet-Drafts are also available by anonymous FTP at:
>> ftp://ftp.ietf.org/internet-drafts/
>>
>>
>> _______________________________________________
>> Cellar mailing list
>> Cellar@ietf.org
>> https://www.ietf.org/mailman/listinfo/cellar
>>
>