Re: [Cellar] EBML nits

Steve Lhomme <slhomme@matroska.org> Sun, 11 June 2017 15:34 UTC

Return-Path: <slhomme@matroska.org>
X-Original-To: cellar@ietfa.amsl.com
Delivered-To: cellar@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C8DE6129454 for <cellar@ietfa.amsl.com>; Sun, 11 Jun 2017 08:34:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=matroska-org.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TKJbqDoJ1hpe for <cellar@ietfa.amsl.com>; Sun, 11 Jun 2017 08:34:05 -0700 (PDT)
Received: from mail-yb0-x22c.google.com (mail-yb0-x22c.google.com [IPv6:2607:f8b0:4002:c09::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 071E912940C for <cellar@ietf.org>; Sun, 11 Jun 2017 08:34:04 -0700 (PDT)
Received: by mail-yb0-x22c.google.com with SMTP id 4so22867636ybl.1 for <cellar@ietf.org>; Sun, 11 Jun 2017 08:34:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=matroska-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6210eKKqrBOrd8M7b+JHRn9WNX0dC6Mp3dBT158cn3s=; b=CIzwRV8wXpjtojAYn6d6yeMuNziCTDYEyF1+wbatWL180L3dwtXggIIzHHhu2xlSsq lVk7NcF5jTZTFzm+JqUi0DHMgHHNDdmenjfTXrKvKj1witt/UXD3QAJwrSp2Ve+fPTZg IXupFnznUybc5OLEqh20bm6MPX+m/Qh2/e4Zw763Ed6Tr/hoZ5tA3Ir7j9uzCJjURdgK 2yDG0t6Use3rOz2+/SAmhN0EZGjb/WKGlIjeqAOpq0GwSvjR5BYwbyaKQN154DpwAak0 rpbRsjgmY2u/NOoDRT46fDS1MhBp7tvT6ZUQuaQWAKoLYsqHteM6ZaWkgp/x58ei8hC+ eKfw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6210eKKqrBOrd8M7b+JHRn9WNX0dC6Mp3dBT158cn3s=; b=sXqxBz3eKpTjZgkpqWX9H5w+c6GnUyZdxa55+OpBL1AxhFEy/1+dYfr14Zj7sg+BoT o3KrYfcmgU2y3skjb6MsqWo8NaCp49V+FEguUq5wEOPczMUYpRRGK+3omV6dFwC9NqfZ Cx7ZWNAWDufOFyMJKnH3i/cCFAIkM53Ka6PtPecNC2lJ3ncbWlrBmROrZOfXkIpIKmyE 2MlVkZkxb4EOhVjf8eaqrzYvS1KAzxlgB85SZcd8QSK23Kxo+tLw9y1qvcnu1KByMbjP Xwf6gvIvWXJ9hylw8j6l31rxknAIt7n+uB0C+8LuXXxQgyZuSCEvueF91y5xTvIG1LX2 Rv6g==
X-Gm-Message-State: AODbwcAun1fiNIJScpcEiulSzgB0pekk3e+XiLJtmWx4vSlsTRh9QJoH JKgRSQdyV0KQOlXu8AoHy+hpH/XDcK3E
X-Received: by 10.37.210.214 with SMTP id j205mr21936197ybg.206.1497195244025; Sun, 11 Jun 2017 08:34:04 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.83.128.209 with HTTP; Sun, 11 Jun 2017 08:34:03 -0700 (PDT)
In-Reply-To: <C6267949-F31D-42F9-AB86-7BC530F319B4@dericed.com>
References: <CADK0WuwE=ygo-DXiCTUx0fNZtTXk4NijRhrAxFqV_E4u7suOyg@mail.gmail.com> <C6267949-F31D-42F9-AB86-7BC530F319B4@dericed.com>
From: Steve Lhomme <slhomme@matroska.org>
Date: Sun, 11 Jun 2017 17:34:03 +0200
Message-ID: <CAOXsMFJ+3bccLSd=6J9u+N+YJxk5WnxRE49hEQ5UqWSKVhZUog@mail.gmail.com>
To: Dave Rice <dave@dericed.com>
Cc: Tessa Fallon <tessa.fallon@gmail.com>, Codec Encoding for LossLess Archiving and Realtime transmission <cellar@ietf.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://mailarchive.ietf.org/arch/msg/cellar/eN2Gmf6wPJc3Tn_UR26ID2Sx2HA>
Subject: Re: [Cellar] EBML nits
X-BeenThere: cellar@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Codec Encoding for LossLess Archiving and Realtime transmission <cellar.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cellar>, <mailto:cellar-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cellar/>
List-Post: <mailto:cellar@ietf.org>
List-Help: <mailto:cellar-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cellar>, <mailto:cellar-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Jun 2017 15:34:07 -0000

2017-06-09 1:19 GMT+02:00 Dave Rice <dave@dericed.com>:
>
> On Jun 7, 2017, at 12:37 PM, Tessa Fallon <tessa.fallon@gmail.com> wrote:
>
> Generated by running nits from:
> https://datatracker.ietf.org/doc/draft-ietf-cellar-ebml/
>
> idnits 2.14.02
>
> /tmp/draft-ietf-cellar-ebml-02.txt:
>
> […]
>
>   Checking nits according to http://www.ietf.org/id-info/checklist :
>
> ----------------------------------------------------------------------------
>
>   ** The document seems to lack an IANA Considerations section.  (See
> Section
>      2.2 of http://www.ietf.org/id-info/checklist for how to handle the case
>      when there are no actions for IANA.)
>
> There was an earlier conversation on the listserv about this at
> https://mailarchive.ietf.org/arch/msg/cellar/bdLfldsG7bK9A_DXaN9D1Mjkmkw. We
> considered a mime type for generic EBML but the thread concluded with
> suggestions that this would be better handled at the EBML Document type
> level rather than upon EBML itself.
>
> So I’m adding a pull request with the "This document has no IANA actions.”
> boilerplate. The pull request is here
> github.com/Matroska-Org/ebml-specification/pull/150. If there’s other iana
> considerations that we’ve neglected please mention them.

LGTM

>   ** There are 18 instances of too long lines in the document, the longest
>      one being 113 characters in excess of 72.
>
> I think this was resolved with some line wrapping fixes in
> https://github.com/Matroska-Org/ebml-specification/pull/149.

LGTM

> […]
>
>   -- Possible downref: Non-RFC (?) normative reference: ref. 'IEEE.754.1985'
>
>   -- Possible downref: Non-RFC (?) normative reference: ref. ‘ITU.V42.1994'
>
> Are these comments worth addressing?

I would say no. Maybe the format could be different ?

>   ** Obsolete normative reference: RFC 2279 (Obsoleted by RFC 3629)
>
> This was a reference to the UTF-8 spec. I update the version in
> http://github.com/Matroska-Org/ebml-specification/pull/151.

LGTM

> Dave Rice
>
> _______________________________________________
> Cellar mailing list
> Cellar@ietf.org
> https://www.ietf.org/mailman/listinfo/cellar
>



-- 
Steve Lhomme
Matroska association Chairman