Re: [CFRG] Proposed resolution for erratum 5930 on RFC 8032

Daniel Kahn Gillmor <dkg@fifthhorseman.net> Fri, 21 May 2021 22:13 UTC

Return-Path: <dkg@fifthhorseman.net>
X-Original-To: cfrg@ietfa.amsl.com
Delivered-To: cfrg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2FC553A229A for <cfrg@ietfa.amsl.com>; Fri, 21 May 2021 15:13:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.099
X-Spam-Level:
X-Spam-Status: No, score=-2.099 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=neutral reason="invalid (unsupported algorithm ed25519-sha256)" header.d=fifthhorseman.net header.b=saJaHsnD; dkim=pass (2048-bit key) header.d=fifthhorseman.net header.b=BuivzwtM
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ckfPbftw3dyi for <cfrg@ietfa.amsl.com>; Fri, 21 May 2021 15:13:43 -0700 (PDT)
Received: from che.mayfirst.org (che.mayfirst.org [IPv6:2001:470:1:116::7]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 916853A229C for <cfrg@irtf.org>; Fri, 21 May 2021 15:13:43 -0700 (PDT)
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1621635220; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=JYZdkfyHGpCMgCdCle3nb18IAgZK+VE5P8iPtT/Ur/U=; b=saJaHsnDL41bQ8zkDF/6mb0c/h0cs9gbeafFvrSyINIo3gVZaXEKsNVSnVs+NttEQkzAB /xP09xTPfritD54CA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1621635220; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=JYZdkfyHGpCMgCdCle3nb18IAgZK+VE5P8iPtT/Ur/U=; b=BuivzwtM79mKZWvygVBiHMMD9ntPaCc6umtLbX+dnYJ+y7G+xaJ+EvU45osONJ07GTU/Z /uJQChZUFr/MtJNbFZV7YemxBknCzweDOlm4AoicDjzGx6ShJz5oSzEIRcEFc5mZelAQzeI VVgMExzMe3eWdA+Yr5pqs5BzPsxatL0vZD730GRUAPZgHFPGwZdvtMscpy6XR9AmdjbQ6jK dr4pqLnNKngPrujfskGrW8dX8+E2mUR+Rk4QEy8JKwBj6LuxS1A3XDzbvGLnLr5UmdBTw9n MnoR8Y0VsiEVLO4g0A3M5lCUq8C6LoW4zqCm1DKNG5Z8Roi0VZgYBxkVxCQg==
Received: from fifthhorseman.net (lair.fifthhorseman.net [108.58.6.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 4C6F7F9A5; Fri, 21 May 2021 18:13:40 -0400 (EDT)
Received: by fifthhorseman.net (Postfix, from userid 1000) id ADF4021D0C; Fri, 21 May 2021 18:13:37 -0400 (EDT)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Ilari Liusvaara <ilariliusvaara@welho.com>, Alexey Melnikov <alexey.melnikov@isode.com>
Cc: "cfrg@irtf.org" <cfrg@irtf.org>
In-Reply-To: <YAUiF8vQ214FrPus@LK-Perkele-VII>
References: <42fdca41-bfdd-9d75-b144-0e2f3b5fa1d9@isode.com> <YAUiF8vQ214FrPus@LK-Perkele-VII>
Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH
Date: Fri, 21 May 2021 18:13:36 -0400
Message-ID: <87v97bd9bj.fsf@fifthhorseman.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature"
Archived-At: <https://mailarchive.ietf.org/arch/msg/cfrg/PkruUrbZFIBCRrHOIcbdoo1A_AQ>
Subject: Re: [CFRG] Proposed resolution for erratum 5930 on RFC 8032
X-BeenThere: cfrg@irtf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Crypto Forum Research Group <cfrg.irtf.org>
List-Unsubscribe: <https://www.irtf.org/mailman/options/cfrg>, <mailto:cfrg-request@irtf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cfrg/>
List-Post: <mailto:cfrg@irtf.org>
List-Help: <mailto:cfrg-request@irtf.org?subject=help>
List-Subscribe: <https://www.irtf.org/mailman/listinfo/cfrg>, <mailto:cfrg-request@irtf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 May 2021 22:13:50 -0000

I note that erratum 5930 is still in the "reported" stage for RFC 8032,
despite it being clearly correct.  Can we move it to "Verified"?  I
don't much care whether it is marked as "Technical" or "Editorial".

   https://www.rfc-editor.org/errata_search.php?eid=5930

        --dkg

On Mon 2021-01-18 07:52:23 +0200, Ilari Liusvaara wrote:
> On Fri, Jan 15, 2021 at 05:39:22PM +0000, Alexey Melnikov wrote:
>> Dear CFRG (and editors),
>> 
>> Daniel Bleichenbacher submitted the following editorial erratum on RFC 8032
>> ("Edwards-Curve Digital Signature Algorithm (EdDSA)")
>> 
>> Section 6 says:
>> 
>> OLD:
>> 
>> def verify(public, msg, signature):
>>     if len(public) != 32:
>>         raise Exception("Bad public key length")
>>     if len(signature) != 64:
>>         Exception("Bad signature length")
>> 
>> It should say:
>> 
>> def verify(public, msg, signature):
>>     if len(public) != 32:
>>         raise Exception("Bad public key length")
>>     if len(signature) != 64:
>>         raise Exception("Bad signature length")
>> 
>> 
>> Note: Missing raise before Exception
>> 
>> -------------------
>> 
>> This is indeed looks like a Python syntax error. So I propose to resolve
>> this erratum as suggested by Daniel.
>> 
>
> While I think the proposed text above is correct, I am not so sure about
> the errata being marked editorial (I very well might be incorrect here).
> The error makes code work incorrectly (on one case with invalid input),
> it is not an error in code that does not affect function (e.g., typo in
> comment or consistent typo in variable name).
>
>
>
> -Ilari
>
> _______________________________________________
> CFRG mailing list
> CFRG@irtf.org
> https://www.irtf.org/mailman/listinfo/cfrg