Re: [Cfrg] [irsg] IRSG review of draft-irtf-cfrg-ocb

Stephen Farrell <stephen.farrell@cs.tcd.ie> Mon, 13 January 2014 23:35 UTC

Return-Path: <stephen.farrell@cs.tcd.ie>
X-Original-To: cfrg@ietfa.amsl.com
Delivered-To: cfrg@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 5768E1AE1EF; Mon, 13 Jan 2014 15:35:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.438
X-Spam-Level:
X-Spam-Status: No, score=-2.438 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RP_MATCHES_RCVD=-0.538] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kt0sEocPEeAx; Mon, 13 Jan 2014 15:35:11 -0800 (PST)
Received: from mercury.scss.tcd.ie (mercury.scss.tcd.ie [134.226.56.6]) by ietfa.amsl.com (Postfix) with ESMTP id BEDD31AE1E2; Mon, 13 Jan 2014 15:35:07 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mercury.scss.tcd.ie (Postfix) with ESMTP id A5A02BE3E; Mon, 13 Jan 2014 23:34:55 +0000 (GMT)
X-Virus-Scanned: Debian amavisd-new at scss.tcd.ie
Received: from mercury.scss.tcd.ie ([127.0.0.1]) by localhost (mercury.scss.tcd.ie [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rducZXSbPo3k; Mon, 13 Jan 2014 23:34:54 +0000 (GMT)
Received: from [10.87.48.14] (unknown [86.41.60.148]) by mercury.scss.tcd.ie (Postfix) with ESMTPSA id 270DABE35; Mon, 13 Jan 2014 23:34:54 +0000 (GMT)
Message-ID: <52D4781D.7010800@cs.tcd.ie>
Date: Mon, 13 Jan 2014 23:34:53 +0000
From: Stephen Farrell <stephen.farrell@cs.tcd.ie>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: David McGrew <mcgrew@cisco.com>, "Eggert, Lars" <lars@netapp.com>, Kevin Fall <kfall@sei.cmu.edu>
References: <52CAF84D.2020600@cisco.com> <92C1A824-6009-4F8C-A304-0EC837C3D427@ericsson.com> <20266F45-9F2E-4CBA-A65C-EB315B673BA6@netapp.com> <52D29212.4070205@cisco.com> <52D44320.6020000@cisco.com>
In-Reply-To: <52D44320.6020000@cisco.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: =?ISO-8859-1?Q?B=F6rje_Ohlman?= <borje.ohlman@ericsson.com>, Cfrg@irtf.org, "irsg@irtf.org" <irsg@irtf.org>
Subject: Re: [Cfrg] [irsg] IRSG review of draft-irtf-cfrg-ocb
X-BeenThere: cfrg@irtf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Crypto Forum Research Group <cfrg.irtf.org>
List-Unsubscribe: <http://www.irtf.org/mailman/options/cfrg>, <mailto:cfrg-request@irtf.org?subject=unsubscribe>
List-Archive: <http://www.irtf.org/mail-archive/web/cfrg/>
List-Post: <mailto:cfrg@irtf.org>
List-Help: <mailto:cfrg-request@irtf.org?subject=help>
List-Subscribe: <http://www.irtf.org/mailman/listinfo/cfrg>, <mailto:cfrg-request@irtf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jan 2014 23:35:14 -0000

Hi David,

On 01/13/2014 07:48 PM, David McGrew wrote:
> So you don't need to look for it: the ticket for draft-irtf-cfrg-ocb
> http://trac.tools.ietf.org/group/irtf/trac/ticket/55
> 
> Stephen, thanks for offering to do the review.

No problem. My review below. My points are all nits. This is
ready.

- I think s/privacy/confidentiality/g would be a good change.
Privacy involves more than confidentiality and crypto only
provides the latter. But this draft is by no means the only
sinner in this respect.

- "As with most modes of operation, security degrades in the
square of the number of blocks of texts divided by two to the
blocklength." That could do with a reference or being expanded a
bit. The CFRG reader should be ok with it but if/when OCB gets
some IETF adoption, or when this is read by less crypto-aware
folk, that will be too terse I think. (The same point is made in
the security considerations more clearly so maybe could be
deleted from the earlier section. But maybe its now in twice
because of someone else's comment;-)

- I didn't check the algorithm description nor examples in
detail as IRSG review assumes the RG did that.

Process crapology below. CFRG can ignore.

- Section 6 - Its normal to actually ask IANA to do stuff so
they know what to do when reviewing the draft. And then the text
is changed by the RFC editor to say that IANA has added etc. No
big deal because they'll figure it out.

- Not related to this draft: RFC 5116 says AEAD registrations
SHOULD be reviewed by CFRG. What if CFRG ceases to exist? Be no
harm to sometime say who'd inherit that role maybe. I guess if
the IRTF don't say, and if/when CFRG passes away, then IANA will
ask the IAB/IRSG/IESG probably and there'll be a minor fuss when
someone gets the wrong end of the stick. That's one for Lars
really - what should happen in general with IANA registries
depending on expired RGs for review? (My take - IRTF chair
appoints an expert reviewer or two when killing an RG with
registries and use IRSG list for discussion of requests until
that gets to be a PITA. But before Lars asks, no, I won't
write a draft describing that just now:-)

- I note that the IETF tools page doesn't list the IPR for this
but does for draft-krovetz-ocb. The datatracker page does show
the IPR correctly. I thought that had been fixed since the
replaced-by stuff seems right here. Ah well.

Cheers,
S.