Re: [Cfrg] Crypto-panel review of draft-selander-ace-cose-ecdhe-12

Russ Housley <housley@vigilsec.com> Wed, 27 February 2019 15:08 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: cfrg@ietfa.amsl.com
Delivered-To: cfrg@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E8986130FCF for <cfrg@ietfa.amsl.com>; Wed, 27 Feb 2019 07:08:12 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JnHl9llyWF9n for <cfrg@ietfa.amsl.com>; Wed, 27 Feb 2019 07:08:11 -0800 (PST)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4BD46130E71 for <cfrg@irtf.org>; Wed, 27 Feb 2019 07:08:11 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 93845300AA6 for <cfrg@irtf.org>; Wed, 27 Feb 2019 09:49:53 -0500 (EST)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WyZNGuVsV_NY for <cfrg@irtf.org>; Wed, 27 Feb 2019 09:49:52 -0500 (EST)
Received: from [172.20.10.2] (mobile-166-170-34-146.mycingular.net [166.170.34.146]) by mail.smeinc.net (Postfix) with ESMTPSA id 0211F3004E7; Wed, 27 Feb 2019 09:49:51 -0500 (EST)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <9EBFB09A-8A88-4D69-8662-355BB79895D7@ericsson.com>
Date: Wed, 27 Feb 2019 10:02:44 -0500
Cc: IRTF CFRG <cfrg@irtf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <CC2B361C-606F-4084-AEB7-D5300B290B22@vigilsec.com>
References: <5e587cf8-2275-b682-e390-e83529a8d0d8@isode.com> <57C131DC-1DDD-4F23-A9E8-FA822874465D@vigilsec.com> <9EBFB09A-8A88-4D69-8662-355BB79895D7@ericsson.com>
To: John Mattsson <john.mattsson@ericsson.com>
X-Mailer: Apple Mail (2.3445.102.3)
Archived-At: <https://mailarchive.ietf.org/arch/msg/cfrg/wnpDPaAZhIC9HoOazEh8stnkBx0>
Subject: Re: [Cfrg] Crypto-panel review of draft-selander-ace-cose-ecdhe-12
X-BeenThere: cfrg@irtf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Crypto Forum Research Group <cfrg.irtf.org>
List-Unsubscribe: <https://www.irtf.org/mailman/options/cfrg>, <mailto:cfrg-request@irtf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cfrg/>
List-Post: <mailto:cfrg@irtf.org>
List-Help: <mailto:cfrg-request@irtf.org?subject=help>
List-Subscribe: <https://www.irtf.org/mailman/listinfo/cfrg>, <mailto:cfrg-request@irtf.org?subject=subscribe>
X-List-Received-Date: Wed, 27 Feb 2019 15:08:13 -0000

>> Minor Concerns:
> 
>> In addition, it would help the reader to provide a forward pointer to
>> the sections define the aad_2 and aad_3 structures.
> 
> That was added to Section 3.3. in versrion 12: "where aad_2 and aad_3 are hashes of previous messages and data, defined in Sections 4.3.1 and 4.4.1." Is there any other place that would benefit from a pointers?

This is a minor concern, but to me, the pointers would have been more useful in the bullets earlier in Section 3.3.

Russ