Re: [clue] Roman Danyliw's No Objection on draft-ietf-clue-datachannel-15: (with COMMENT)

Christer Holmberg <christer.holmberg@ericsson.com> Thu, 11 April 2019 10:04 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: clue@ietfa.amsl.com
Delivered-To: clue@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05C941202B7; Thu, 11 Apr 2019 03:04:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.002
X-Spam-Level:
X-Spam-Status: No, score=-2.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bhExaBkXacpy; Thu, 11 Apr 2019 03:04:15 -0700 (PDT)
Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60048.outbound.protection.outlook.com [40.107.6.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BF72A1200F1; Thu, 11 Apr 2019 03:04:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0YqAbyVM0Pix3b+3Xb5VPL/RMu5cnYtbqgAqi0bKYnM=; b=Obb1AXlmSWqWuqpj+0250Ratad1HjhEKq+Qdx5x1I/qfo0w7cQmjQO8UP0E1QAACWhDKUrtcf0OtyxCB7Zqx9F0Y6/j882k0kkQCSQsBps4StxcpTMN4eL/cnvtLnv6VtI2ZrGEHDBfCeWswgV0D3tSQ3iD3xZ9o5SleMd38vVs=
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com (10.170.245.23) by HE1PR07MB0956.eurprd07.prod.outlook.com (10.162.27.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1792.8; Thu, 11 Apr 2019 10:04:11 +0000
Received: from HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::a832:85f:a8bb:73b9]) by HE1PR07MB3161.eurprd07.prod.outlook.com ([fe80::a832:85f:a8bb:73b9%5]) with mapi id 15.20.1792.007; Thu, 11 Apr 2019 10:04:11 +0000
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: Roman Danyliw <rdd@cert.org>, The IESG <iesg@ietf.org>
CC: "draft-ietf-clue-datachannel@ietf.org" <draft-ietf-clue-datachannel@ietf.org>, Paul Kyzivat <pkyzivat@alum.mit.edu>, "clue-chairs@ietf.org" <clue-chairs@ietf.org>, "clue@ietf.org" <clue@ietf.org>
Thread-Topic: Roman Danyliw's No Objection on draft-ietf-clue-datachannel-15: (with COMMENT)
Thread-Index: AQHU7/9ZgDYUpQVkLEmJcQaXFAVfoaY27h2A
Date: Thu, 11 Apr 2019 10:04:11 +0000
Message-ID: <09C84C5D-E295-479F-B5E6-CA38696E8F00@ericsson.com>
References: <155494329235.22694.2977698573542744808.idtracker@ietfa.amsl.com>
In-Reply-To: <155494329235.22694.2977698573542744808.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/10.16.1.190220
authentication-results: spf=none (sender IP is ) smtp.mailfrom=christer.holmberg@ericsson.com;
x-originating-ip: [89.166.49.243]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 3dd4e7c8-c644-4e80-d22c-08d6be650bc7
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:HE1PR07MB0956;
x-ms-traffictypediagnostic: HE1PR07MB0956:
x-microsoft-antispam-prvs: <HE1PR07MB0956C7DE0A51C66ECC452B21932F0@HE1PR07MB0956.eurprd07.prod.outlook.com>
x-forefront-prvs: 00046D390F
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(376002)(346002)(136003)(396003)(199004)(189003)(6506007)(86362001)(53936002)(6436002)(6246003)(6486002)(68736007)(82746002)(305945005)(7736002)(25786009)(229853002)(4326008)(105586002)(478600001)(2906002)(256004)(106356001)(486006)(3846002)(186003)(66066001)(11346002)(71190400001)(2616005)(83716004)(76176011)(446003)(102836004)(26005)(71200400001)(476003)(110136005)(81166006)(8936002)(54906003)(99286004)(36756003)(33656002)(58126008)(316002)(6512007)(81156014)(8676002)(14454004)(44832011)(6116002)(5660300002)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB0956; H:HE1PR07MB3161.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: PUjsEPtEJDUTBkoz4GEWehUp2QMPJGs/Wkyfn1gyi64f+eV9X8znlGKloCThUBrkccEXzk/paKrxtsEDN31GqQrjLsTTYQ9cB1Vq0hA5nbhHK1KaUgVIl5X80y88m9Z+wYeukF8w45gwWat7/YVrxoGK8ksoVuaue/OqUJOLniJ/j5bZ1F5vLAAg5zbatNLunKFjSSGVvfsudaqsn4sXuB9dWEhBWQoTVi4KwqPCDm2swiy4Q5oWwGttMVYo4LbJn81fkjWgzAjJe5o5DGyOwvBtLvF3FXDTOJsA4f7tUMQrUiycR6x2c57mghvoq/xsIDndJ3tNFtTluw/BopTdPGgvhq9eMkxr39veZsBKbOGem2U29TSpUtjlLh3N2t37nxneFT4v4YdM0BUNcmARS7ThMuot+Tl3c5ackh5D66k=
Content-Type: text/plain; charset="utf-8"
Content-ID: <CC52785FBE85B245B8B425241A9D9259@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3dd4e7c8-c644-4e80-d22c-08d6be650bc7
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2019 10:04:11.6591 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB0956
Archived-At: <https://mailarchive.ietf.org/arch/msg/clue/7iv2E-Qqhs4HGsQWD0aN6hsaU4c>
Subject: Re: [clue] Roman Danyliw's No Objection on draft-ietf-clue-datachannel-15: (with COMMENT)
X-BeenThere: clue@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CLUE - ControLling mUltiple streams for TElepresence <clue.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/clue>, <mailto:clue-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/clue/>
List-Post: <mailto:clue@ietf.org>
List-Help: <mailto:clue-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/clue>, <mailto:clue-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2019 10:04:17 -0000

Hi Roman,

Thank You for the review! Please see inline.

    ----------------------------------------------------------------------
    COMMENT:
    ----------------------------------------------------------------------
    
    A few nits:
    
>    (1) Section 1.  Typo (missing space).
>    
>    s/[I-D.ietf-clue-protocol]messages/
>    [I-D.ietf-clue-protocol] messages/
  
Will fix.

---
  
>    (2) Section 1. Editorial Nit.
>    
>    s/data channel Establishment Protocol/
>    Data Channel Establishment Protocol/
  
Will fix.

---

>    (3) Section 3.2.1, Typo
>    
>    s/(e.g. regarding ordered delivery )/
>    (e.g., regarding ordered delivery)/
  
Will fix.

---

>    (4) Section 3.2.1.  Typo.  s/signalled/signaled/
  
Will fix.

---
  
>    (5) Section 3.2.3, Per “[I-D.ietf-rtcweb-data-channel] also mandates support of
>    the limited retransmission policy defined in [RFC7496].”, I was expecting to
>    read something about how this extension is also not needed by CLUE like the
>    previous part of the paragraph.  Right now the text only states something about
>    rtcweb but not CLUE.
    
Good catch! I suggest to modify the text in the following way:

   "NOTE: [I-D.ietf-rtcweb-data-channel] requires the support of the
   partial reliability extension defined in [RFC3758] and the limited
   retransmission policy defined in [RFC7496]. The extensions are not
   needed for a CLUE data channel, as messages are required to always be
   sent reliably."

In addition, I suggest to add a reference to RFC 7496 to the text in the paragraph above, in the following way:

    "A CLUE entity MUST NOT use the partial reliability, defined in [RFC3758], or the limited
    retransmission SCTP extensions, defined in [RFC3758], for the CLUE data channel."

Thanks!

Regards,

Christer