Re: [clue] XML review of draft-ietf-clue-protocol

"Martin Thomson" <mt@lowentropy.net> Tue, 17 December 2019 01:39 UTC

Return-Path: <mt@lowentropy.net>
X-Original-To: clue@ietfa.amsl.com
Delivered-To: clue@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C2F5712096E; Mon, 16 Dec 2019 17:39:24 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.698
X-Spam-Level:
X-Spam-Status: No, score=-2.698 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=lowentropy.net header.b=E2dKPuHO; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=HT5Us5VB
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AkIHp40aqqXD; Mon, 16 Dec 2019 17:39:22 -0800 (PST)
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7BFBD120945; Mon, 16 Dec 2019 17:39:22 -0800 (PST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 81E38221F8; Mon, 16 Dec 2019 20:39:21 -0500 (EST)
Received: from imap2 ([10.202.2.52]) by compute1.internal (MEProxy); Mon, 16 Dec 2019 20:39:21 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lowentropy.net; h=mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type; s=fm1; bh=A19Egj8a6EotIKJddv702DG3glMgKGw O9bztx+4vq5Y=; b=E2dKPuHOWsqzec+eoeDzqHP2jshutnKV4/hHQW2YVicniM3 w0r0vdxsVp0r9I8cLrxZvomJdCdDyvyTO1yjtO6+ZMJ8awrDNriGX1UtHWdaJs/d FcXk+FFuRXDlDo2LHIGkLJoZwRRmP37zCHcBfIhbGZGabtvWzlHYR3KaZh8Vjqph bX/uZi3rqvGw63WSByK2JApX7Ot5gWsiD8eyOlIRA9c6tcNvY59uF4Gjm2cyFdCp ZsyOk/13bxnR/Vlx7UiAcLpJRCNJTtcvkAhtqM+zfwiBd7XcACpHzPOQ+AOWYFPW DBQZST8Frgbmtbzdf/WA2hyavymSJGFYITKGsww==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=A19Egj 8a6EotIKJddv702DG3glMgKGwO9bztx+4vq5Y=; b=HT5Us5VBcJYkj9oh+Gd8ft D/2PKWuPLxBTSvhamxcfdlachszwguaffogahcwdNRx0R+vtulfwdwoC+V4T9xzl SLzm3aNZDSuDcFv03rxIuI25trgJmw86/RmBJP/NrNYztZZ3aR7p/RXbrRhoXJBI pSWr84APkPnrJveOTvzplIMpdiv/sMr6irfji+2IjwKeL9cvi0lc09WDHxEhyYt1 RuthEDoPVwIdQnHlvaJTkIDe3T3yjONboiqQoh7L1DLUYRXr8eZQzzzPsL4yE7Dg MYlQ0keVzRbHFpXxfa1XlyzpZaF8+hcj3c01x0cIqB2ii17LFqqGZ2HgIAz85ZKA ==
X-ME-Sender: <xms:yTH4XVzMpEaz1wlvF64lhecI-5y0xJWIYmcGnY10p7ctyLW54yu6Gg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddtiedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtsehttd ertderredtnecuhfhrohhmpedfofgrrhhtihhnucfvhhhomhhsohhnfdcuoehmtheslhho figvnhhtrhhophihrdhnvghtqeenucffohhmrghinhepuhhnihhnrgdrihhtnecurfgrrh grmhepmhgrihhlfhhrohhmpehmtheslhhofigvnhhtrhhophihrdhnvghtnecuvehluhhs thgvrhfuihiivgeptd
X-ME-Proxy: <xmx:yTH4XVHIzfQcjQ5NiMEBkhQrVFZHX6TI3KQw54ICsagv6L5Paz4wxA> <xmx:yTH4XR6YdZOTZhgQvbpsYhHMfIakdGQ3ZTpDsV3ZNzmCAshTJg_Kmg> <xmx:yTH4XUERbRb4P2-rKIfKv_lVyRKb8M2N_xTDGYUuNNTJXfWbuyBuDQ> <xmx:yTH4XVyMuP2JsIMbjQG8pEBXrNAv_-7MKY83PgyFRnBdWTKe8aKE9w>
Received: by mailuser.nyi.internal (Postfix, from userid 501) id 1A7EFE00A2; Mon, 16 Dec 2019 20:39:21 -0500 (EST)
X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.1.7-689-g5a57b82-fmstable-20191216v1
Mime-Version: 1.0
Message-Id: <9f6bd42b-1b7a-454c-8ee4-8aa0f2e66eef@www.fastmail.com>
In-Reply-To: <7d93fd15-98ac-40ed-be43-d1ecde3e5d4e@www.fastmail.com>
References: <7d93fd15-98ac-40ed-be43-d1ecde3e5d4e@www.fastmail.com>
Date: Tue, 17 Dec 2019 12:39:01 +1100
From: Martin Thomson <mt@lowentropy.net>
To: clue@ietf.org, draft-ietf-clue-protocol.all@ietf.org
Content-Type: text/plain
Archived-At: <https://mailarchive.ietf.org/arch/msg/clue/aHJ3vSaLele73Rra3szKAVf394Q>
Subject: Re: [clue] XML review of draft-ietf-clue-protocol
X-BeenThere: clue@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CLUE - ControLling mUltiple streams for TElepresence <clue.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/clue>, <mailto:clue-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/clue/>
List-Post: <mailto:clue@ietf.org>
List-Help: <mailto:clue-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/clue>, <mailto:clue-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Dec 2019 01:39:25 -0000

In the form of RFC editor notes for the first item:

Section 9:
REMOVE:
   NOTE TO THE RFC-Editor: Please replace "data-model-schema-19.xsd"
   with the right schema location for the CLUE data model schema
   document (which is still to be defined at the time of this writing)
   in this section prior to publication as an RFC.

REMOVE:
        xmlns:tns="urn:ietf:params:xml:ns:clue-protocol"

OLD:
  <xs:import namespace="urn:ietf:params:xml:ns:clue-info"
        schemaLocation="clue-data-model-schema-19.xsd" />
NEW:
  <xs:import namespace="urn:ietf:params:xml:ns:clue-info"/>

And in Sections 10.1 through 10.9:
REMOVE:
    xsi:schemaLocation="urn:ietf:params:xml:ns:clue-protocol
    http://wpage.unina.it/spromano/clue-protocol-17-schema-file.xsd"


The others would have been better to fix, but they don't need to block document publication.



On Tue, Dec 17, 2019, at 09:00, Martin Thomson wrote:
> (I sent the original of this email in October 2018, then forgot about 
> it.  Apparently it never made it through.  Here's hoping that it works 
> this time.  Trying with a different, maybe better privileged, account.)
> ---
> 
> I was asked to provide expert review of the registrations for the XML
> schema in this document and noticed a few problems.  I also have a few
> suggestions.
> 
> 1. Don't use schemaLocation in this document, especially in the
> schema, but also in examples.
> 
> 2. Please try to be more consistent with prefixes throughout.  The
> namespace defined in the draft is sometimes given no prefix, sometimes
> the overly generic "ns2".  I appreciate that these are generated
> examples, but more thought needs to be given to that.  In particular,
> the schema assigns two different prefixes to the same namespace.
> 
> 3. This definition is useless:
> 
>     <xs:attribute name="protocol" type="xs:string" fixed="CLUE"
>         use="required" />
> 
> All that a definition like this does is force people to waste bytes.
> The namespace is sufficient to identify the protocol.  Use of fixed
> and required attributes is best left to restrictions of complex types.
> 
> 4. You can add the attribute extension point to the base message
> definition.  Element extensions unfortunately have to be attached to
> specific message types for ordering reasons, but attributes are
> unordered.
> 
> 5. Consider vertical whitespace in your code.  It helps readability
> considerably.