Re: [codec] I-D Action: draft-ietf-codec-oggopus-00.txt

"Timothy B. Terriberry" <tterribe@xiph.org> Fri, 24 May 2013 17:11 UTC

Return-Path: <tterribe@xiph.org>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4E1E621F9617 for <codec@ietfa.amsl.com>; Fri, 24 May 2013 10:11:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.677
X-Spam-Level:
X-Spam-Status: No, score=-2.677 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_MISMATCH_ORG=0.611, HOST_MISMATCH_COM=0.311, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A0+03vktxNgx for <codec@ietfa.amsl.com>; Fri, 24 May 2013 10:11:11 -0700 (PDT)
Received: from smtp.mozilla.org (mx2.corp.phx1.mozilla.com [63.245.216.70]) by ietfa.amsl.com (Postfix) with ESMTP id 8187321F9497 for <codec@ietf.org>; Fri, 24 May 2013 10:11:11 -0700 (PDT)
Received: from [10.250.6.54] (unknown [63.245.220.240]) (Authenticated sender: tterriberry@mozilla.com) by mx2.mail.corp.phx1.mozilla.com (Postfix) with ESMTPSA id BC1A7F25E8 for <codec@ietf.org>; Fri, 24 May 2013 10:11:10 -0700 (PDT)
Message-ID: <519F9F2E.8060001@xiph.org>
Date: Fri, 24 May 2013 10:11:10 -0700
From: "Timothy B. Terriberry" <tterribe@xiph.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/20100101 SeaMonkey/2.16.2
MIME-Version: 1.0
To: codec@ietf.org
References: <20121119225213.13225.30835.idtracker@ietfa.amsl.com> <50AABA00.6030102@xiph.org> <515609F7.7090402@jmvalin.ca>
In-Reply-To: <515609F7.7090402@jmvalin.ca>
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Subject: Re: [codec] I-D Action: draft-ietf-codec-oggopus-00.txt
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 24 May 2013 17:11:17 -0000

Jean-Marc Valin wrote:
> Here's a revised patch that describes guidelines for encoders. These
> guidelines are related to gapless support, but I'm sure there's other
> recommendations we should give encoder implementers. The general idea is
> to minimize the number of broken or suboptimal encoders.

(as an individual contributor)
I like this much better than your earlier proposal that required special 
handling in the decoder, since it doesn't require any changes to 
already-deployed decoders, and keeps the decoding process (relatively) 
simple.

A few minor points:
- The start of the Encoder Guidelines section should forward-reference 
the LPC Extrapolation section.
- Need a reference on how to actually compute the linear prediction 
coefficients. We have references to both the Burg method and the Schur 
algorithm in RFC 6716, and source code in libvorbis. Some implementation 
guidance wouldn't be amiss.
- The language in general needs a little word-smithing. We can 
coordinate on that in git.