Re: [codec] WGLC of draft-ietf-codec-opus-07

[Jean-Marc Valin <[e-mail]>]

Hi Jehan,

Thanks for the feedback. See below.

Jehan Pagès <[e-mail]> a écrit :
> * Section "3. Codec Modes" (page 11):
> « For code 2 packets, the TOC byte is followed by a one or two byte
>    sequence indicating the the length of the first frame (marked N1 in
>    the figure below), followed by N1 bytes of compressed data for the
>    first frame. »
> => there is a "the the" repetition.

Will fix.

> * Just below, in the same paragraph:
> «
> The
>    length of the first frame, N1, MUST be no larger than the size of the
>    payload remaining after decoding that length for all code 2 packets.
> »
> => I am not sure what it means? Aren't we simply telling that the
> advertised length must not be larger than the actual length (which
> appears logical to be by "definition" of "length")?

Pretty much. It means that if a packet contains two frames, then the  
first can't be bigger than the packet.

> * At the beginning of section "4. Opus decoder", the little graph has
> a block which says "SILK encoder". I think it was supposed to say
> "SILK decoder", no?

Will fix.

> Also probably a stupid question for someone new here, but I wondered:
> what is exactly the role of padding? Is there an interest to have a
> fixed size of packets on some platform for instance?

There's many potential uses. One example is that in some cases, it may  
be desirable to take an existing VBR stream and turn it into a CBR  
stream. For example, this can be done to prevent information leakage  
over SRTP as suggested in  
http://tools.ietf.org/html/draft-perkins-avt-srtp-vbr-audio . Now,  
this could be done via RTP padding *except* that the RTP padding bit  
is not encrypted. So if we wanted to use RTP padding, we'd have to pad  
*every* frame to avoid leaking information. Keep in mind that the  
padding feature is also using a single bit that would otherwise be  
unused.

> That's all from me. Sorry for not being more helpful.

Any review is useful.

Cheers,

       Jean-Marc