Re: [codec] Fwd: New Version Notification for draft-valin-codec-opus-update-00.txt

Tina le Grand <tina.legrand@webrtc.org> Fri, 06 September 2013 11:35 UTC

Return-Path: <tlegrand@google.com>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B47F821E80AA for <codec@ietfa.amsl.com>; Fri, 6 Sep 2013 04:35:41 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.311
X-Spam-Level:
X-Spam-Status: No, score=-0.311 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, FM_FORGED_GMAIL=0.622, HTML_MESSAGE=0.001, NO_RELAYS=-0.001, SARE_HTML_USL_OBFU=1.666]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Iu1xxY5KChsq for <codec@ietfa.amsl.com>; Fri, 6 Sep 2013 04:35:41 -0700 (PDT)
Received: from mail-ie0-x22e.google.com (mail-ie0-x22e.google.com [IPv6:2607:f8b0:4001:c03::22e]) by ietfa.amsl.com (Postfix) with ESMTP id 0B8BC11E818D for <codec@ietf.org>; Fri, 6 Sep 2013 04:35:40 -0700 (PDT)
Received: by mail-ie0-f174.google.com with SMTP id k5so807759iea.5 for <codec@ietf.org>; Fri, 06 Sep 2013 04:35:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=Ruws2pgPprEnvLqaoMzS9FgwiA3wZ+kuF5kcYvWuCcs=; b=GlUxHKJRg0pSMZ2CZ30GgW17umjKPfO2kI5OBWMMVHUMBA7AkG86+naM2WFZr8MTow eUPoDbHheaBbUUdhTC8xB+B0tqn50U+h0DDbafDW1MYH5Turjvplgv2v5x9KlKNcingR uA9PKc0mRgrj3mI1dk/Dcra9wKWZWP4J6t+Bd60q/mehaWDU2qML3p9+KTvlwybufJVH /VI8RnC8Gu964OlbT5n+YbY/185T70sWY1SlKvWOA4EyeoJmEw6RRETRhz37qExCKBIk djKNbPoMlY0KNQlLv6I0v9bkkLe15VV3/jTD0uQopQCRnuM5YgzyNwdlRj3oKJgt0mEP 7JMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=Ruws2pgPprEnvLqaoMzS9FgwiA3wZ+kuF5kcYvWuCcs=; b=l93xpzMFlSU0YZLGVcZ37OrRlMGcKPxAd0RAjwHXqelOnqMG3KjsaB12blkpDxO3PW 5/Xf9E/nem4i4z7B3XAefsO3Kz/c5/Ar4Xsr8azIJYA19bCM+oI0d+H4SXfIC4foXKk6 Oj3w+kkjNpik4LgDZQG03I23c/zjRdXnH9ofx2Mxa4uTBA0+HTaz1IPdKR/vym0v0GHo VS+SLk00f4vK+bAzBQ4on62Aq2Fz+y/4Y0QISq5CIWfMdF1pczG4xUDJTSd7OPWC8GgK 0NhadsMcKsdjSGxI13bwvlgoiU/gGhOntYdsUgW1f9JPTmxYySh3q25rUTRxKeyea6d1 NULQ==
X-Gm-Message-State: ALoCoQmty3NhEzfgR4w11f5P7gpXZ6ZRCzc2d6cGmKz2CRv73mlS/tFjMhf6V+OSqF/Uc42Wf54MJ7LApY3lJmXpPNvyJQdyKNn825T9Rm1sLr9Osdhch8vxTgwSrduuygkvPIhrIK57yHgrWBl14Psw/6vxah6+vtRkLGJlhSFJKikn/HHDMME4OJcmJKATu9uK/Pyg5+j+
X-Received: by 10.50.61.241 with SMTP id t17mr1442401igr.28.1378467340471; Fri, 06 Sep 2013 04:35:40 -0700 (PDT)
MIME-Version: 1.0
Sender: tlegrand@google.com
Received: by 10.64.26.165 with HTTP; Fri, 6 Sep 2013 04:35:19 -0700 (PDT)
In-Reply-To: <51FA7C61.3080704@xiph.org>
References: <20130712222833.13138.87216.idtracker@ietfa.amsl.com> <51E0BDE1.9020901@jmvalin.ca> <51FA7C61.3080704@xiph.org>
From: Tina le Grand <tina.legrand@webrtc.org>
Date: Fri, 6 Sep 2013 13:35:19 +0200
X-Google-Sender-Auth: doWiPbvv-08tRazXXlcgfhQtChU
Message-ID: <CAKsXFw5PVWWKm0i9J27OhGZPfE3pzVKAcT3xCiMdma=2fBzL9w@mail.gmail.com>
To: "Timothy B. Terriberry" <tterribe@xiph.org>
Content-Type: multipart/alternative; boundary=047d7bdca96829e63504e5b5707a
Cc: "codec@ietf.org" <codec@ietf.org>
Subject: Re: [codec] Fwd: New Version Notification for draft-valin-codec-opus-update-00.txt
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Sep 2013 11:35:41 -0000

I generally approve of this draft. I have a few comments.

   - Section 4, in the source code lines:

This might be a little picky, but I suggest to remove the following line
  len--;
and replace the new line, "len -= p==255 ? 254: p;" with
  len -= p==255 ? 255: p+1;
or should it even be:
  len -= p;
?

   - Section 5, page 4:  "The code can be fixed by applying the following
   changes to like 70" - "like" should be "line".
   - Section 6. Can you describe how to remove the 180-degree phase shift?

Thanks,
Tina le Grand.



On Thu, Aug 1, 2013 at 5:18 PM, Timothy B. Terriberry <tterribe@xiph.org>wrote;wrote:

> Jean-Marc Valin wrote:
>
>> See these proposed fixes to the Opus RFC. These are minor changes to the
>> normative part of the reference implementation.
>>
>
> With my chair hat on:
>
> Although JDR originally said we would handle updates to RFC 6716 through
> the normal errata process [1], after conferring with our ADs, we decided to
> do them via a new draft, so that there was no question about overriding
> working group consensus.
>
> To that end, we'd like to run a consensus call to add a milestone for
> doing these updates. It would be helpful to have reviews of this document
> before doing that call. I propose we allow a month (until Sep. 1) for such
> reviews, and then run the call.
>
>
> [1] https://datatracker.ietf.org/**documents/LIAISON/liaison-**
> 2012-09-21-codec-isoiec-jtc-**1sc-29wg-11-liaison-from-ietf-**
> codec-working-group-to-isoiec-**regarding-speech-and-audio-**
> coding-standardization-**attachment-1.pdf<https://datatracker.ietf.org/documents/LIAISON/liaison-2012-09-21-codec-isoiec-jtc-1sc-29wg-11-liaison-from-ietf-codec-working-group-to-isoiec-regarding-speech-and-audio-coding-standardization-attachment-1.pdf>
>
> ______________________________**_________________
> codec mailing list
> codec@ietf.org
> https://www.ietf.org/mailman/**listinfo/codec<https://www.ietf.org/mailman/listinfo/codec>
>