Re: [codec] Comments on draft-ietf-codec-ambisonics-01

Jan Skoglund <jks@google.com> Mon, 13 March 2017 17:46 UTC

Return-Path: <jks@google.com>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB45D129972 for <codec@ietfa.amsl.com>; Mon, 13 Mar 2017 10:46:30 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=google.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GPX7LOo3gYqx for <codec@ietfa.amsl.com>; Mon, 13 Mar 2017 10:46:29 -0700 (PDT)
Received: from mail-qk0-x229.google.com (mail-qk0-x229.google.com [IPv6:2607:f8b0:400d:c09::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D9259129969 for <codec@ietf.org>; Mon, 13 Mar 2017 10:46:28 -0700 (PDT)
Received: by mail-qk0-x229.google.com with SMTP id 1so228190389qkl.3 for <codec@ietf.org>; Mon, 13 Mar 2017 10:46:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=ofbwTzyuocE+tvmcnIx4+0/I5AYAKAooEmftJS8qNmw=; b=LtukjFG3UEUeequuMlM+0SbWelRFLNTLTVzJPZrmB5v0Cn3vi5/49wQNAA1x7UQRkS 3g58/XzIu6xo1VcYjffQ877QhNMqAyfDWhQmM8DMPFOf1FAZRQejX2YJEHa0HozL/+yL x9xhQlwUUoyJMkZf3R8F5FYU33v/5spC05TajaD1sA/KTVzGdXgbvNGq7lZst+UNtVMW 6yWC3skujeSoIDFun8mkuQq+cQnHN0n8WG+EmNo5LiHip6Q30PKmEaisg3pwdlBXOWHD zUl2Shdq152p2jY/pX7QVKJ64A49AWXkV+lz3L6Aokq0ghEKIku9n6/LCq/qBG/KtgIz Us8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ofbwTzyuocE+tvmcnIx4+0/I5AYAKAooEmftJS8qNmw=; b=iF3sRPuQvxQ1tWjJvZKXh/BXhCb9hP5EFxjT3CqClvtWzGh+YK5PS+sXm8Uppk7uZw j8FScWumrbZNgemYof3olAd+ACehpX0VyrdSDqFppGZ3D3UBCp4yAfPjuylbuhshI3hb BqKWEbudZesJS4kTnAp4jXrfSwsTR8rgKpM/gMAGaT2GdsYJg/CO78imVoZRWnZWp9CD q9QFOwz4WRjfIhCqpHlFBBZAtEy/lYykneuuT0cilZlwp/usn8xtttgw4DhP2CbIshpi FPX4yZN5ws/T4TslkKY/sdzbDpf6MvYXm1KhQpjpYUqmXr2s82uEg3aOuiQoMOHTm4yU d+fA==
X-Gm-Message-State: AMke39mv2c91/EnTjmVmJEg9mFLJB79D2Nrgvxgwa/vUA3fDnBOLHatcMsSjlTB2YDTgwz4XO+fHfHvUQtFo8K6Y
X-Received: by 10.55.80.135 with SMTP id e129mr31188674qkb.192.1489427187800; Mon, 13 Mar 2017 10:46:27 -0700 (PDT)
MIME-Version: 1.0
References: <2f534e1b-b1af-266a-50ef-36f1739d878b@jmvalin.ca>
In-Reply-To: <2f534e1b-b1af-266a-50ef-36f1739d878b@jmvalin.ca>
From: Jan Skoglund <jks@google.com>
Date: Mon, 13 Mar 2017 17:46:17 +0000
Message-ID: <CA+KMCSWzW8adc0zsW=1y70o7dB55cYwRo4QZUW6_3S-kq9_JfQ@mail.gmail.com>
To: Jean-Marc Valin <jmvalin@jmvalin.ca>, "codec@ietf.org" <codec@ietf.org>
Content-Type: multipart/alternative; boundary="001a114a6b4e730b85054aa04aca"
Archived-At: <https://mailarchive.ietf.org/arch/msg/codec/ZSkyWeuHt4TFMaXjE9dBbm3W1zE>
Subject: Re: [codec] Comments on draft-ietf-codec-ambisonics-01
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/codec/>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Mar 2017 17:46:31 -0000

Hey Jean-Marc,

Thanks for your comments!

On Fri, Feb 17, 2017 at 1:57 PM Jean-Marc Valin <jmvalin@jmvalin.ca> wrote:

Hi Jan,

Here's some comments based on my review of the ambisonics draft:

3.  Ambisonics With Ogg Opus

>    Ambisonics MAY be encapsulated in the Ogg format by encoding with the

I would suggest replacing the normative MAY by just "can"


Agree


3.1.  Channel Mapping Family 2

>    This channel mapping uses the same channel mapping table format used
>    by channel mapping families 1 and 255.

I would suggest saying "mapping family 1" rather than "mapping families
1 and 255" since otherwise, you have families 2 referencing itself.
Also, we don't know what families 4 and up will look like.


Agree


3.2.  Channel Mapping Family 3

I would suggest removing the "Output Channel Numbering" field because it
is fully equivalent to simply permuting lines of the matrix.


Allowing mixed orders means that there's no unique configuration for a
given total number of channels.
Therefore we need to signal to the decoder which ACN numbers each output
channel corresponds to.



About the matrix -- and as previously discussed privately -- I think it
should probably be stored as 16-bit integers in Q15 format. If any
global scaling is ever required, then the "output gain" field can always
be used.


Sure, this will work.



>    Note that [RFC7845] specifies that the identification header cannot
>    exceed one "page", which is 65,025 octets.  This sets a practical
>    maximum ambisonic order of 10, if full order is utilized and the
>    number of coded streams is the same as the ambisonic order plus the
>    two non-diegetic channels.

This text is unclear about whether partial order 11 is allowed. I have
no strong opinion on the subject, but think it should be clarified.


OK, I don't think we need to to specify a maximum allowed, just point out
the headroom's practical aspect


Cheers,

        Jean-Marc


Cheers,
Jan