[codec] [PATCH] Remove a _overlap_mem only used for -DRESYNTH builds in celt.c.

Gregory Maxwell <gmaxwell@juniper.net> Fri, 29 July 2011 16:44 UTC

Return-Path: <gmaxwell@juniper.net>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BAE3C21F8B02 for <codec@ietfa.amsl.com>; Fri, 29 Jul 2011 09:44:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.299
X-Spam-Level:
X-Spam-Status: No, score=-6.299 tagged_above=-999 required=5 tests=[AWL=-0.300, BAYES_00=-2.599, J_CHICKENPOX_73=0.6, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8f6mU6o+DMXZ for <codec@ietfa.amsl.com>; Fri, 29 Jul 2011 09:44:03 -0700 (PDT)
Received: from exprod7og126.obsmtp.com (exprod7og126.obsmtp.com [64.18.2.206]) by ietfa.amsl.com (Postfix) with ESMTP id 6731D21F8AFD for <codec@ietf.org>; Fri, 29 Jul 2011 09:44:03 -0700 (PDT)
Received: from P-EMHUB01-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob126.postini.com ([64.18.6.12]) with SMTP ID DSNKTjLjUitfvwyvRLNGJnVtEkr7m9fxvpqN@postini.com; Fri, 29 Jul 2011 09:44:03 PDT
Received: from EMBX01-HQ.jnpr.net ([fe80::c821:7c81:f21f:8bc7]) by P-EMHUB01-HQ.jnpr.net ([fe80::fc92:eb1:759:2c72%11]) with mapi; Fri, 29 Jul 2011 09:41:19 -0700
From: Gregory Maxwell <gmaxwell@juniper.net>
To: "codec@ietf.org" <codec@ietf.org>
Date: Fri, 29 Jul 2011 09:41:19 -0700
Thread-Topic: [PATCH] Remove a _overlap_mem only used for -DRESYNTH builds in celt.c.
Thread-Index: AQHMTg5XxUM9UL6EYU260KX0SGiOQw==
Message-ID: <BCB3F026FAC4C145A4A3330806FEFDA93CE669821D@EMBX01-HQ.jnpr.net>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: [codec] [PATCH] Remove a _overlap_mem only used for -DRESYNTH builds in celt.c.
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 29 Jul 2011 16:44:07 -0000

https://people.xiph.org/~greg/0001-Remove-a-_overlap_mem-only-used-for-DRESYNTH-builds-.patch

>From 911c2e17dba1f48b8ac8dc52cb918c52b1d779f8 Mon Sep 17 00:00:00 2001
From: Gregory Maxwell <greg@xiph.org>
Date: Fri, 29 Jul 2011 11:53:45 -0400
Subject: [PATCH] Remove a _overlap_mem only used for -DRESYNTH builds in
 celt.c.

---
 libcelt/celt.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/libcelt/celt.c b/libcelt/celt.c
index 7419e17..c9b8b8b 100644
--- a/libcelt/celt.c
+++ b/libcelt/celt.c
@@ -921,7 +921,6 @@ int celt_encode_with_ec_float(CELTEncoder * restrict st, const celt_sig * pcm, i
    VARDECL(int, fine_priority);
    VARDECL(int, tf_res);
    VARDECL(unsigned char, collapse_masks);
-   celt_sig *_overlap_mem;
    celt_sig *prefilter_mem;
    celt_word16 *oldBandE, *oldLogE, *oldLogE2;
    int shortBlocks=0;
@@ -968,8 +967,6 @@ int celt_encode_with_ec_float(CELTEncoder * restrict st, const celt_sig * pcm, i
    N = M*st->mode->shortMdctSize;
 
    prefilter_mem = st->in_mem+CC*(st->overlap);
-   _overlap_mem = prefilter_mem+CC*COMBFILTER_MAXPERIOD;
-   /*_overlap_mem = st->in_mem+C*(st->overlap);*/
    oldBandE = (celt_word16*)(st->in_mem+CC*(2*st->overlap+COMBFILTER_MAXPERIOD));
    oldLogE = oldBandE + CC*st->mode->nbEBands;
    oldLogE2 = oldLogE + CC*st->mode->nbEBands;
@@ -1605,9 +1602,9 @@ int celt_encode_with_ec_float(CELTEncoder * restrict st, const celt_sig * pcm, i
       if (CC==2)
          out_mem[1] = st->syn_mem[1]+MAX_PERIOD;
 
-      c=0; do
-         overlap_mem[c] = _overlap_mem + c*st->overlap;
-      while (++c<CC);
+      overlap_mem[0] = prefilter_mem+CC*COMBFILTER_MAXPERIOD;
+      if (CC==2)
+         overlap_mem[1] = overlap_mem[0] + st->overlap;
 
       compute_inv_mdcts(st->mode, shortBlocks, freq, out_mem, overlap_mem, CC, LM);
 
-- 
1.7.4.4