Re: [codec] Eric Rescorla's No Objection on draft-ietf-codec-ambisonics-07: (with COMMENT)

Eric Rescorla <ekr@rtfm.com> Fri, 10 August 2018 19:34 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D1AE2130F81 for <codec@ietfa.amsl.com>; Fri, 10 Aug 2018 12:34:44 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.909
X-Spam-Level:
X-Spam-Status: No, score=-1.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, T_DKIMWL_WL_MED=-0.01] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=rtfm-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hpyu748vJ-rA for <codec@ietfa.amsl.com>; Fri, 10 Aug 2018 12:34:43 -0700 (PDT)
Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3774F130F6D for <codec@ietf.org>; Fri, 10 Aug 2018 12:34:42 -0700 (PDT)
Received: by mail-lf1-x129.google.com with SMTP id f18-v6so7353927lfc.2 for <codec@ietf.org>; Fri, 10 Aug 2018 12:34:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rtfm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=k+ZWOfoBWb+stPBp2hseIMXQ/5b3yUUHNqajg6zFv7E=; b=hJnzvuIpnjkp6kW/Y+FEbbKw1qg687QgRNnpKnemiUATPTm8xYjhD+7KlAQRZ6ZB7z SvpBwLftP0tS4xhOTLrAvQeTtSxXG3IpuMAFtkCDiGw5QHI1mOmWeABMBD7cv0H9se+k wh1rWvytmOt/2QbwweQGmDweO3K9VuhGyUVWtb3oTxEjrloTVbEF1BiBIjV2+7Ynr/Rl lD7io6XDtKiBfQQ1YvogVnGtiy4RP5g6EjiFLg+16G8lIjKUjSIuUlfYz2eSjFzTRYFu jSzbXQhOar45xWWPf4CkDi4DmHUMm5XGm0WMXW4AqPR/utJNq3d3RlYwL/zuWr7TImC4 HsUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=k+ZWOfoBWb+stPBp2hseIMXQ/5b3yUUHNqajg6zFv7E=; b=aAwZnXPjJm0ldRtRYUwK8bHcOb9WOUGVRsVcsfqKOePNhZClWFTZelE5xSSYqv0cTn ahVe1yu4pRRgXBi+X7c4+yKMh2DJgfQaa9iYe5aBQ+wmbLhl/mTa96a5SxXAXsaQp1FS N0bv5+idQi0Paqb//Ro+NTPh+00xbuYVE4hAB7ukDvGFcX8Jz9fTw36tjjveaA3fsDly SlYpwl1HJRnDb1j3hcGl0jvdFdGYQkJ4uwSUFwrhdi5bBR3Xn/l4qeP0O8bdkxt3RNY1 fY7dr42aDdn72xJhhEpkxbpaPILZBu29J3h/3my1UHp7Cu5B4QW3zLuHJaq+/e9haFor gD8Q==
X-Gm-Message-State: AOUpUlGFcw5cUuWNTxKD0ZdH9rQy7POqbs8gAiCT8SOfAsFV7Jk/UNN/ /YnV/CNSi9RW+BH62aMTXvCM9S8SE6e4L1TigwREsg==
X-Google-Smtp-Source: AA+uWPzFa92Wi4dn41AyI/mxGBxOpNcq/+bxecj/K8T4sXm2q18w6B4pzp7YCPHE5PxpTFcWnd4vlVpzil1fLO6FnkI=
X-Received: by 2002:a19:c3c7:: with SMTP id t190-v6mr2356526lff.108.1533929680443; Fri, 10 Aug 2018 12:34:40 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ab3:4091:0:0:0:0:0 with HTTP; Fri, 10 Aug 2018 12:33:59 -0700 (PDT)
In-Reply-To: <CA+KMCSWg366hoC+kit+NCLDU33YR7UBY-mv0Xyh9oXUNsM55eA@mail.gmail.com>
References: <153295358610.1069.2720875646830940452.idtracker@ietfa.amsl.com> <CA+KMCSWg366hoC+kit+NCLDU33YR7UBY-mv0Xyh9oXUNsM55eA@mail.gmail.com>
From: Eric Rescorla <ekr@rtfm.com>
Date: Fri, 10 Aug 2018 12:33:59 -0700
Message-ID: <CABcZeBN_59DtVZz7K8x7Q4D_2RMeG15-sxeMAc6neR=HCHE9mw@mail.gmail.com>
To: Jan Skoglund <jks@google.com>
Cc: The IESG <iesg@ietf.org>, draft-ietf-codec-ambisonics@ietf.org, Tim Terriberry <tterriberry@mozilla.com>, codec@ietf.org, codec-chairs@ietf.org
Content-Type: multipart/alternative; boundary="000000000000b6b156057319d5c2"
Archived-At: <https://mailarchive.ietf.org/arch/msg/codec/vPZdulWmXXe5C2b7iCtlohomANo>
Subject: Re: [codec] Eric Rescorla's No Objection on draft-ietf-codec-ambisonics-07: (with COMMENT)
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/codec/>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Aug 2018 19:34:45 -0000

On Mon, Aug 6, 2018 at 10:33 AM, Jan Skoglund <jks@google.com> wrote:

> Thanks for the comments! Our responses are inline below. A new version of
> the doc has been uploaded.
>
> Cheers,
> Jan
>
>
>> S 3.2.
>> >                                                        | Stream Count  |
>> >        +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-
>> +-+-+
>> >        | Coupled Count | Demixing Matrix                               :
>> >        +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-
>> +-+-+
>> >
>> >          Figure 4: Channel Mapping Table for Channel Mapping Family 3
>>
>> Are you saying I MUST use family 3?
>>
>>
> No, we say that if you use family 3 you MUST provide a matrix in the
> channel mapping table.
>
>
>> S 5.2.
>> >         The remaining channel mapping families (2...254) are reserved.
>> A
>> >         demuxer implementation encountering a 'channel mapping family'
>> >         value that it does not recognize SHOULD NOT attempt to decode
>> the
>> >         packets and SHOULD NOT use any information except for the first
>> 19
>> >         octets of the ID header packet (Fig. 2) and the comment header
>> >         (Fig. 10).
>>
>> What is the rationale for this change? Also, why are you doing it in
>> this document? This seems like it's going to be extremely hard for
>> implementors to find in future.
>>
>
> These paragraphs are updates to RFC 7845, which needed to be revised to
> accommodate the proposed channel mapping families in this draft.
>

Sorry, I don't understand. Why did they need to be revised to have this
change?


The authors of RFC 7845 and RFC 6716 suggested that the necessary updates
> to RFC 7845 should be included in this draft.
>

I understand, but my point is that people are likely to ignore this draft
if they don't care about ambisonics and thereby miss out on a relevant
information. In any case, I'll defer to the WG and AD.


S 5.1.
>> >      Figure 6: Stereo Downmixing Matrix for Channel Mapping Family 2
>> and 3
>> >             - Ambisonic Channels Plus a Non-diegetic Stereo Stream
>> >
>> >   5.  Updates to RFC 7845
>> >
>> >   5.1.  Format of the Channel Mapping Table
>>
>> What are the interop implications of this? I.e., is a file formatted
>> according to this document at all playable with an existing Ogg
>> decoder? If not, perhaps say so
>>
>
> This is the reason the changes below to 7845 are necessary. I.e., not
> interpreting as channel mapping family 255, and instead “A
> demuxer implementation encountering a 'channel mapping family'
> value that it does not recognize SHOULD NOT attempt to decode the
> packets“
>

Sorry, I'm not following. Is your point that previously it would have
misdecoded it and now it will just refuse to play? That's a reasonable
design choice, but it seems like it was always present in this design, so
why does it need to change?

I think that, depending on implementation, an old decoder would interpret a
> Q15 value as an index and either, most likely, decide the value to be
> invalid and not decode, or, if the index is lower-valued, decode the
> streams according to the old rule
> “If 'index' is less than 2*M, the output MUST be taken from
> decoding stream ('index'/2) as stereo and selecting the left
> channel if 'index' is even, and the right channel if 'index' is
> odd. If 'index' is 2*M or larger, but less than 255, the output
> MUST be taken from decoding stream ('index' - M) as mono. If
> 'index' is 255, the corresponding output channel MUST contain
> pure silence”
>
> So, it would either decode and play an unintended mixing, or not produce
> audio at all.
>

All right.

-Ekr


>
>
>