[codec] Eric Rescorla's No Objection on draft-ietf-codec-ambisonics-07: (with COMMENT)

Eric Rescorla <ekr@rtfm.com> Mon, 30 July 2018 12:26 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: codec@ietf.org
Delivered-To: codec@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A69313108C; Mon, 30 Jul 2018 05:26:26 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Eric Rescorla <ekr@rtfm.com>
To: "The IESG" <iesg@ietf.org>
Cc: tterriberry@mozilla.com, draft-ietf-codec-ambisonics@ietf.org, Tim Terriberry <tterriberry@mozilla.com>, codec@ietf.org, codec-chairs@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.83.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <153295358610.1069.2720875646830940452.idtracker@ietfa.amsl.com>
Date: Mon, 30 Jul 2018 05:26:26 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/codec/vS5YBJAanl1Ct0jkKgW5dRzrIGg>
Subject: [codec] Eric Rescorla's No Objection on draft-ietf-codec-ambisonics-07: (with COMMENT)
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/codec/>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jul 2018 12:26:26 -0000

Eric Rescorla has entered the following ballot position for
draft-ietf-codec-ambisonics-07: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)


Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.


The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-codec-ambisonics/



----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

Rich version of this review at:
https://mozphab-ietf.devsvcdev.mozaws.net/D3213



IMPORTANT
S 3.2.
>                                                        | Stream Count  |
>        +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>        | Coupled Count | Demixing Matrix                               :
>        +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
>   
>          Figure 4: Channel Mapping Table for Channel Mapping Family 3

Are you saying I MUST use family 3?


S 5.2.
>         The remaining channel mapping families (2...254) are reserved.  A
>         demuxer implementation encountering a 'channel mapping family'
>         value that it does not recognize SHOULD NOT attempt to decode the
>         packets and SHOULD NOT use any information except for the first 19
>         octets of the ID header packet (Fig. 2) and the comment header
>         (Fig. 10).

What is the rationale for this change? Also, why are you doing it in
this document? This seems like it's going to be extremely hard for
implementors to find in future.

COMMENTS
S 3.2.
>      whether or not there is a separate non-diegetic stereo stream.  This
>      corresponds to periphonic ambisonics from zeroth to fourteenth order
>      plus potentially two channels of non-diegetic stereo.  Explicitly the
>      allowed number of channels are 1, 3, 4, 6, 9, 11, 16, 18, 25, 27, 36,
>      38, 49, 51, 64, 66, 81, 83, 100, 102, 121, 123, 144, 146, 169, 171,
>      196, 198, 225, and 227.

This seems like the same graf as in 3.1, so perhaps merge these?


S 3.2.
>   
>                 Figure 3: Demixing in Channel Mapping Family 3
>   
>      The matrix MUST be provided as side information and MUST be stored in
>      the channel mapping table part of the identification header, c.f.
>      section 5.1.1 in [RFC7845].  The matrix replaces the need for a

I don't think you want "c.f." here, b/c "cf." means "compare". I
suspect you just want "see". Also, there's no period between c and f.


S 5.1.
>      Figure 6: Stereo Downmixing Matrix for Channel Mapping Family 2 and 3
>             - Ambisonic Channels Plus a Non-diegetic Stereo Stream
>   
>   5.  Updates to RFC 7845
>   
>   5.1.  Format of the Channel Mapping Table

What are the interop implications of this? I.e., is a file formatted
according to this document at all playable with an existing Ogg
decoder? If not, perhaps say so