Re: [codec] draft-ietf-codec-opus-07: Compiler warning

Ralph Giles <giles@thaumas.net> Mon, 25 July 2011 20:04 UTC

Return-Path: <giles@thaumas.net>
X-Original-To: codec@ietfa.amsl.com
Delivered-To: codec@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B458521F8BA7 for <codec@ietfa.amsl.com>; Mon, 25 Jul 2011 13:04:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.118
X-Spam-Level:
X-Spam-Status: No, score=-1.118 tagged_above=-999 required=5 tests=[BAYES_20=-0.74, FM_FORGED_GMAIL=0.622, RCVD_IN_DNSWL_LOW=-1]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u7U1uNYYxNqD for <codec@ietfa.amsl.com>; Mon, 25 Jul 2011 13:04:18 -0700 (PDT)
Received: from mail-vw0-f44.google.com (mail-vw0-f44.google.com [209.85.212.44]) by ietfa.amsl.com (Postfix) with ESMTP id 7FC5721F8B9D for <codec@ietf.org>; Mon, 25 Jul 2011 13:04:18 -0700 (PDT)
Received: by vws12 with SMTP id 12so4043516vws.31 for <codec@ietf.org>; Mon, 25 Jul 2011 13:04:18 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.220.203.10 with SMTP id fg10mr1283808vcb.93.1311624257853; Mon, 25 Jul 2011 13:04:17 -0700 (PDT)
Received: by 10.220.184.6 with HTTP; Mon, 25 Jul 2011 13:04:17 -0700 (PDT)
X-Originating-IP: [66.119.183.150]
In-Reply-To: <000901cc4aba$3ee92120$bcbb6360$@uni-tuebingen.de>
References: <000901cc4aba$3ee92120$bcbb6360$@uni-tuebingen.de>
Date: Mon, 25 Jul 2011 13:04:17 -0700
Message-ID: <CAEW_RkuDXuhC1aHwxOhJuY7bt9A-srsYEJTemuKagqWfLrFZGA@mail.gmail.com>
From: Ralph Giles <giles@thaumas.net>
To: Christian Hoene <hoene@uni-tuebingen.de>
Content-Type: text/plain; charset=UTF-8
Cc: codec@ietf.org
Subject: Re: [codec] draft-ietf-codec-opus-07: Compiler warning
X-BeenThere: codec@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Codec WG <codec.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codec>, <mailto:codec-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/codec>
List-Post: <mailto:codec@ietf.org>
List-Help: <mailto:codec-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codec>, <mailto:codec-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 25 Jul 2011 20:04:19 -0000

On 25 July 2011 04:01, Christian Hoene <hoene@uni-tuebingen.de> wrote:

> Attached you find a patch to remove some compiler warnings. I was using the
> latest Ubuntu.
> The HAVE_LRINTF" is nowhere defined because configure.sh is missing.

I think a better fix would be to just add HAVE_LRINTF to the options
at the top of the makefile. Depending on GNUC assumes gcc is in C99
mode.

MS_predictorIx is indeed an unused variable.

The unused warning against lost in test_opus.c is incorrect, but
initializing it to zero looks safe to me.

 -r