Re: [codesprints] Codesprint branches available

Robert Sparks <rjsparks@nostrum.com> Thu, 23 July 2020 13:40 UTC

Return-Path: <rjsparks@nostrum.com>
X-Original-To: codesprints@ietfa.amsl.com
Delivered-To: codesprints@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4BD743A0B5E for <codesprints@ietfa.amsl.com>; Thu, 23 Jul 2020 06:40:43 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.08
X-Spam-Level:
X-Spam-Status: No, score=-2.08 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, T_SPF_HELO_PERMERROR=0.01, T_SPF_PERMERROR=0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=nostrum.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R406LCRE-wha for <codesprints@ietfa.amsl.com>; Thu, 23 Jul 2020 06:40:41 -0700 (PDT)
Received: from nostrum.com (raven-v6.nostrum.com [IPv6:2001:470:d:1130::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DCCC53A0B5D for <codesprints@ietf.org>; Thu, 23 Jul 2020 06:40:41 -0700 (PDT)
Received: from unescapeable.local ([47.186.30.41]) (authenticated bits=0) by nostrum.com (8.15.2/8.15.2) with ESMTPSA id 06NDed53047190 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 23 Jul 2020 08:40:40 -0500 (CDT) (envelope-from rjsparks@nostrum.com)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nostrum.com; s=default; t=1595511641; bh=JAXpdz35rSXoDf7DDMh75XT8FymSfvc6omL0xRmFqKc=; h=Subject:To:References:From:Date:In-Reply-To; b=FQ2gOOrntpNga8SLqZZkEilurBdjcxDiwpjaC0pREQTVA5v/BA65CQgJdVvIo8kmq qtOzUMQ9e+BKGnFkudFpBZ2LQqjChZ+HT8XeWDL7p4SWgaX9zUU5m6hPH6M55fDhwp 6E5Sb83l9R59FitP434R1kI0eJtDU1w/sLZfdMGs=
X-Authentication-Warning: raven.nostrum.com: Host [47.186.30.41] claimed to be unescapeable.local
To: Henrik Levkowetz <henrik@levkowetz.com>, codesprints@ietf.org
References: <a10eb54d-043a-7a80-f01e-27fbeb064f1a@nostrum.com> <aff655d4-459d-73cf-ef3a-58f5378cbf14@nostrum.com> <fdb51f17-56eb-d019-a436-220a2ce5db11@levkowetz.com>
From: Robert Sparks <rjsparks@nostrum.com>
Message-ID: <c7526b18-e573-0964-ee96-3dc489da4cfe@nostrum.com>
Date: Thu, 23 Jul 2020 08:40:39 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <fdb51f17-56eb-d019-a436-220a2ce5db11@levkowetz.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Archived-At: <https://mailarchive.ietf.org/arch/msg/codesprints/ah2SoY4dwxfps1tCf8vsnjCi3D0>
Subject: Re: [codesprints] Codesprint branches available
X-BeenThere: codesprints@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for coordinating \(and following up on\) codesprint activities" <codesprints.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codesprints>, <mailto:codesprints-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/codesprints/>
List-Post: <mailto:codesprints@ietf.org>
List-Help: <mailto:codesprints-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codesprints>, <mailto:codesprints-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2020 13:40:43 -0000

On 7/23/20 7:50 AM, Henrik Levkowetz wrote:
> Hi Robert,
>
> On 2020-07-23 01:25, Robert Sparks wrote:
>> I had to make this change to settings.py to get most of the tests to pass:
>>
>> (env) unescapeable:7.10.1.dev0 rjsparks$ svn diff
>> Index: ietf/settings.py
>> ===================================================================
>> --- ietf/settings.py    (revision 18238)
>> +++ ietf/settings.py    (working copy)
>> @@ -333,7 +333,7 @@
>>
>>    X_FRAME_OPTIONS = 'ALLOW-FROM ietf.org *.ietf.org meetecho.com
>> *.meetecho.com gather.town *.gather.town'
>>    CSRF_TRUSTED_ORIGINS = ['ietf.org', '*.ietf.org', 'meetecho.com',
>> '*.meetecho.com', 'gather.town', '*.gather.town', ]
>> -CSRF_COOKIE_SAMESITE = 'None'
>> +CSRF_COOKIE_SAMESITE = 'none'
>>    CSRF_COOKIE_SECURE = True
> Huh.  I _think_ you'll find that if you change it back to 'None' it will
> still work now.  Being able to set 'None' (which the latest browser
> releases require, as None (the value, not the string) now is interpreted
> as 'Lax') depends on a patch which may not have been applied if the very
> first thing you did was to run tests.
Running the tests was the very first thing I did. I haven't done 
anything else. When did it apply the patch?
>   Both the previous code, which
> recognised 'lax' and 'strict', and the patched code, lowercases the string
> before checking it.
>
>>    # SESSION_COOKIE_AGE = 60 * 60 * 24 * 7 * 2 # Age of cookie, in
>> seconds: 2 weeks (django default)
>>
>> I also have one test that fails because I don't have yanglint installed.
>> I think this was supposed to skip.
> Ahh.  Sorry, slipped my mind.  Mea culpa.
>
>
> 	Henrik
>
>> RjS
>>
>> On 7/22/20 5:20 PM, Robert Sparks wrote:
>>> If you signed up for the 108 codesprint, you should have received mail
>>> with a branch for you based on 7.10.0.dev0.
>>>
>>> If you are planning to attend, but didn't sign up, add yourself to
>>> https://trac.tools.ietf.org/tools/ietfdb/wiki/IETF108SprintSignUp and
>>> send a note to Henrik.
>>>
>>> See you this Saturday!
>>>
>>> RjS
>>>
>>> _______________________________________________
>>> codesprints mailing list
>>> codesprints@ietf.org
>>> https://www.ietf.org/mailman/listinfo/codesprints
>> _______________________________________________
>> codesprints mailing list
>> codesprints@ietf.org
>> https://www.ietf.org/mailman/listinfo/codesprints
>>