IETF Logo Mail Archive

Re: [codesprints] Codesprint branches available

Henrik Levkowetz <henrik@levkowetz.com> Thu, 23 July 2020 12:50 UTC

Return-Path: <henrik@levkowetz.com>
X-Original-To: codesprints@ietfa.amsl.com
Delivered-To: codesprints@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D37BB3A0A03 for <codesprints@ietfa.amsl.com>; Thu, 23 Jul 2020 05:50:16 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N1wYMwJluBeJ for <codesprints@ietfa.amsl.com>; Thu, 23 Jul 2020 05:50:15 -0700 (PDT)
Received: from zinfandel.tools.ietf.org (zinfandel.tools.ietf.org [64.170.98.42]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90CBE3A0A02 for <codesprints@ietf.org>; Thu, 23 Jul 2020 05:50:15 -0700 (PDT)
Received: from h-202-242.a357.priv.bahnhof.se ([158.174.202.242]:57670 helo=tannat.localdomain) by zinfandel.tools.ietf.org with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from <henrik@levkowetz.com>) id 1jyafu-0004Ak-RA; Thu, 23 Jul 2020 05:50:15 -0700
To: Robert Sparks <rjsparks@nostrum.com>, codesprints@ietf.org
References: <a10eb54d-043a-7a80-f01e-27fbeb064f1a@nostrum.com> <aff655d4-459d-73cf-ef3a-58f5378cbf14@nostrum.com>
From: Henrik Levkowetz <henrik@levkowetz.com>
Message-ID: <fdb51f17-56eb-d019-a436-220a2ce5db11@levkowetz.com>
Date: Thu, 23 Jul 2020 14:50:07 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <aff655d4-459d-73cf-ef3a-58f5378cbf14@nostrum.com>
Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="kIGaGjAUlRlcMdNr1IAXpfMMCDQJohlld"
X-SA-Exim-Connect-IP: 158.174.202.242
X-SA-Exim-Rcpt-To: codesprints@ietf.org, rjsparks@nostrum.com
X-SA-Exim-Mail-From: henrik@levkowetz.com
X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-SA-Exim-Scanned: Yes (on zinfandel.tools.ietf.org)
X-Clacks-Overhead: GNU Terry Pratchett
Archived-At: <https://mailarchive.ietf.org/arch/msg/codesprints/kNVt4-fQTIHjplMdcEOeiVAfyk8>
Subject: Re: [codesprints] Codesprint branches available
X-BeenThere: codesprints@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for coordinating \(and following up on\) codesprint activities" <codesprints.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/codesprints>, <mailto:codesprints-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/codesprints/>
List-Post: <mailto:codesprints@ietf.org>
List-Help: <mailto:codesprints-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/codesprints>, <mailto:codesprints-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Jul 2020 12:50:17 -0000

Hi Robert,

On 2020-07-23 01:25, Robert Sparks wrote:
> I had to make this change to settings.py to get most of the tests to pass:
> 
> (env) unescapeable:7.10.1.dev0 rjsparks$ svn diff
> Index: ietf/settings.py
> ===================================================================
> --- ietf/settings.py    (revision 18238)
> +++ ietf/settings.py    (working copy)
> @@ -333,7 +333,7 @@
> 
>   X_FRAME_OPTIONS = 'ALLOW-FROM ietf.org *.ietf.org meetecho.com 
> *.meetecho.com gather.town *.gather.town'
>   CSRF_TRUSTED_ORIGINS = ['ietf.org', '*.ietf.org', 'meetecho.com', 
> '*.meetecho.com', 'gather.town', '*.gather.town', ]
> -CSRF_COOKIE_SAMESITE = 'None'
> +CSRF_COOKIE_SAMESITE = 'none'
>   CSRF_COOKIE_SECURE = True

Huh.  I _think_ you'll find that if you change it back to 'None' it will
still work now.  Being able to set 'None' (which the latest browser
releases require, as None (the value, not the string) now is interpreted
as 'Lax') depends on a patch which may not have been applied if the very
first thing you did was to run tests.  Both the previous code, which
recognised 'lax' and 'strict', and the patched code, lowercases the string
before checking it.

> 
>   # SESSION_COOKIE_AGE = 60 * 60 * 24 * 7 * 2 # Age of cookie, in 
> seconds: 2 weeks (django default)
> 
> I also have one test that fails because I don't have yanglint installed. 
> I think this was supposed to skip.

Ahh.  Sorry, slipped my mind.  Mea culpa.


	Henrik

> 
> RjS
> 
> On 7/22/20 5:20 PM, Robert Sparks wrote:
>> If you signed up for the 108 codesprint, you should have received mail 
>> with a branch for you based on 7.10.0.dev0.
>>
>> If you are planning to attend, but didn't sign up, add yourself to 
>> https://trac.tools.ietf.org/tools/ietfdb/wiki/IETF108SprintSignUp and 
>> send a note to Henrik.
>>
>> See you this Saturday!
>>
>> RjS
>>
>> _______________________________________________
>> codesprints mailing list
>> codesprints@ietf.org
>> https://www.ietf.org/mailman/listinfo/codesprints
> 
> _______________________________________________
> codesprints mailing list
> codesprints@ietf.org
> https://www.ietf.org/mailman/listinfo/codesprints
>

v2.23.0 | Report a Bug | By Email