[core] implementer feedback on CORE-SID: Re: [mbj4668/pyang] Sid sx structure (PR #839)

Michael Richardson <mcr+ietf@sandelman.ca> Sun, 19 March 2023 13:33 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 38A75C14CF12 for <core@ietfa.amsl.com>; Sun, 19 Mar 2023 06:33:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TXMdoCSVc2Vv for <core@ietfa.amsl.com>; Sun, 19 Mar 2023 06:33:53 -0700 (PDT)
Received: from relay.sandelman.ca (relay.cooperix.net [IPv6:2a01:7e00:e000:2bb::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B9B60C14CE30 for <core@ietf.org>; Sun, 19 Mar 2023 06:33:53 -0700 (PDT)
Received: from dyas.sandelman.ca (unknown [77.241.232.28]) by relay.sandelman.ca (Postfix) with ESMTPS id 9200C1F479 for <core@ietf.org>; Sun, 19 Mar 2023 13:33:50 +0000 (UTC)
Received: by dyas.sandelman.ca (Postfix, from userid 1000) id 04A85A1A70; Sun, 19 Mar 2023 09:33:49 -0400 (EDT)
Received: from dyas (localhost [127.0.0.1]) by dyas.sandelman.ca (Postfix) with ESMTP id 021DDA1A60 for <core@ietf.org>; Sun, 19 Mar 2023 14:33:49 +0100 (CET)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: core@ietf.org
In-reply-to: <mbj4668/pyang/pull/839/c1474951745@github.com>
References: <mbj4668/pyang/pull/839@github.com> <mbj4668/pyang/pull/839/c1474951745@github.com>
Comments: In-reply-to jernejt <notifications@github.com> message dated "Sat, 18 Mar 2023 11:41:45 -0700."
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 26.3
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Date: Sun, 19 Mar 2023 14:33:48 +0100
Message-ID: <2897262.1679232828@dyas>
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/36Z1UX7ZCGxIemKqSql2sjShcQQ>
Subject: [core] implementer feedback on CORE-SID: Re: [mbj4668/pyang] Sid sx structure (PR #839)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Mar 2023 13:33:58 -0000

jernejt <notifications@github.com> wrote:
    > Managed to get individual tests in "test/test_sid" working by invoking
    > `make testX PYANG=pyang`, where X is the number of the test.

    > Yeah, I may have broken rt:yang-data (test5). I'm not sure whether only
    > the container within it is supposed to get a SID assigned, or both the
    > container and the enveloping rt:yang-data "node" (this is the main
    > difference compared to sx:structure). core-sid-20 should probably say
    > something about this, but doesn't.

Clearly, the document needs a sentence somewhere then

    > Since the new proposal is to "assign
    > a SID to everything" including stuff that does not currently get to be
    > instantiated in instance documents, rt:yang-data node should probably
    > be included in the mapping.

Note that sid-item-status branch has a test-5 and a test-5sx.

test-5 is constrained-voucher (augment/yang-data ersion), and definitely
everything that has a sid allocated there should probably still have one.
There are one or two things which were superfluous to the ANIMA WG's needs,
but we did not worry about it.

--
Michael Richardson <mcr+IETF@sandelman.ca>, Sandelman Software Works
 -= IPv6 IoT consulting =-                      *I*LIKE*TRAINS*