Re: [core] Yangdoctors last call review of draft-ietf-core-yang-cbor-15

"Joe Clarke (jclarke)" <jclarke@cisco.com> Mon, 14 June 2021 16:28 UTC

Return-Path: <jclarke@cisco.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 407D23A29D4; Mon, 14 Jun 2021 09:28:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.596
X-Spam-Level:
X-Spam-Status: No, score=-9.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001, USER_IN_DEF_DKIM_WL=-7.5] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cisco.com header.b=lJllYHDF; dkim=pass (1024-bit key) header.d=cisco.onmicrosoft.com header.b=xdZEZ2RK
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5GnMe5JRP9E9; Mon, 14 Jun 2021 09:28:24 -0700 (PDT)
Received: from rcdn-iport-8.cisco.com (rcdn-iport-8.cisco.com [173.37.86.79]) (using TLSv1.2 with cipher DHE-RSA-SEED-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 409983A2A12; Mon, 14 Jun 2021 09:28:24 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2834; q=dns/txt; s=iport; t=1623688104; x=1624897704; h=from:to:cc:subject:date:message-id:references: content-transfer-encoding:mime-version; bh=kVHb01ZYcUYGMi51sMznxaQrzAYWGTBpo3fWQz8Ts7Y=; b=lJllYHDFGVIwKgoaLG/PKZoVMc9mjkJvy0ALhFzR/Yn9uo1pqA4FXbml LtKM5rN7oy4zqUBr8Zu5RSXD6YTUdz5Vy1T9G7o33GF70+bLqH8EoOkyr P7rRB4NrrHkPk0QhK5usmIBPfAB8E01PrqHNNeclLH/BlHR/4Koulu4o+ w=;
IronPort-PHdr: A9a23:/ykYNxPinivuPiyRVaIl6ncdWUAX0o4cdiYc4ZkjzbNJIeyv/JXnaUrY4/glzFrERp7S5P8Mje3K+7vhVmoN7dfk0jgCfZVAWgVDhZAQmAotU8eOCkm9Lfm5JyA/Fd5JAVli+XzzOENJGcH4MlvVpHD67TMbFhjlcwRvIeGgEY/JhMPx3Oe3qPXu
IronPort-HdrOrdr: A9a23:nPzPCqp/fA+Q65fnp47F3FwaV5utL9V00zEX/kB9WHVpm5Oj9vxGzc506farslkssSkb6Ky90KnpewK6yXcH2/hvAV7EZnimhILIFvAt0WKG+V3d8kLFh5VgPMtbAs1D4b7LfBhHZKTBkXOF+r8bqbHtms3F9ISurUuFDzsaFp2IhD0JbDpzZ3cGPDWucqBJbaZ0iPA3wwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWna4j4uFxd0hZsy+2nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlWFtyssHfsWG1SYczEgNkHmpDo1L/sqqiUn/4UBbU215oWRBDsnfKi4Xi67N9k0Q6d9bbRuwqTnSW+fkNhNyKE7rgpLicwLCEbzYxBOetwrhKknosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfVsRKEkjQto+a07bWnHAUEcYZ5TJdCZ4OwTfUKRbnjfsGUqyNuwXm4rFhPDRkQZoMSa3zVfgXg8liIjtYAit2ZF8Ih4R4hP5uzCPKgtnLZSTtUOZaY4AOsaW8O4BmHEXBqJOmOPJlbsEr0BJhv22tPKCXUOlaiXkbkzvdQPcbj6ISZlXF8JCjTT4Je1re92Gzj2MRGAtBrWu7Jj26Q=
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A0DNAACwgsdg/5xdJa1QCh0BAQEBCQESAQUFAUCBRAcBCwGBUlEHd1o3MQuIBQOFOYh8A5oYgS4UgREDVAsBAQENAQEwDwIEAQGBGIM4AoJpAiU1CA4CBAEBARIBAQUBAQECAQYEcROFaA2GRQEBAQMBEigGAQE3AQ8CAQgYHhAyJQIEDg0aglCCVQMOIQEOnVgBgToCih94gTSBAYIHAQEGBASFKxiCMQmBOgGCeoJxU4crJxyBSUSBFUOCYD6CYgIBAQEXgRkTGgKDS4IMIoMYBmgvIgEBe2M0lGCmWgmBDAqDHIoPlAASg16LIJZml2qJf5MfhHoCAgICBAUCDgEBBoFWAjeBWXAVO4JpCUcXAg6OHwwWg06CZIIwhUpzAgEBNAIGCgEBAwl8h10BgRABAQ
X-IronPort-AV: E=Sophos;i="5.83,273,1616457600"; d="scan'208";a="902119425"
Received: from rcdn-core-5.cisco.com ([173.37.93.156]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 14 Jun 2021 16:28:22 +0000
Received: from mail.cisco.com (xbe-rcd-003.cisco.com [173.37.102.18]) by rcdn-core-5.cisco.com (8.15.2/8.15.2) with ESMTPS id 15EGSMSI024203 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 14 Jun 2021 16:28:22 GMT
Received: from xhs-rtp-002.cisco.com (64.101.210.229) by xbe-rcd-003.cisco.com (173.37.102.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 14 Jun 2021 11:28:22 -0500
Received: from xhs-rtp-001.cisco.com (64.101.210.228) by xhs-rtp-002.cisco.com (64.101.210.229) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 14 Jun 2021 12:28:21 -0400
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (64.101.32.56) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1497.18 via Frontend Transport; Mon, 14 Jun 2021 12:28:21 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfPmc3l0gMWKUmfJe+/sNMy9P6to+s9T7mBhea39viKoyAJ3vxEeQ1dGkx1aJuo6bTgaEYEemNGSgPb0tlcutaTLOnn9TwTWWXljXvtTAYNQ1254QfvZ+bddK9j+i/rr4a34tFZUNhaFA/TlmQQ+4xcA6XP3raKvQbppgt2E8HBzT+KFrywJrqCa/FAD6/kjzCGrVX4jtnJjIYC17ds+Kt8NEfASXnShBCzAQkS4OOFktHifkmBDKtjkb3/7KlMMQZGAs3zzu7WgUTnRm+pQ7vhvFaDqPH1z2rzRzmmLUCwY5BSKgP0mzezfosRNF7wuxxz/KWuXAqDOosL2iijDBQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V7LYk1YcIPXGEQyMBnNMCPl9+YJmLst8vxqP+drE1fw=; b=IWuevnleW0Km1ANJlvXqLlBXqE9gMUZng/GgQZEIR8nM73B93UQ4tjH9wP4iWopTuy+E9ZL6TSJr8hRWYhh9ioVqf6luJQQSvwBsHc0J1SkEpXFxow+K8B3MDLDsXbk/ece3UL75vIlqD3O6bodhtJuC8XcHpFfVbrKQGGcEf94AiRm3H67ZekQVwSGA5GliVvx5+D+RRUNb9xI4fkmuYBNGRyDt+v9MyKTqgV1g4+H+F/0m8LJVVxMzsdAuwjF4N9QunRuDqfuiPqIl+gwaNfV8O+mw5wqab9Q2vQd5zBxtjrRmQssVaz4jz83CX4W45leNngwqfUXbJWj/fJctyQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V7LYk1YcIPXGEQyMBnNMCPl9+YJmLst8vxqP+drE1fw=; b=xdZEZ2RKNCsMF8wyy1T7CCxWnhEWLQbSTBvhmzS2/pN10xbcCb1tMhJfORvUa2hJa9g5gSfUuUig5FnB1l9wswzPdw1HBi0PYErHU/F1HX8e3cFWdSQKW+N6oBVhzGL27O2uePZeXlekNyrWWt9cHM9v5XzpRyCqwUDngOvj/fQ=
Received: from BL3PR11MB5681.namprd11.prod.outlook.com (2603:10b6:208:33c::10) by MN2PR11MB4461.namprd11.prod.outlook.com (2603:10b6:208:192::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Mon, 14 Jun 2021 16:28:20 +0000
Received: from BL3PR11MB5681.namprd11.prod.outlook.com ([fe80::2099:b812:527e:8cee]) by BL3PR11MB5681.namprd11.prod.outlook.com ([fe80::2099:b812:527e:8cee%4]) with mapi id 15.20.4219.025; Mon, 14 Jun 2021 16:28:20 +0000
From: "Joe Clarke (jclarke)" <jclarke@cisco.com>
To: Ivaylo Petrov <ivaylo@ackl.io>
CC: "yang-doctors@ietf.org" <yang-doctors@ietf.org>, "draft-ietf-core-yang-cbor.all@ietf.org" <draft-ietf-core-yang-cbor.all@ietf.org>, Last Call <last-call@ietf.org>, core <core@ietf.org>, "ivaylopetrov@google.com" <ivaylopetrov@google.com>
Thread-Topic: [core] Yangdoctors last call review of draft-ietf-core-yang-cbor-15
Thread-Index: AQHXYRMbcEoV7cO2t0maBKvPSxqzRg==
Date: Mon, 14 Jun 2021 16:28:20 +0000
Message-ID: <BL3PR11MB5681B8CDDCB99551C0C47F16B8319@BL3PR11MB5681.namprd11.prod.outlook.com>
References: <161592338136.13562.2421108714318351834@ietfa.amsl.com> <CAJFkdRx9D8EcDLty02a60BxLcMF9n9WkcNBXDTDczdFnUULQFA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ackl.io; dkim=none (message not signed) header.d=none;ackl.io; dmarc=none action=none header.from=cisco.com;
x-originating-ip: [173.38.117.69]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: d1f65b86-b3bd-45cc-e700-08d92f516c31
x-ms-traffictypediagnostic: MN2PR11MB4461:
x-microsoft-antispam-prvs: <MN2PR11MB44616738F264B13454C6B741B8319@MN2PR11MB4461.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: jz8tYmMOebvE2CE/lZExmnYsa76hwYU3L/oMuOZzaz0ZurgRxQysBO0LeinIeeCXRRPbZYK/hYPHjHEaNkOhya5+HzCUf2uQ6KTHcf7uns518uqdx75dVb29rWSB8nC/fJ26uz7qQRAeKz8KzrJEChxlg+LlWEshOhzNxunQZ3IEHxiGnbyQtujwKlovGSBLenqi3r40v6ZsNZXesAHaXvUqAG5F+8nodgliLjzNOtVV9cmGg3vCgD8sD++5gVT9DkSwBRU6P6otcJCrqDSpEXNH+toybNXCe4OZizV9AUYIYwizmcMDvZgkE5TDYriszJNoihT7oLvFRos0t9c2tJHsqOz51uxrSSYxcuRUqd2wtCmzaN28ekgwkcc+JFXE2IFyzmga7SGvchlBZuOCdn0+8eObfINBQzNKxID1Bwf7vePrDKFV8wmEsjwDWO5On5cJshlGgoU1US0dSPJV+m9cU76E5qjKJwOlgWlmE4w+OVAavRAYCHXXmPu5YAIm17x167GrNqf7FozN7qLM0SvqW1Si/XgZfFQsuRIpufnfcSc8MM01gNXRrzgsuFLdmkPKH4uWO9DzlUIsaDLs+svqzP7BoVy45LxZr/8wrLxheY3OSiCTFRqc0jZiieXgdsPArPQV5nWFOPt/kZtXhUfEHPpUzMN3HQrkW/JlJV/orwjPyp+rhCme4xFpMB0Sp2EEX2ZF9dYK6tdR3pWFPw==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BL3PR11MB5681.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(39860400002)(346002)(376002)(136003)(966005)(8936002)(7696005)(8676002)(53546011)(6916009)(478600001)(6506007)(9686003)(4326008)(54906003)(5660300002)(55016002)(83380400001)(186003)(71200400001)(316002)(122000001)(86362001)(66446008)(64756008)(66556008)(66476007)(2906002)(38100700002)(52536014)(33656002)(66946007)(26005)(76116006)(91956017); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: PXNp7uQNkve4ANG1W1QNTWBpGMSdSygOzBQL5/YhAiXcdOWV5pzXAuoMmS6ybNxMPjTXkNXZsfitH+bNhs3eKfZMzUcTdad8hz+Qc5WHynORT3VCZhurU6eJVrWoKpxMrecKUYAbf/wpBdOXiQwU1P4QOkslN8aIlOfnB4wNSwnaCp8Ezb9ZigxWTvHifN0M+F2+k2eLvFT/1Qu3T6KMzXyiSeZZS9HIG+x4KT9AXvJiKcbKURNhfyI4O47U+BT1oN5C4hs8msepGHTK2X4Wapm9LL64u9wGfb6PxHp1RJbUUoA72jsTCqqlQuoCmqiZCPaJlLoBNy4sWZuqgXKms04gO029hE5HfcxN5+djtN2zqe42d08Jie8CyLXVieKPMIWZHSvzQxDjkS1yoCltaeONOligM3s56HCYKhalLQ3JLNk9hUwEC7PBXoykt1hD/qYujJPu/bAc4sATM4tChxnb/eIj5PQLIemZmQJ6jCNy1tBgXJ4KFi46qezqN9F14SKscDX5xp5v2xkQ3Xu7f1zNMB7g/oHv4kAqNlX+PgRzg+KzaCYZhNjkvLHhimatOVWeRwZ2wIA/gcXYkzk5UWBo/xIVPYPvdj1BOdckIpAOZ7rwIdINYu0TuU3yV34W4rhw43P6Xh/8GPsIL/kCMh+Mom0jJnun44i7uC2Y6HXQ5NzCpvjPRH6bt5OKUBwXBcAUDmJOkGhx0MrA1hlgNF2YZvtdbnPqp9ZeB0wOW3/pdnSmp+LfBLfhFgNLkv5Ja4ZtYNmKLz2bihj4+wLRlV+GmJ1tXCDhyzc5zUjzJ8LDqL3p6gWfl9Q29r9evzpDvMY/ph7lgkJEL1NtGvRT6elfDFiLMbSfCcYd0WKB+jsIvezVGnao9JY7Jt5or+Px0syCf8hwknqfgALPNUXI9rwi15vpZ8Zs10B033sg96JauAj0r0Ko1j4x1D5C1ANCGnxY6mcRENhZkCebyJ71n785S/U1xiHU4YwUfCUpa8Jksru0J+12eOTYZNYgxUzJPhbtnzyrBojOp3eZ5auNd+cjjGzWnZu+ebt9wkPo4BMfkZmn/47X1S04tRJ6UQWhhkDb63nvWmDx5eP/QM0s4iA3GG+XrNNidPRAH8LOc+wNigZAg4JhxAmmX825DPMnYFz5ZXB3tcgDn0O8qxXFQFDwV4IKKrEr4lDi6b0HRfq0CMQ4mtLRRubYuJxsMahiY0GcXoFyLYtq2XHdH/BqhKg6OayKW2ezYZK9pIthGZjOOFhrpyJKEgzY4ESgl2SLgkRwtVpMh21dNSI6WwRbVTOA6evT0zwQMntl+w+EGH/EmU+dik0aBYhdaUp7QiZW
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB5681.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d1f65b86-b3bd-45cc-e700-08d92f516c31
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2021 16:28:20.2308 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bSBqcIelW5XAhAdzQb8an3L+s/QLfin/TNxOgBNBk/w2wqNykHgXay+Uy2BkS4Bf22a5qalQkDUwTljX2qAqIw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4461
X-OriginatorOrg: cisco.com
X-Outbound-SMTP-Client: 173.37.102.18, xbe-rcd-003.cisco.com
X-Outbound-Node: rcdn-core-5.cisco.com
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/6wqlTZ2bY4Cb13o4rG7Y0uJahlg>
Subject: Re: [core] Yangdoctors last call review of draft-ietf-core-yang-cbor-15
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Jun 2021 16:28:29 -0000

On 6/14/21 07:47, Ivaylo Petrov wrote:
> Hello Joe,
>
> Thank you for your review and apologies for the delay! Please find our
> answers to your questions below. The diff with -15 is available here
> [1]. The updated version is available as txt [2] and as html [3].
>
> Thanks,
> Ivaylo
>
> [1]: https://tools.ietf.org/rfcdiff?url1=draft-ietf-core-yang-cbor&url2=http://core-wg.github.io/yang-cbor/draft-ietf-core-yang-cbor-latest.txt
> [2]: https://core-wg.github.io/yang-cbor/draft-ietf-core-yang-cbor-latest.txt
> [3]:  https://core-wg.github.io/yang-cbor/draft-ietf-core-yang-cbor-latest.html

Thanks, Ivaylo.  I'll look through the diffs, but it sounds like you
addressed all of my comments.

>> Section 4.4.1
>>
>> I think documenting the true/false value of the primitives here (noted in the
>> CBOR encoding) would aid in clarity.  For example, "primitive(20) [false]".
> [IP]: I am not against that, I am only concerned if that would be
> readable for others that are used to the diagnostic notation,
> otherwise I am fine to apply this change.

Sounds like Carsten addressed this in a follow-up.  I think his response
is reasonable whereby manual effort is removed in favor of an update
toolchain.

>
>> ===
>>
>> Section 4.5.1
>>
>> I'm being pedantic here, but ahead of the { 60123 : { ... example, you usually
>> state "CBOR diagnostic output".  You don't here, though.  I think you should
>> add it.
> [IP]: I might be misunderstanding the point, but it appears to me that
> there is such a note already, only it unfortunately appeared at the
> top of the previous page in the txt version and was quite easy to
> miss.

Yep.  Sorry.  Those darn page breaks...

>> ===
>>
>> Section 6.13.1
>>
>> It isn't clear to me how a YANG list with multiple keys or a YANG list with no
>> keys would be encoded in CBOR.  I think examples and some clarifying text would
>> help.
> [IP]: I have modified one of the examples so that it uses two keys. As
> for the other point, Is it possible to have a list with no keys being
> referenced through an instance-identifier? My understanding is that
> this is not possible, but I might be wrong. If it is not possible, we
> will only need to clarify this in the text. If it is possible, can we
> use the position in the list to identify the element?

I'm referring to something like the last example in Section 9.13.4 of
RFC 7950 for an i-i for a list entry without keys.  In this case, a
numeric identifier is used.

Joe