Re: [core] [CoRE] Working Group Last Call (WGLC) of draft-ietf-core-target-attr-01

Carsten Bormann <cabo@tzi.org> Tue, 28 February 2023 16:19 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 00559C14F737 for <core@ietfa.amsl.com>; Tue, 28 Feb 2023 08:19:02 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gfAW7jASkKYH for <core@ietfa.amsl.com>; Tue, 28 Feb 2023 08:18:56 -0800 (PST)
Received: from smtp.zfn.uni-bremen.de (smtp.zfn.uni-bremen.de [134.102.50.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 50FC6C14CF17 for <core@ietf.org>; Tue, 28 Feb 2023 08:18:54 -0800 (PST)
Received: from [192.168.217.124] (p548dc9a4.dip0.t-ipconnect.de [84.141.201.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4PR2cC08SLzDCcb; Tue, 28 Feb 2023 17:18:50 +0100 (CET)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <8b57e9f6-83ad-50ef-b46c-9b945025fb0c@ri.se>
Date: Tue, 28 Feb 2023 17:18:50 +0100
Cc: core@ietf.org
X-Mao-Original-Outgoing-Id: 699293930.5936249-ff2a1caa8ce076df3dbd0bde302b3125
Content-Transfer-Encoding: quoted-printable
Message-Id: <A6A053D9-E559-44F2-BC4B-29DC63899E97@tzi.org>
References: <a1d15c56-c447-ac5a-6c6c-40a1780f748c@ri.se> <8b57e9f6-83ad-50ef-b46c-9b945025fb0c@ri.se>
To: Marco Tiloca <marco.tiloca=40ri.se@dmarc.ietf.org>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/BRmzUx5wlsKqVxI0J_p3aeYJ1kA>
Subject: Re: [core] [CoRE] Working Group Last Call (WGLC) of draft-ietf-core-target-attr-01
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Feb 2023 16:19:02 -0000

Hi Marco,

thank you for this review.

On 2023-02-23, at 00:29, Marco Tiloca <marco.tiloca=40ri.se@dmarc.ietf.org> wrote:
> […]
> [General]
> 
> * Consistently with Section 2, shouldn't the document title be "CoRE Target Attributes Registry"?

The registries do this pluralization consistently, but my brain thinks I’m going to a Car Dealer or a Book Store and not to a Cars Dealer or Books Store :-)
Fixed.

> * I think that some occurrences of "Target Attributes" should instead be "target attributes". That is:
> 
>    - Two occurrences in the Abstract.
>    - One occurrence in Section 1, second paragraph.

Bad habit of mine.  Fixed.

> [Abstract]
> 
> * Since Resource Discovery is specifically mentioned, a more precise reference is to Section 7.2 of RFC 7252, since its Section 7 comprises also Service Discovery.

Good point!  (Intro, too.)

> [Section 1.0]
> 
> * s/Section 3 of [RFC5988]/(Section 3 of [RFC5988])

Fixed.

> * The last paragraph intended for registrants can be followed by something like below, consistently with the text of Section 2.1 instead intended for the Designated Expert.
> 
>    "Very short target attribute names are intended to be allocated for applications that are likely to enjoy wide use and can make good use of their shortness. Registrants are encouraged to take it into account when defining target attribute names."

Hmm, this is kind of inverting the sense of the current last paragraph.
If you encourage people to do something, and then load them down right away with some restrictions, that is diluting the message…
So I think I really want this point focused on Section 2.

> [Section 2.0]
> 
> * s/a new sub-registry for Target Attributes/a new Target Attributes sub-registry for

Fixed.

> * s/policy "expert review"/policy "Expert Review"

When I thought I had my bad habit under control once…  Fixed.

All changes are in https://github.com/core-wg/core-target-attr/pull/11, which you approved before I could even finish this message!

Grüße, Carsten