Re: [core] 🔔 WG Last Call of draft-ietf-core-senml-etch-03.txt

Ari Keränen <ari.keranen@ericsson.com> Wed, 26 June 2019 18:47 UTC

Return-Path: <ari.keranen@ericsson.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id ACE35120619 for <core@ietfa.amsl.com>; Wed, 26 Jun 2019 11:47:07 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gY1yQRPJN0SB for <core@ietfa.amsl.com>; Wed, 26 Jun 2019 11:47:05 -0700 (PDT)
Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70047.outbound.protection.outlook.com [40.107.7.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4D9E812008B for <core@ietf.org>; Wed, 26 Jun 2019 11:47:04 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QZLmpfxsGdJl225Ps6kHX4rJ4oxw0YElgWcDDxCdcug=; b=kbHJZaVEUUrfYwUtFUU/BOb8R20x2H5uBccNld8PfvSqV9Blkfw186m0MonYMQTJyZHsUhvP5f550DvCWd3/Z54Aas+aFIgjyJ+RsdHYTNbnKRSNkMTUDNlERUEJjZ+Rx3NXaD0vOgzK4onMMXAU5RlYsEl0mcKoyCtvB+NGpbw=
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com (20.176.166.145) by HE1PR07MB4249.eurprd07.prod.outlook.com (20.176.166.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.13; Wed, 26 Jun 2019 18:47:00 +0000
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b5b8:de53:7372:dd2a]) by HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b5b8:de53:7372:dd2a%7]) with mapi id 15.20.2032.012; Wed, 26 Jun 2019 18:47:00 +0000
From: =?utf-8?B?QXJpIEtlcsOkbmVu?= <ari.keranen@ericsson.com>
To: Klaus Hartke <hartke@projectcool.de>, core <core@ietf.org>
Thread-Topic: =?utf-8?B?W2NvcmVdICDwn5SUIFdHIExhc3QgQ2FsbCBvZiBkcmFmdC1pZXRmLWNvcmUt?= =?utf-8?Q?senml-etch-03.txt?=
Thread-Index: AQHVISBQHJvty1Er7US6KumrZJ3bDKaqu7GAgANdFACAAEQIAA==
Date: Wed, 26 Jun 2019 18:47:00 +0000
Message-ID: <8112FF8E-1081-4766-9CD9-FDC38D55FB6B@ericsson.com>
References: <9AD3C4BB-7965-4776-84C4-6B5BFDCAA262@tzi.org> <e3a61d2c-1183-5ece-74d8-b1bad26ddfe6@ericsson.com> <3E80442D-9EBF-4973-89E1-7B4A69F42754@tzi.org> <E8AD8AB7-DF40-4049-901E-18C0655A3DAD@tzi.org> <CAAzbHvbT6Dyjh+33Mnb74wk1oh8iSWo-hUPq1hpBwgWyPe15Bg@mail.gmail.com> <DFA743C7-B7BB-4C49-A953-46289CA6C837@ericsson.com>
In-Reply-To: <DFA743C7-B7BB-4C49-A953-46289CA6C837@ericsson.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ari.keranen@ericsson.com;
x-originating-ip: [2001:14bb:150:480b:8074:a92a:790c:2490]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: f0ca617e-b92c-4e69-a990-08d6fa66ac7b
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(49563074)(7193020); SRVR:HE1PR07MB4249;
x-ms-traffictypediagnostic: HE1PR07MB4249:
x-microsoft-antispam-prvs: <HE1PR07MB42497AFEF225195CA71A47C685E20@HE1PR07MB4249.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 00808B16F3
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(39860400002)(136003)(366004)(346002)(396003)(199004)(189003)(256004)(7736002)(6436002)(68736007)(81166006)(486006)(66476007)(73956011)(46003)(6246003)(66946007)(66616009)(66556008)(76116006)(64756008)(66446008)(102836004)(186003)(76176011)(81156014)(25786009)(85182001)(86362001)(6506007)(478600001)(6512007)(6306002)(99286004)(54896002)(99936001)(316002)(229853002)(71200400001)(110136005)(36756003)(5660300002)(8936002)(2616005)(11346002)(476003)(6116002)(446003)(6486002)(966005)(606006)(53936002)(2906002)(33656002)(14454004)(236005)(85202003)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB4249; H:HE1PR07MB4236.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: kLxUSdlNTfprke1ZpTOZvp0ksfSrTGGv+plhJxe97+69jMR35IOw0X4r/0CeG3wiYj3S/7broNGwBI8CwZlytCMJvGyZ3PlS75szUBbNNmy7jOoUi2JbJIdJStWAuJS6jW4Pn+SH435rXAmt3ITIu0V2JcqME8N10ux1hgcCG6sVGz6/DzWnuZA0U7srZzcmBeaMhOgYw/AE4slAEaeIZ6T/wGm/FuooiFfes9P39b9uVxHezmNp/FpMyhHvX2AwVHBHJATvEJg3qI0SdcTNBpHR9AcgObBED1SvlkQPCpxD4W+9kdpyAc4s0aAWnXusuyPbu4jivvl30+fCnT1itnYFRM+XXlKseC6AftDOn7XZoNWEzXuP63fZ1Zm3harooD9ulnhx5wmPCYD9bolCXG9USn8hhkNMonlnkvI/y60=
Content-Type: multipart/signed; boundary=Apple-Mail-4D8D0D5B-1C3F-42BE-8C5C-1C42168C7903; protocol="application/pkcs7-signature"; micalg=sha-256
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f0ca617e-b92c-4e69-a990-08d6fa66ac7b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jun 2019 18:47:00.5588 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ari.keranen@ericsson.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB4249
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/CMQ8xC-aUgG2oULkkUTzexcsw_k>
Subject: Re: [core] =?utf-8?q?=F0=9F=94=94_WG_Last_Call_of_draft-ietf-core-se?= =?utf-8?q?nml-etch-03=2Etxt?=
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jun 2019 18:47:08 -0000

Hi,

Here’s now a PR that addresses all these comments:
https://github.com/core-wg/senml-etch/pull/5/files

Michael R also pointed out a bug in the references, that revealed also a bug in the examples. This PR fixes both issues: https://github.com/core-wg/senml-etch/pull/6/files


Cheers,
Ari

> On 26 Jun 2019, at 17.44, Ari Keränen <ari.keranen@ericsson.com> wrote:
> 
> Thanks Klaus! See inline.
> 
>> On 24 Jun 2019, at 14.22, Klaus Hartke <hartke@projectcool.de> wrote:
>> 
>> I have performed a quick review of draft-ietf-core-senml-etch-03:
>> 
>> 3.2. "For example, the following document could be given as (i)PATCH
>> payload to change/set values of two SenML Records for the example in
>> Section 1:" -- It would be nice if the example from section 1 was
>> duplicated here and the removal of a record was shown.
> 
> Makes sense, will add example to the next revision.
> 
>> 5.1 "All IDs are assigned from the "IETF Review or IESG Approval"
>> range." -- Remove this sentence.
> 
> SenML RFC (and others) have used such sentence to indicate the desired range, but I’m fine leaving it out too.
> 
>> 5.1 "Table 1: CoAP Content-Format IDs" -- This table is missing the
>> "Content-Coding" (f.k.a. "Encoding") column.
> 
> Good catch; will add. I suppose it will be simply ”-” for both.
> 
>> General questions:
>> 
>> * It seems the new data formats are supersets of the existing data
>> formats. Also, it seems the same data format is used for fetching and
>> patching data. Is this what we, as CoRE WG, recommend (1 media type
>> for data, 1 media type for fetching and patching)? CoRAL is doing it
>> differently at the moment [1].
>> 
>> [1] https://tools.ietf.org/html/draft-hartke-t2trg-coral-08#section-6.7
> 
> Christian made some good observations on this already. I would not view this as a general guideline either. But let’s continue on that thread (and in the call today).
> 
> 
> Cheers,
> Ari
> _______________________________________________
> core mailing list
> core@ietf.org
> https://www.ietf.org/mailman/listinfo/core