[core] Review of draft-ietf-core-sid-15

Francesca Palombini <francesca.palombini@ericsson.com> Wed, 24 February 2021 12:40 UTC

Return-Path: <francesca.palombini@ericsson.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EB52D3A14FE; Wed, 24 Feb 2021 04:40:08 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.671
X-Spam-Level:
X-Spam-Status: No, score=-2.671 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.57, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6taukmkTfdl8; Wed, 24 Feb 2021 04:40:07 -0800 (PST)
Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2069.outbound.protection.outlook.com [40.107.21.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A514C3A1516; Wed, 24 Feb 2021 04:40:06 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jtCqWIv4FNYrS2VpUn499a0tPmbPgOqezNYUI7vadikKPiXUi5piqEyDtheY1LNPiq6uHvzUlPyQ67yyyuW4FFHOSWIz+Xs46A8cNO7LiVCvr6dpeGf8K5ph5pcojjqUbS/DyeKvw+bxWTOxAX4VAVrCIrGRLPVMakyzpxlUi1gp8y3ModlmASOnbTLxFCSUW7IQGVR1Mt5pirN0eVE53kWS3Wtz5hc4guN5wPVJVa9xp/OQp2KxruYb8joKN5W8w2VSzfVBdTzEbxbG2TuN4UVTFj7k8xWX8UWIK/o/ZCt+qf8HkLuEFt+TWlso0W7jXFbZzr4A6wlX/+UmWSC6jw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNnFrnK0oU7lFhvME9LPSKH/ZPVOsIr6QeLzHeyibwI=; b=cHDOswKkghlWzXeKwWYF/JRnGEnZMRkAMUy8yBKO/Dcq+HvqG6M/Vroxs5BGm1Bmc1kYbxePPMd/UqJGZk60MfxaXR7rHM7pIjKUwQ84TelkBrKjmjQHCMQkYdk76L0gwNwbqW4BQF73uRmcdEaS8WgYGHIZnrR4tnE9Lbqt7h6rb2ske80Axvx9UuLASCIEdn+BPhRg2J1D5Gw4BVePy9UvnQcgNptNLcrmgjy1etW42dttYdWCc71J+a1w1ZNBqUBXn/urKwdKdFn30XnHWwoJG7wI5tBP/oUuZQtZvrlNJN07AlfCnEnP6F/PK6wLfjzQNN544mDweJIVujLrwg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JNnFrnK0oU7lFhvME9LPSKH/ZPVOsIr6QeLzHeyibwI=; b=Ob9kPXxaQczHhFlE5Wh0MLUlbhPaoT5n4C8VZlxvWUVqY+qf7cLFiEY/OHUYLorh3NhhzzU5NDb+DRvKmv2So+iGrEKGaNiA6MarVeN/0f0nv/RaWq1DbnlUypWZUGTYEUCWIAitPX5bBPmVmtUgXBcmuR3V0K2ASW4LCE4keGs=
Received: from VI1PR07MB4477.eurprd07.prod.outlook.com (2603:10a6:803:74::33) by VI1PR07MB6478.eurprd07.prod.outlook.com (2603:10a6:800:13c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.8; Wed, 24 Feb 2021 12:40:03 +0000
Received: from VI1PR07MB4477.eurprd07.prod.outlook.com ([fe80::c5e9:fb9a:e4a0:e7a4]) by VI1PR07MB4477.eurprd07.prod.outlook.com ([fe80::c5e9:fb9a:e4a0:e7a4%5]) with mapi id 15.20.3890.018; Wed, 24 Feb 2021 12:40:03 +0000
From: Francesca Palombini <francesca.palombini@ericsson.com>
To: "draft-ietf-core-sid@ietf.org" <draft-ietf-core-sid@ietf.org>
CC: "core@ietf.org" <core@ietf.org>, "core-chairs@ietf.org" <core-chairs@ietf.org>, "barryleiba@computer.org" <barryleiba@computer.org>
Thread-Topic: Review of draft-ietf-core-sid-15
Thread-Index: AQHXCqos5zhnUNLZ50aJmGO0QhI9xg==
Date: Wed, 24 Feb 2021 12:40:03 +0000
Message-ID: <B9D828F3-7844-48B7-98AE-D2DCB481F06E@ericsson.com>
Accept-Language: en-GB, en-US
Content-Language: en-GB
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Microsoft-MacOutlook/16.46.21021202
authentication-results: ietf.org; dkim=none (message not signed) header.d=none;ietf.org; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [2001:1ba8:147a:c100:2419:35d:8efa:cace]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 20505f50-fa7f-4fa2-8063-08d8d8c14ed0
x-ms-traffictypediagnostic: VI1PR07MB6478:
x-ms-exchange-minimumurldomainage: rfc-editor.org#8321
x-microsoft-antispam-prvs: <VI1PR07MB6478146BD5B85BCA88EF2D05989F9@VI1PR07MB6478.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: FRnz/tZMeOqKiy5dNZa50ALRcAYjG7sDeoFsSkYC8Rh7SzAR+6UH9ksYa76nYm9y2to333dyWsX8PfMYkKjG43ul3lxuwyNOudI/ZZFYUfLE2eXO60OoR0UtNHwlYhWbN59YoW6IOv7X3D6HPyHrJ3xnY8DPf/YBNLRkYMg2WI6HgjCsJ07nHgy1xNYcShPBGS9IF5TC7pcPHxi5lfIUwGLfN2AvOuPD317XiWRjNOkuxLdQ6Fpqz62NzaVDqpanXD4+x+egs46oaWm4hOYuK3HgtXyTRqH92eiy5BVsy4ixcHCsSzp9X5d2GyvQScy8QnkE1AlLmeJqhNuMcSLaSW7BkRX3Bcr31V6o00GLoeH35zXlTKFSoO8YUBen/QiQlbFODOp4vEBJPlhGTuzCt/3Am2MdqmeN/y9iABelBF68l2H2kZ3DupMaOyA5m3LzVMS0dnGBNT6/ufudGOVTAk8biS0srpqqU87Huz85258PQrKqz6MHL8MByJbzQaM+Kb7oYVYdZ9AjD4Ph/M+LtwsX1B4gxl2v7UZu9ZAaVd6vCtc5WHVc0aQ3yjw/3jAKoF6/D2OOk4J5GNIdX+dfOv7BBUWZBC8wSflJd9qGYthhUkHestHwtHfJkX6dg7x+gHhye8L91ypPcEtcAn/YTq5c1+C05Oh4XxAl3DH6f9E=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR07MB4477.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(316002)(2906002)(6506007)(6486002)(64756008)(66556008)(4326008)(66446008)(86362001)(6916009)(6512007)(54906003)(44832011)(5660300002)(8936002)(186003)(83380400001)(66476007)(966005)(71200400001)(8676002)(66946007)(478600001)(91956017)(2616005)(33656002)(36756003)(76116006)(45980500001); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: =?utf-8?B?dFQ1TUgwWE5ZV1c3WFF3VEhjakRuRjR4QllYd1RkaFJ5dGNRWndydWh3M21Y?= =?utf-8?B?QTBRRHpLc0VTeW9iSkNrMlJaYUFaaFBGUjRVdnBzWWdKQU5MN2ZWNU9xTW8w?= =?utf-8?B?b08vT2VoeFVUODAycE13RkZtLzFIZk9KaUdWbFg0Ly9pbVlCK2NveFA2SjhO?= =?utf-8?B?dkgwUUhVRTJybmlaRGFXWElTZlFGcnBXSnFsRzNQUWRkMnVlb1pkWjRUVnJU?= =?utf-8?B?WXFUSlFkZ0h6UitJcTZlV3lTdTBRRy9xT25SQWpNWGxmajFoT0pONVBLU3dk?= =?utf-8?B?eE5QeTVxMFY5aGNBRTRxT0lQVmFEeEdyNktOZ2RzL05YQ3Y0YXc1UEV4Wk9u?= =?utf-8?B?MVRwMm5DMnRjUGZqckZsZVNFLzBwSVFPUlZndlUrVzlTZzAxcXZnVm05OGNn?= =?utf-8?B?UWRzN0FVTytoR0FYRXMrM2pySSsyZmVPUlR1VGdZaXZLVTZBR0dOVU5pNCs5?= =?utf-8?B?TDdZZDNPSnUwN05NMm4zSkF6L0dGUVVTc2lEN1ZCVXdWOUpYNXlMYkxCM1lS?= =?utf-8?B?N0VOOWhRWW5UczQ5bm9POUc0eTRSZjZDdng0blhVYXFycjlqUk91UTNYd3M1?= =?utf-8?B?NVhOYUZ2SCs2NG1ySzEyY054dU1tZVo4V2tIaTZZRXVub0t1eFJ1MlBleGg3?= =?utf-8?B?ZWc4Q2w5aFI4MEFWUlM3K1JSaXVadnNjd0JWTmtncjNGUEFISENYcnhJZ3hp?= =?utf-8?B?bEh1NGtsa2FRWE5HQ3JxYWxsUWdyTHRuajMzVHlqZFkxQVNTVzZwMEVtd01n?= =?utf-8?B?U21tSCt1MlpTZ1MyQ2diRWtJWWZ1aGthaS9RaUV6VFFWUUZ5elBMRzRINy82?= =?utf-8?B?WXkrNnUxR2x2L1dxMmI1cXpLbGdwcFUxQ3JXQ3ByOThra1c2cDRNWmRockJr?= =?utf-8?B?b3VDcG1pV2xxVFpFSlkrMTB2bEdhU3EyNmtDemJRaVBPWDBZaGx3RFd2by9n?= =?utf-8?B?dzdOUU1HbkluQnpRUWNGVGFxL05FdGEzWmNHNkVmNVUyNnpZWlh4T0dFdHhm?= =?utf-8?B?cDVwSVF3M1BoZlBnUi8yeGpvVXlXZ2pSdW11ZUJvclUxY3MraHJBQjNvZVd1?= =?utf-8?B?T3hrWGxtbFAveVB4bUJNU0xucFY1c3NZclRHTVJMcDBCSXBIUkE1NTNjWUtr?= =?utf-8?B?TGFNVGtNS3ZQTTcxeGY5RTN3ek5EdlZhWklTZ1NtdHBLdDRkSWtuWDNTOUYr?= =?utf-8?B?SmNtenZydk5OZDUxMXN0bFJFeFFDTmdSYndxemFkaVlqT3k5dC9uQy9SdHds?= =?utf-8?B?UWFCekkydzNJdkN5d2NYdDdoUWpLZzB0SklBcnU5YnpWd1liL3JtOHV4WnNa?= =?utf-8?B?Vzd1Q3AxM3ZMNjk0dmR0cUdjQnFtOWdGZHFuOEdzOWZNWXhRSWR3VFc4NnNW?= =?utf-8?B?eFptM002eHVyd0Z4UlpETnVpK2dQM0dzNjhFM2YvWWFaSXdieEhRTmdhTEpC?= =?utf-8?B?UEpERmZqdy9EK1VzZUljL3dFb3ZVWk1UaXVmZVlBODNPVFlYazYvNHdBM2VR?= =?utf-8?B?OVVnY0ZrN3I0VWFHY29tcXZuRUJSRk1tTDR0VnB3cThYVnNXNXhLT2NrYW1T?= =?utf-8?B?cUo1VXBRem5NRTcza0tFaTYvKytXc2tUcnczaE9URENpZWpsUVJuOGM2VERo?= =?utf-8?B?QmtZeUJWcWN6UTFRS0tVeEQwa3hyamVhYlZnT0VGZEZVYXJabVhYa09tZHJ5?= =?utf-8?B?WTRjUlZ0R2lsSVArUmxNVElYYjc2bWpNN25NUjNsK2JWVFcwQjhkaXZJOU9x?= =?utf-8?B?WG5aWXJaRC92bm9rRlVLSkgyMWtpUkxzTXlEMjJRRFptT2VueWpyS1NIdC9s?= =?utf-8?B?MGhBTUxaQzBtM093S25FNm9Sbk81U0ZwZVc1VkEwZWFmdE9MSVhFdEx1eFBF?= =?utf-8?B?R28zQ2FTQXFyRXMyS2MwdlNDMzhtYzFVSEJWM3dvVzUzM0E9PQ==?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="utf-8"
Content-ID: <5009B620DC6981458A67501062AADE8C@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR07MB4477.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 20505f50-fa7f-4fa2-8063-08d8d8c14ed0
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Feb 2021 12:40:03.4310 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bgIgbwc+Jg7w+2vOHAuAQMHJX0zuQCs/PDyyncxbKSUAvzZz7klFpVQK9bDB/iTsP4UB5fhnqYSu0gqxaUaK9jJ1XAqsfqzWUFG6kmRFOlNP/CTtD9l2P7W/HojA0TJU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB6478
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/FtxuEEzjbqT0ajYmhS0uWwZta3A>
Subject: [core] Review of draft-ietf-core-sid-15
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Feb 2021 12:40:09 -0000

Thanks for the work on this document. I have reviewed it and have some comments. Please handle these comments together with the Last Call comments.

Chairs: I believe it would make sense to request a review from YANG Doctors for this document. Let me know if you need help setting that up.

Thanks,
Francesca

==

Section 1:

   SIDs are assigned permanently, items introduced by a new revision of
   a YANG module are added to the list of SIDs already assigned.  If the
   meaning of an item changes, for example as a result from a non-
   backward compatible update of the YANG module, a new SID should be
   assigned to it.

should or SHOULD? In general it is not clear to me when it makes sense for SID need to be re-registered and when they don't, maybe some examples would be useful.

==

Section 3:

   Each time a YANG module or one of its imported module(s) or included
   sub-module(s) is updated, a new ".sid" file MAY need to be created.

Maybe s/MAY need to/MAY. I assume this is application specific if the new .sid file is created or not, so you are leaving it somewhat optional, is that correct? Might be good to clarify.

==

Section 7: IANA is going to ask where to create the registries. Could this be under yang-parameters or does it need a new registry?

==

Section 7.4: Because the policy is expert review, I wonder if a change controller field should be added (see RFC 8126)

   When creating a new registry with Expert Review as the registration
   policy, in addition to the contact person field or reference, the
   registry should contain a field for change controller.  Having a
   change controller for each entry for these types of registrations
   makes authorization of future modifications more clear.

==

Section 7.5.3 Includes initial entries for the registry that are not consistent with the guideline: 

+  "Expert Review" [RFC8126] in case the ".sid" file comes from
            a YANG module from an existing RFC, or

since some of these points are registered from drafts. Should the WG do early allocation of those?

==

Nits

- expand acronyms on first use ( e.g. NETCONF, RPC, see https://www.rfc-editor.org/materials/abbrev.expansion.txt )