Re: [core] implementer feedback on CORE-SID: Re: [mbj4668/pyang] Sid sx structure (PR #839)

Michael Richardson <mcr+ietf@sandelman.ca> Thu, 23 March 2023 13:51 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2A1B0C1522CB for <core@ietfa.amsl.com>; Thu, 23 Mar 2023 06:51:26 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.097
X-Spam-Level:
X-Spam-Status: No, score=-7.097 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=sandelman.ca
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GkPhuQiMKpZ9 for <core@ietfa.amsl.com>; Thu, 23 Mar 2023 06:51:22 -0700 (PDT)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E7B4EC1522CD for <core@ietf.org>; Thu, 23 Mar 2023 06:51:21 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id A11AE38990; Thu, 23 Mar 2023 10:24:26 -0400 (EDT)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id xNNcBdXvF5RG; Thu, 23 Mar 2023 10:24:25 -0400 (EDT)
Received: from sandelman.ca (obiwan.sandelman.ca [209.87.249.21]) by tuna.sandelman.ca (Postfix) with ESMTP id 912293898E; Thu, 23 Mar 2023 10:24:25 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandelman.ca; s=mail; t=1679581465; bh=zZu9QpXIiiIb64gBbmstuNdusaeCZK5Sg2qQIj8Wl4c=; h=From:To:cc:Subject:In-Reply-To:References:Date:From; b=HRKJFoFLHwHlJf4QocgvLTpnprmijunJ8cDvvDvMqKvDr46oRdO9Fwz+/m3eU7UfL IXEGRdTpXyiEE0beaBeDnUs8ilVhN4GD/QjtghFzgjLfro/jHQiq1m4Qw3xOUrY4xV d8kCmk0hb/sGL1uyh4DakLfDExRJGBqiFozOE7QmmQH/6wSZx2JScD7BeUJMBPtO5G fo7tWUoEUdkDQMyRX7O6v53aLYd3vQ5Z6NIbrt51TE+fLLW5IzQbzxFvNvBqY/YsSH XveDtIVmCb5wVociCsVFV2VZ6mXBilmFFX1IgZujB+MkwEyMaWp9Gwo9ueam5adNuE VFp9jZXJV2rSQ==
Received: from localhost (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id 06B345DE; Thu, 23 Mar 2023 09:51:18 -0400 (EDT)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: Jernej Tuljak <jernej.tuljak@mg-soft.si>
cc: core@ietf.org
In-Reply-To: <ea2899eb-e02c-9ad0-2ead-c0a341410225@mg-soft.si>
References: <mbj4668/pyang/pull/839@github.com> <mbj4668/pyang/pull/839/c1474951745@github.com> <2897262.1679232828@dyas> <bed2e140-d5e3-2aba-c2e1-6c8066602660@mg-soft.si> <28078.1679313444@localhost> <ea2899eb-e02c-9ad0-2ead-c0a341410225@mg-soft.si>
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 27.1
X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0; <'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m<nPbLgmtKK-5dC@#:k
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Date: Thu, 23 Mar 2023 09:51:18 -0400
Message-ID: <4633.1679579478@localhost>
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/KY4c5Dd-ohRGMQOgb_2c9RNnC0M>
Subject: Re: [core] implementer feedback on CORE-SID: Re: [mbj4668/pyang] Sid sx structure (PR #839)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Mar 2023 13:51:26 -0000

Jernej Tuljak <jernej.tuljak@mg-soft.si> wrote:
    > On 20/03/2023 12:57, Michael Richardson wrote:
    >> Jernej Tuljak <jernej.tuljak@mg-soft.si> wrote:
    >> > The issue I stumbled upon is not the number of mappings, but how the actual
    >> > mapping for rc:yang_data is done after my changes compared to master.
    >>
    >> You have introduced a possible instability in assignments :-)
    >> I can live with that as a one-time hit if it makes the code better, but are
    >> you sure that your code is itself stable?  That might mean sorting keys of a
    >> dict before using them.

    > I'm not sure I understand what you meant. Were you referring to the change in
    > the order of assignments for schema nodes? Yes, those occur in "pyang

I'm asking if your new order of assignment would be stable even if the dict()
implementation was changed, or if it ran on a different architecture.

    > I did go through all the tests to make sure nothing's breaking other than in
    > expected ways, but the amount of cases those check is limited. That is also
    > the only measure of stability I can provide at this time. I pushed (to my
    > repo) the changes that would be required for test/test_sid yesterday.

Thank you for going through those tests.

--
]               Never tell me the odds!                 | ipv6 mesh networks [
]   Michael Richardson, Sandelman Software Works        |    IoT architect   [
]     mcr@sandelman.ca  http://www.sandelman.ca/        |   ruby on rails    [