[core] draft-ietf-core-links-json-01 review

"FOSSATI, Thomas (Thomas)" <thomas.fossati@alcatel-lucent.com> Tue, 11 March 2014 17:52 UTC

Return-Path: <thomas.fossati@alcatel-lucent.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C72981A0747 for <core@ietfa.amsl.com>; Tue, 11 Mar 2014 10:52:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.9
X-Spam-Level:
X-Spam-Status: No, score=-6.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Fqa8PBpmN5h9 for <core@ietfa.amsl.com>; Tue, 11 Mar 2014 10:52:14 -0700 (PDT)
Received: from hoemail2.alcatel.com (hoemail2.alcatel.com [192.160.6.149]) by ietfa.amsl.com (Postfix) with ESMTP id 57BD11A0736 for <core@ietf.org>; Tue, 11 Mar 2014 10:52:14 -0700 (PDT)
Received: from fr712usmtp2.zeu.alcatel-lucent.com (h135-239-2-42.lucent.com [135.239.2.42]) by hoemail2.alcatel.com (8.13.8/IER-o) with ESMTP id s2BHq6Ok004254 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 11 Mar 2014 12:52:07 -0500 (CDT)
Received: from FR712WXCHHUB03.zeu.alcatel-lucent.com (fr712wxchhub03.zeu.alcatel-lucent.com [135.239.2.74]) by fr712usmtp2.zeu.alcatel-lucent.com (GMO) with ESMTP id s2BHq5FV012636 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Tue, 11 Mar 2014 18:52:06 +0100
Received: from FR711WXCHMBA08.zeu.alcatel-lucent.com ([169.254.4.236]) by FR712WXCHHUB03.zeu.alcatel-lucent.com ([135.239.2.74]) with mapi id 14.02.0247.003; Tue, 11 Mar 2014 18:52:06 +0100
From: "FOSSATI, Thomas (Thomas)" <thomas.fossati@alcatel-lucent.com>
To: Carsten Bormann <cabo@tzi.org>
Thread-Topic: draft-ietf-core-links-json-01 review
Thread-Index: AQHPPVKd12SgOxUEOkmGDtwQGVY9wQ==
Date: Tue, 11 Mar 2014 17:52:05 +0000
Message-ID: <CF44FC44.138D7%thomas.fossati@alcatel-lucent.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [135.239.27.40]
Content-Type: text/plain; charset="utf-8"
Content-ID: <D1ADD49E761C60468E2A1493F4DFCC10@exchange.lucent.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: http://mailarchive.ietf.org/arch/msg/core/XnDxHFxq92Xw1m5lA_NLNSFqsZg
Cc: "core@ietf.org WG" <core@ietf.org>
Subject: [core] draft-ietf-core-links-json-01 review
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Mar 2014 17:52:16 -0000

Hi Carsten,

we wanted to use the format in JSON link I-D for HTTP-CoAP proxy discovery.

So I took a look at it, and this is my brief review.

=-=-=-=

Both Abstract and Introduction say “[…] may be useful to represent these
collections in JSON”.  Perhaps worth adding some text to better
substantiate its useful-ness over RFC5988 serialisation?  I guess one of
the main motivations for preferring JSON over Link is the increased "web
API friendliness" (i.e. no added parsing cost for extracting link
information, format homogenisation, etc.).  Is it correct?

On the same topic: I find the argument given in the second para of the
Introduction -- ie. the "proactively try to stop formats' proliferation"
function of this spec — not very compelling.   But this might just be me
:-)

Also I think that it'd be nice to give the reader enough context to
understand how JSON link differs from other similar proposals (JSON
formats JSON-LD, JSON Reference, HAL, etc.) and why it is a better choice
than any of those for our use case.

Re: the implicit vs explicit rel="hosts" in Section 2, I'd be inclined to
add it explicitly because in the wider web it can’t be assumed, but would
love to hear from you and/or  others for reasons why it shouldn't.

In section 2.1, it'd be nice to have examples that show the less obvious
bits, e.g. multi-valued attribute to array, escape chars, etc.

=-=-=-=

That said, the doc is in pretty good shape!  Any plan for an updated
version?

Cheers, t