Re: [core] Short review of SenML fetch/patch

Carsten Bormann <cabo@tzi.org> Thu, 11 October 2018 18:46 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A281E130ECF; Thu, 11 Oct 2018 11:46:11 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.199
X-Spam-Level:
X-Spam-Status: No, score=-4.199 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PbG8rkSxb--6; Thu, 11 Oct 2018 11:46:09 -0700 (PDT)
Received: from mailhost.informatik.uni-bremen.de (mailhost.informatik.uni-bremen.de [IPv6:2001:638:708:30c9::12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 35601130EC3; Thu, 11 Oct 2018 11:46:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at informatik.uni-bremen.de
Received: from submithost.informatik.uni-bremen.de (submithost2.informatik.uni-bremen.de [134.102.200.7]) by mailhost.informatik.uni-bremen.de (8.14.5/8.14.5) with ESMTP id w9BIjxC9025299; Thu, 11 Oct 2018 20:46:04 +0200 (CEST)
Received: from client-0223.vpn.uni-bremen.de (client-0223.vpn.uni-bremen.de [134.102.107.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by submithost.informatik.uni-bremen.de (Postfix) with ESMTPSA id 42WKfv3Hwgz1Bp8; Thu, 11 Oct 2018 20:45:59 +0200 (CEST)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <8F814ABD-10B3-4279-945B-D1B33E0BD1A8@ericsson.com>
Date: Thu, 11 Oct 2018 20:45:58 +0200
Cc: =?utf-8?Q?Christian_Ams=C3=BCss?= <christian@amsuess.com>, "draft-keranen-core-senml-fetch@ietf.org" <draft-keranen-core-senml-fetch@ietf.org>, core <core@ietf.org>
X-Mao-Original-Outgoing-Id: 560976357.063843-2c5ffaadb579ddb06c173c3ce518cb83
Content-Transfer-Encoding: quoted-printable
Message-Id: <30A7E4DE-3462-4F26-8635-8C5D4DFD9F21@tzi.org>
References: <20180927085947.GA5321@hephaistos.amsuess.com> <8F814ABD-10B3-4279-945B-D1B33E0BD1A8@ericsson.com>
To: =?utf-8?Q?Ari_Ker=C3=A4nen?= <ari.keranen@ericsson.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/YJkjcxOSxRDPR3egqWu-9l_FrTs>
Subject: Re: [core] Short review of SenML fetch/patch
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Oct 2018 18:46:12 -0000

On Sep 27, 2018, at 20:07, Ari Keränen <ari.keranen@ericsson.com> wrote:
> 
> The "v":null approach made this nice and clean, but you do have a valid point to consider here. Will have a closer look at this.

Well, as the review hints at in other places, a patch is not truly a SenML document per se, even if it cleverly shares most of its structure.
Maybe we should add a media type that explicitly identifies it as a patch.
(You’ll definitely have to adjust the CDDL to allow “v”:null.  
Also maybe explain that patches are defined for CBOR and JSON serialization only.)

Grüße, Carsten