Re: [core] Benjamin Kaduk's No Objection on draft-ietf-core-too-many-reqs-05: (with COMMENT)

Ari Keränen <ari.keranen@ericsson.com> Wed, 24 October 2018 06:35 UTC

Return-Path: <ari.keranen@ericsson.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1D7E4130DFD for <core@ietfa.amsl.com>; Tue, 23 Oct 2018 23:35:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.791
X-Spam-Level:
X-Spam-Status: No, score=-3.791 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FROM_EXCESS_BASE64=0.979, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com header.b=UPG7/1l6; dkim=fail (1024-bit key) reason="fail (body has been altered)" header.d=ericsson.com header.b=Gs19mxG0
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eMgRZJvMd0CD for <core@ietfa.amsl.com>; Tue, 23 Oct 2018 23:35:52 -0700 (PDT)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F62F12870E for <core@ietf.org>; Tue, 23 Oct 2018 23:35:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/simple; q=dns/txt; i=@ericsson.com; t=1540362949; x=1542954949; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6AZm7w2PEpZZgQ2YOmgSg1CYCLryM0XFse/LCPxtnbc=; b=UPG7/1l6WyEXp3Tjbakbg3ogNyXRRToGb1XHdzROwyXOMamoZ04VHVZF+d05Yb79 9e+tDOqnsfDogOuu4Fkx9fh42wPyjCXx1E8GP9fbPVVVhpnDxl/cV2o8f3Q3lq3m L7unmQfD/85hGwK/XBpQn82lrhhhIlWLAsvFpdVHJlU=;
X-AuditID: c1b4fb30-776849e0000047d2-b3-5bd012c57d3d
Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id 40.6A.18386.5C210DB5; Wed, 24 Oct 2018 08:35:49 +0200 (CEST)
Received: from ESESSMB504.ericsson.se (153.88.183.165) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Wed, 24 Oct 2018 08:35:45 +0200
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.157) by ESESSMB504.ericsson.se (153.88.183.165) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Wed, 24 Oct 2018 08:35:45 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H/MejZWfBbkSvyZBCndS2HZawBIJQinKT4eSYZT8AAU=; b=Gs19mxG0xOlpu+5cv987fYaRhhlUOzcAM4mLu3iooym0J5y2ietSY/tze0djjkIbz154OY/UFqt3pdL4dXWjdW5EI/0YHxUyok0nKjV0m0nqAYuNh3bOP4ar2vDTvXMRNIoaySnJGNox7MISeZ+OokmxOIhg1PbdUYugdhhcBL8=
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com (20.176.166.145) by HE1PR07MB1036.eurprd07.prod.outlook.com (10.162.27.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.17; Wed, 24 Oct 2018 06:35:44 +0000
Received: from HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b074:afe2:469c:dd95]) by HE1PR07MB4236.eurprd07.prod.outlook.com ([fe80::b074:afe2:469c:dd95%2]) with mapi id 15.20.1273.019; Wed, 24 Oct 2018 06:35:44 +0000
From: =?utf-8?B?QXJpIEtlcsOkbmVu?= <ari.keranen@ericsson.com>
To: Benjamin Kaduk <kaduk@mit.edu>
CC: The IESG <iesg@ietf.org>, "draft-ietf-core-too-many-reqs@ietf.org" <draft-ietf-core-too-many-reqs@ietf.org>, Carsten Bormann <cabo@tzi.org>, "core-chairs@ietf.org" <core-chairs@ietf.org>, "core@ietf.org" <core@ietf.org>
Thread-Topic: Benjamin Kaduk's No Objection on draft-ietf-core-too-many-reqs-05: (with COMMENT)
Thread-Index: AQHUawqUowScLHb5SkGvYwH/PHOlTaUt8X8A
Date: Wed, 24 Oct 2018 06:35:44 +0000
Message-ID: <73D663A8-782F-4417-ABB4-E95C657FBE87@ericsson.com>
References: <154032461873.31236.9757655812218106074.idtracker@ietfa.amsl.com>
In-Reply-To: <154032461873.31236.9757655812218106074.idtracker@ietfa.amsl.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: yes
X-MS-TNEF-Correlator:
x-originating-ip: [2001:14bb:180:9de9:b582:a195:f23e:eac4]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; HE1PR07MB1036; 6:ve3bQopFAr0Pg7p27ZURLnueoEUlRW9BtgVcDUHfSBTQlJrpc69Pfg8YN79Aj8RCdAlm3M4s5vuqmXUEbI31Pbw5pCbrDg/UbbEYfhYzaNyM8G9NHmStS2kRvIPkj8krzxErXE0FHTasa+a1IGdW7ShmHjES9u0ZYQxyZPBo7Ir7pa0BXb6tHRANNfRUI2wuKleRH7Q1HZghb9b/Mip+zsaVd48MGaGkIQWtHC9t+0+2wtthLbQqjxcMtlcDdjos0yBVY9czcf1cBShSOue10qjqtKALnJGelcrfBYgbtc51PgUCCJCZkojIsFKtfsy5K52o8B46oVC+bVX3EjkoOlRd9vh+4Y4iIXgq6WXoWiBvR+1/DsGF2NUrajHR9I9SeqvgnILzWCX4pFfIiSGn875RgGbge/TiviiEMhYdzAG0v0TTUWAhy8QNcynjwh9bhy0dKTD3dQwdkFYAe0y3lA==; 5:ZF6wDQpN9qWc7ntXsOKZ7ZIXHV2UFdq90Z2q1epWzlE09ncDl57NKEgexQ/NhuMYhhqqwFoxVbNYc1T5QsONXnkNUFhNaFRknPDbNkTWD2g5vHb55VlVwDfrSqTRrfzs/ItP0aSxi8fPzKoXPoJofaQVrOBIGc84zJz1a8pcHP8=; 7:1jj5nZHk/bMxnr4FM2BhkTXzM/XTlVkGN+lj/sqSCNvxN7J4VuMgLFMBulo25qRocOa8BBdApbLjj3k18me8ly+Ljhy36sV6ZsvN/Q7lStmnVbn17/pvFEbDqd1ao4sCmUuT/DahmEbU1ryB7qHtcA==
x-ms-exchange-antispam-srfa-diagnostics: SOS;
x-ms-office365-filtering-correlation-id: d26b0ad1-495d-42b9-477f-08d6397aed42
x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(49563074)(7193020); SRVR:HE1PR07MB1036;
x-ms-traffictypediagnostic: HE1PR07MB1036:
x-microsoft-antispam-prvs: <HE1PR07MB1036E3E8BA973D4C24B8B37A85F60@HE1PR07MB1036.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(166708455590820)(240460790083961)(158342451672863)(192374486261705);
x-ms-exchange-senderadcheck: 1
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(102415395)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231355)(944501410)(4983020)(52105095)(93006095)(93001095)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(20161123564045)(201708071742011)(7699051)(76991095); SRVR:HE1PR07MB1036; BCL:0; PCL:0; RULEID:; SRVR:HE1PR07MB1036;
x-forefront-prvs: 083526BF8A
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(376002)(346002)(366004)(396003)(39860400002)(136003)(189003)(199004)(6346003)(6512007)(81166006)(2616005)(11346002)(236005)(5660300001)(446003)(4326008)(99286004)(33656002)(2900100001)(476003)(82746002)(6506007)(85202003)(53936002)(46003)(316002)(14454004)(106356001)(6916009)(97736004)(105586002)(54896002)(6436002)(102836004)(6306002)(6246003)(478600001)(229853002)(2171002)(2906002)(486006)(5250100002)(6486002)(8936002)(345774005)(54906003)(36756003)(99936001)(186003)(8676002)(6116002)(25786009)(86362001)(966005)(85182001)(83716004)(14444005)(606006)(71190400001)(71200400001)(256004)(81156014)(76176011)(68736007)(7736002); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR07MB1036; H:HE1PR07MB4236.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
authentication-results: spf=none (sender IP is ) smtp.mailfrom=ari.keranen@ericsson.com;
x-microsoft-antispam-message-info: gNOzDyHK+ueuit78FPjpN69fNh3WI2XpaMEBxBSSJdZjEZXib/2eFWc0htvvT7L1/oD/cXgxa2AGc+22ifMhcIQ4VPjZrnNBSHUaiK83rGfndJqG1Q7BTxT3tJvRtY2pyn0Dnm1yzM+BzYOHH0FADc0x8RHMsvtc9C7LO1gD3ybkzp3ldlVFpCADIhsiGoQfRHX1r6QVYGXZ0Uy1Gt/fkeDMBwyd0WdSuImsdKmhn7otki9SF2lMpdQJG6+Mp5DOQiszmxXSnF/cjNCioM/2QvjNNtadczV1n2F9J1KPgSxwN9E2lAABQKERWC0fEDWF4keTwl0oSh93LaeSg/0tw6wQ/oigMmksiqXzKNGv0FM=
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/signed; boundary=Apple-Mail-658CDF7F-C810-438E-BF06-927648391F46; protocol="application/pkcs7-signature"; micalg=sha1
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d26b0ad1-495d-42b9-477f-08d6397aed42
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2018 06:35:44.7903 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR07MB1036
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA2WSe0iTYRTGefdddtHB27I6TCocBRVoTgxG9wuEEEkXiJiULf1QU2d8ny3X BSS00il4SXNqTHOh2EVX5g0qnM2ymptdoTJyLWqI5CIs0Sy3d4HQf79znucczvPySiiFiVVK MvS5HK/XZalYGW0+2HUy2qFwJ8V+rwvTPLw0wmg6bW5Wc3+8jdI0FN6lNTUz5ZSm2WYWbWUT rNYpUcK5Zw4qofpqxh5KK9uYymVlGDh+7eYjsnRnkZM6PpSW5//QL85HA6nFSCIBHA/fPMZi JJMosAOBx9dOFSPpXDGJoKKRI4JVBC8GXeJAQeMyCl5em0FEqRRBS3ktSwoPArP1DR2YZ/Em 8BbeZwIcgVXQ5CwImij8GUGfpS8oLMRH4FXBOZaYdHB5bEREOA4mft0QB5jGK6HTXxHsy/EW mHbWhA7cDZaeRlEghBQnwuPOvEAb4cXw88mNoJ3CS+Ct1xJkwBEwOvyUJbwIfJ9mGcLrof/V e5rwUnhuMQWTAX7NwpPeCyEhGiaqqijCu6HfNsAQ0zCC7zdLQlvXQPPzH4hwJlT5C0KsB/dk oZjwMmgtHaXJ8DsKCj/2istQbO28a2uDr1SJ4HNLN1UbTL0ABs1empiSoay1hiG8HLrG6ynC q+GBqTnkiYJLplEx4VVQNFnO/N/fAFP1HkR4HYw5/Gi+pwGFt6JFAicczU6Li4vh+IwUQcjR x+i53Nto7lv2dUzHdiPfl212hCVIFS5XTriSFIzOIBiz7WjF3B5P+3U3UtL6HD2nipDjP3Oy PFVnPMXxOcn8iSxOsKNICa1aItck3tEqcJoul8vkuOMc/08VSaTKfHQeG35zPZmJMctK06ft 6gEf82V25NFelzOevxMlHpVdbCxK+MWA/dqUzdxzr1Qk3te7rc14+nBdfdOxcbW6af9XZf6M K9lr6LhV914rdH/bUX1lu/amUpriD/P6bg0O7ax/3EWtPKMpCVeOH+hYFb1r4VlnXuSDmBRF WgP/5pCKFtJ16jUUL+j+AqramuSeAwAA
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/in1eimeDFYmTErm9wRLFp6d18Ts>
Subject: Re: [core] Benjamin Kaduk's No Objection on draft-ietf-core-too-many-reqs-05: (with COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2018 06:35:54 -0000

Thank you for the review Ben!

I have addressed most of your comments in the IESG review PR:
https://github.com/core-wg/too-many-reqs/pull/5/files

See answers and one more discussion point inline.

> On 23 Oct 2018, at 22.57, Benjamin Kaduk <kaduk@mit.edu>; wrote:
> 
> Benjamin Kaduk has entered the following ballot position for
> draft-ietf-core-too-many-reqs-05: No Objection
[...]
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Section 3
> 
> It may be appropriate to explicitly reiterate that "The 4.29 response code is
> only returned to the client(s) sending requests too frequently; if other
> clients are sending requests that cannot be served due to server overload,
> the 5.03 response code is more appropriate."

Good point. Added this text to the server behavior section.

>   If a client repeats a request that was answered with 4.29 before Max-
>   Age time has passed, it is possible the client did not recognize the
>   error code and the server MAY respond with a more generic error code
>   (e.g., 5.03).
> 
> Isn't it also possible that the additional requests were already in flight
> when the 4.29 was generated?  (It's unclear whether that needs to be
> specifcially mentioned in the document.)

Yes. I clarified this now in the end of server behavior section.

> Section 5
> 
> As per the previous comment, a server that erroneously returns 4.29 to too
> many (i.e., including well-behaving) clients would unnecessarily DoS the
> well-behaved clients.

Are you referring to “many requests in flight” issue? For a client sending too many requests before receiving an answer a 4.29 seems like appropriate answer. Or which well-behaving client do you mean here?

> It may be appropriate to reference the RFC 7252 security considerations as
> continuing to apply.

OK, I added a note in the beginning referring to RFC7252.


Thanks,
Ari