Re: [core] [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05

Alissa Cooper <alissa@cooperw.in> Mon, 14 October 2019 17:19 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 203F912094C; Mon, 14 Oct 2019 10:19:52 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=jqpG83nV; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=OunuLHyk
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HW2HpI2v3Amh; Mon, 14 Oct 2019 10:19:49 -0700 (PDT)
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 7BDDC120920; Mon, 14 Oct 2019 10:19:49 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BDB0321111; Mon, 14 Oct 2019 13:19:48 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 14 Oct 2019 13:19:48 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=g cVqDAQS1oyrQiWKUbh0bciHDWfkEMNPXyjwb1OdUu4=; b=jqpG83nVcJN8tEO2X sI4xdqSPL1VocKzw+cWnGjXTE57kvG08OZNJGG0jtX7xTgQeKOa4hMd1GDDirkfV kDP84FuJHCxL5RCodegoKxjrHLyLAiEBxc7oxEjlwdQOxEwxslLNnm/spW65aS1z CjhESVYdXTkiY0iORHMBSAogxtjR5Vs+TJm47vkgHDjphG9UQUwNLrvFbIiJuUg6 Rl1MFEng0voKGl/zX5fFtduh3gMAjLa6EQ1Uhc+Iz9VFTQ6rfyTd6R5umaLQFUB1 4cGt9N54V78Bus5xjq8dTXQEZhBHcLWvCZtdJtjLN3p0Ue2Fkjr62FQx5auKIo+l 1/fkw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=gcVqDAQS1oyrQiWKUbh0bciHDWfkEMNPXyjwb1OdU u4=; b=OunuLHykt8DxO1sddRO4EpBzAOOVSyyppWJZCTJ9duawZfoKR+EwSjRju tK4xR0yc7nzBRx8vScLV5a2LUDAWeloKKHDOwo8Rv6fh06k7+4+Yu25jSfJDj7NZ URCppCFj1v6M3TUYWcplbXcNEwuGJ3vkeijb/jIQIrScBDpzwiCIcddHL9gCTShZ hYNuDaJX0DGxcisixSZA1quMhckrY9eZOnp1IT5VORO0BEN/j4SmEsUmtJdflSHS dPiXEKRx6TiJTs5H1JjEScjPxLY5komVHbHAOzKbf8FUC33j+iiRx3yzSLWdPp77 H0xArrc+jrGQ3+x6hrZkv6QfH2lzQ==
X-ME-Sender: <xms:M66kXfF7ImQdLfo364FTh5ftAYv8_aAQomfQ6xJzoTeDTtGTtjMF-w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrjedugdduuddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptggguffhjgffgffkfhfvofesthhqmhdthhdtjeenucfhrhhomheptehlihhs shgrucevohhophgvrhcuoegrlhhishhsrgestghoohhpvghrfidrihhnqeenucffohhmrg hinhepihgvthhfrdhorhhgnecukfhppedujeefrdefkedruddujedrkeefnecurfgrrhgr mhepmhgrihhlfhhrohhmpegrlhhishhsrgestghoohhpvghrfidrihhnnecuvehluhhsth gvrhfuihiivgeptd
X-ME-Proxy: <xmx:M66kXQlBWn_LTMSs1atSbkaIHSiPJo-xnHT8O_xXMWY7RQ6tcyWf6g> <xmx:M66kXcKz0tO3fgzC_4KrPO9KVP-UjXadmEId07JVCvEUmDxp8lyX_w> <xmx:M66kXRbfDYAooXjTHFYeGq3pPchVYPupMjJamTEXUBbgJ6eLBeWsvQ> <xmx:NK6kXeVdyD9sqEt2oRoWd5DvflvIwlJqWaCPUxT_scAsh-6ulgMXQg>
Received: from rtp-alcoop-nitro3.cisco.com (unknown [173.38.117.83]) by mail.messagingengine.com (Postfix) with ESMTPA id 0DEC88005B; Mon, 14 Oct 2019 13:19:47 -0400 (EDT)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <6E58094ECC8D8344914996DAD28F1CCD23D6B5C5@DGGEMM506-MBX.china.huawei.com>
Date: Mon, 14 Oct 2019 13:19:46 -0400
Cc: "mohamed.boucadair@orange.com" <mohamed.boucadair@orange.com>, Jaime Jiménez <jaime@iki.fi>, Roni Even <ron.even.tlv@gmail.com>, "draft-ietf-core-hop-limit.all@ietf.org" <draft-ietf-core-hop-limit.all@ietf.org>, "gen-art@ietf.org" <gen-art@ietf.org>, "ietf@ietf.org" <ietf@ietf.org>, "core@ietf.org" <core@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <83BF20DD-190A-4DB7-8C4C-F80A65603773@cooperw.in>
References: <156915425127.1340.18230115848839912205@ietfa.amsl.com> <20190922132830.kemraqhnzcjxprt2@EMB-918HFH01> <6E58094ECC8D8344914996DAD28F1CCD23D6A192@DGGEMM506-MBX.china.huawei.com> <787AE7BB302AE849A7480A190F8B933031324439@OPEXCAUBMA2.corporate.adroot.infra.ftgroup> <6E58094ECC8D8344914996DAD28F1CCD23D6B5C5@DGGEMM506-MBX.china.huawei.com>
To: "Roni Even (A)" <roni.even@huawei.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/lrCBhYqWV5a743fL_pShO84NLhQ>
Subject: Re: [core] [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Oct 2019 17:19:53 -0000

Roni, thanks for your review. Authors, thanks for your responses. I see IANA has received a suggested value. I entered a No Objection ballot.

Alissa


> On Sep 24, 2019, at 12:29 AM, Roni Even (A) <roni.even@huawei.com> wrote:
> 
> Hi Med,
> Thanks, I have no further comments
> 
> Roni
> 
> -----Original Message-----
> From: mohamed.boucadair@orange.com [mailto:mohamed.boucadair@orange.com] 
> Sent: Monday, September 23, 2019 9:19 AM
> To: Roni Even (A); Jaime Jiménez; Roni Even
> Cc: draft-ietf-core-hop-limit.all@ietf.org; gen-art@ietf.org; ietf@ietf.org; core@ietf.org
> Subject: RE: [Gen-art] Genart last call review of draft-ietf-core-hop-limit-05
> 
> Hi Roni,
> 
> Sure. We can include a suggested value. 
> 
> Thank you for the review.
> 
> Cheers,
> Med
> 
>> -----Message d'origine-----
>> De : Roni Even (A) [mailto:roni.even@huawei.com] Envoyé : lundi 23 
>> septembre 2019 07:01 À : Jaime Jiménez; Roni Even Cc : 
>> draft-ietf-core-hop-limit.all@ietf.org; gen-art@ietf.org; 
>> ietf@ietf.org; core@ietf.org Objet : RE: [Gen-art] Genart last call 
>> review of draft-ietf-core-hop-
>> limit-05
>> 
>> Hi,
>> I looked at section 5.4.6 and now I understand that the option is 
>> elective, non-repeatable and part of cache key.
>> That will mean that the option number should have the two least 
>> significant bits as 0 and the next 3 bits some combination that is not 
>> all 1's, see also https://tools.ietf.org/html/rfc7252#section-5.10
>> 
>> I think you need to recommend a number for the option to IANA that 
>> will allow understanding of the characteristics of the option, IANA 
>> cannot allocate a random number to a new option
>> 
>> Roni
>> 
>> 
>> 
>> -----Original Message-----
>> From: Gen-art [mailto:gen-art-bounces@ietf.org] On Behalf Of Jaime 
>> Jiménez
>> Sent: Sunday, September 22, 2019 4:29 PM
>> To: Roni Even
>> Cc: draft-ietf-core-hop-limit.all@ietf.org; gen-art@ietf.org; 
>> ietf@ietf.org; core@ietf.org
>> Subject: Re: [Gen-art] Genart last call review of draft-ietf-core-hop-
>> limit-05
>> 
>> Dear Roni,
>> 
>> I believe the CUNR bit mask is defined in 5.4.6
>> https://tools.ietf.org/html/rfc7252#page-39
>> I assume it has to be added for every new option defined.
>> 
>> Ciao!
>> 
>> On Sun, Sep 22, 2019 at 05:10:51AM -0700, Roni Even via Datatracker wrote:
>>> Reviewer: Roni Even
>>> Review result: Ready with Nits
>>> 
>>> I am the assigned Gen-ART reviewer for this draft. The General Area 
>>> Review Team (Gen-ART) reviews all IETF documents being processed by 
>>> the IESG for the IETF Chair.  Please treat these comments just like 
>>> any other last call comments.
>>> 
>>> For more information, please see the FAQ at
>>> 
>>> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
>>> 
>>> Document: draft-ietf-core-hop-limit-??
>>> Reviewer: Roni Even
>>> Review Date: 2019-09-22
>>> IETF LC End Date: 2019-09-27
>>> IESG Telechat date: Not scheduled for a telechat
>>> 
>>> Summary:
>>> The document is ready for publication as a standard track RFC with 
>>> nits
>>> 
>>> Major issues:
>>> 
>>> Minor issues:
>>> 
>>> Nits/editorial comments:
>>> 
>>> In section 6.2 I am not sure why you have CUNR , I did not see these 
>>> values in
>>> RFC7252 section 12.2 
>>> https://tools.ietf.org/html/rfc7252#section-12.2
>>> or in the registry
>>> 
>>>         +--------+---+---+---+---+------------------+-----------+
>>>         | Number | C | U | N | R | Name             | Reference |
>>>         +--------+---+---+---+---+------------------+-----------+
>>>         |  TBA2  |   |   |   |   | Hop-Limit        | [RFCXXXX] |
>>>         +--------+---+---+---+---+------------------+-----------+
>>>             C=Critical, U=Unsafe, N=NoCacheKey, R=Repeatable
>>> 
>>> 
>> 
>> _______________________________________________
>> Gen-art mailing list
>> Gen-art@ietf.org
>> https://www.ietf.org/mailman/listinfo/gen-art
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art