Re: [core] implementer feedback on CORE-SID: Re: [mbj4668/pyang] Sid sx structure (PR #839)

Michael Richardson <mcr+ietf@sandelman.ca> Sun, 26 March 2023 18:06 UTC

Return-Path: <mcr+ietf@sandelman.ca>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE63EC1524AE for <core@ietfa.amsl.com>; Sun, 26 Mar 2023 11:06:15 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.397
X-Spam-Level:
X-Spam-Status: No, score=-4.397 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_ZEN_BLOCKED_OPENDNS=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_DBL_BLOCKED_OPENDNS=0.001, URIBL_ZEN_BLOCKED_OPENDNS=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=sandelman.ca
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KSoM0bHLjG4X for <core@ietfa.amsl.com>; Sun, 26 Mar 2023 11:06:11 -0700 (PDT)
Received: from tuna.sandelman.ca (tuna.sandelman.ca [IPv6:2607:f0b0:f:3:216:3eff:fe7c:d1f3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EBD38C1524AA for <core@ietf.org>; Sun, 26 Mar 2023 11:06:10 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by tuna.sandelman.ca (Postfix) with ESMTP id 180BC3898E; Sun, 26 Mar 2023 14:39:28 -0400 (EDT)
Received: from tuna.sandelman.ca ([127.0.0.1]) by localhost (localhost [127.0.0.1]) (amavisd-new, port 10024) with LMTP id F4dl7JJuo4eQ; Sun, 26 Mar 2023 14:39:27 -0400 (EDT)
Received: from sandelman.ca (unknown [IPv6:2607:f0b0:f:2:56b2:3ff:fe0b:d84]) by tuna.sandelman.ca (Postfix) with ESMTP id 61A323898C; Sun, 26 Mar 2023 14:39:27 -0400 (EDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sandelman.ca; s=mail; t=1679855967; bh=asUonCvo1I2W4zN//uGjzexFgek87GWIEPrwetZNlgs=; h=From:To:cc:Subject:In-Reply-To:References:Date:From; b=FQpGJUiE2SJMggcRHkraJSJwu4y3WLyX5ergFnZN/fLW9Gdzu9ZVvvbpIeg/6yaWz SIAOj+Yi1fdrA9YTPTskFRlFOgYolRxV636hHr3XuKx2HU1kiqsEVrVS85/XxJgJL2 9Tz4fKj3S/bY8JR/xWSy4qGkqj+FP4kJoEHqAjZJjgnjia8G/9zEU+rQ64iSQjJtEQ SiiXrZ55fGR6/nVFaENNVaJozxcT+S3k5QOxK+jMvXD06WeDtrl+nA2hTOdA3XIONg SubHrBcHsp/97BGO9z5Zfh5zvYYSdf3RXqtI8p6ConcWM8w0NLxfSO8A+mek6v1a/H TpfB8AQYGKB2g==
Received: from localhost (localhost [IPv6:::1]) by sandelman.ca (Postfix) with ESMTP id EE9023F5; Sun, 26 Mar 2023 14:06:07 -0400 (EDT)
From: Michael Richardson <mcr+ietf@sandelman.ca>
To: Jernej Tuljak <jernej.tuljak@mg-soft.si>
cc: core@ietf.org
In-Reply-To: <477a30f2-fce5-4efa-8c0c-d084dbe8cedd@mg-soft.si>
References: <mbj4668/pyang/pull/839@github.com> <mbj4668/pyang/pull/839/c1474951745@github.com> <2897262.1679232828@dyas> <bed2e140-d5e3-2aba-c2e1-6c8066602660@mg-soft.si> <28078.1679313444@localhost> <ea2899eb-e02c-9ad0-2ead-c0a341410225@mg-soft.si> <4633.1679579478@localhost> <477a30f2-fce5-4efa-8c0c-d084dbe8cedd@mg-soft.si>
X-Mailer: MH-E 8.6+git; nmh 1.7+dev; GNU Emacs 27.1
X-Face: $\n1pF)h^`}$H>Hk{L"x@)JS7<%Az}5RyS@k9X%29-lHB$Ti.V>2bi.~ehC0; <'$9xN5Ub# z!G,p`nR&p7Fz@^UXIn156S8.~^@MJ*mMsD7=QFeq%AL4m<nPbLgmtKK-5dC@#:k
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha512"; protocol="application/pgp-signature"
Date: Sun, 26 Mar 2023 14:06:07 -0400
Message-ID: <24165.1679853967@localhost>
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/nKt1vfdfVSc1JCLziU2R7QTvZ4Y>
Subject: Re: [core] implementer feedback on CORE-SID: Re: [mbj4668/pyang] Sid sx structure (PR #839)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 26 Mar 2023 18:06:15 -0000

Jernej Tuljak <jernej.tuljak@mg-soft.si> wrote:
    >> > I'm not sure I understand what you meant. Were you referring to the change in
    >> > the order of assignments for schema nodes? Yes, those occur in "pyang
    >>
    >> I'm asking if your new order of assignment would be stable even if the dict()
    >> implementation was changed, or if it ran on a different architecture.

    > I just realized that there is no "new order of assignment" in my fork
    > compared to the original implementation. The order in which the YANG
    > statements are iterated over in code is irrelevant, because all items are
    > always sorted by namespace and identifier before any assignments are done. I
    > did not change that. The only difference are the additional schema nodes that
    > are now part of the mapping (choice, case, etc.).

Perfect... so moving text around in the YANG input file should never change
anything, unless we rename the leaves so that they sort in a different order.
And if someone who does that, *and* resets their SID file to empty, then they
should expect different order.

--
Michael Richardson <mcr+IETF@sandelman.ca>   . o O ( IPv6 IøT consulting )
           Sandelman Software Works Inc, Ottawa and Worldwide