Re: [core] Suresh Krishnan's No Objection on draft-ietf-core-hop-limit-06: (with COMMENT)

<mohamed.boucadair@orange.com> Tue, 15 October 2019 09:00 UTC

Return-Path: <mohamed.boucadair@orange.com>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E21331200A4; Tue, 15 Oct 2019 02:00:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dC5dqITpBzfQ; Tue, 15 Oct 2019 02:00:56 -0700 (PDT)
Received: from relais-inet.orange.com (relais-inet.orange.com [80.12.70.34]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 43D761200B1; Tue, 15 Oct 2019 02:00:56 -0700 (PDT)
Received: from opfednr04.francetelecom.fr (unknown [xx.xx.xx.68]) by opfednr27.francetelecom.fr (ESMTP service) with ESMTP id 46sqCV656tz4wd5; Tue, 15 Oct 2019 11:00:54 +0200 (CEST)
Received: from Exchangemail-eme6.itn.ftgroup (unknown [xx.xx.13.57]) by opfednr04.francetelecom.fr (ESMTP service) with ESMTP id 46sqCV1H06z1xpF; Tue, 15 Oct 2019 11:00:54 +0200 (CEST)
Received: from OPEXCAUBMA2.corporate.adroot.infra.ftgroup ([fe80::e878:bd0:c89e:5b42]) by OPEXCAUBM6D.corporate.adroot.infra.ftgroup ([fe80::4c24:f1ba:2b1:e490%21]) with mapi id 14.03.0468.000; Tue, 15 Oct 2019 11:00:53 +0200
From: mohamed.boucadair@orange.com
To: Suresh Krishnan <suresh@kaloom.com>, The IESG <iesg@ietf.org>
CC: "draft-ietf-core-hop-limit@ietf.org" <draft-ietf-core-hop-limit@ietf.org>, Jaime Jimenez <jaime@iki.fi>, "core-chairs@ietf.org" <core-chairs@ietf.org>, "core@ietf.org" <core@ietf.org>
Thread-Topic: Suresh Krishnan's No Objection on draft-ietf-core-hop-limit-06: (with COMMENT)
Thread-Index: AQHVgwXN+nqWV8IGP0mMqknceHsTw6dbKdeQ
Date: Tue, 15 Oct 2019 09:00:53 +0000
Message-ID: <787AE7BB302AE849A7480A190F8B93303133E81A@OPEXCAUBMA2.corporate.adroot.infra.ftgroup>
References: <157110890042.24804.1786615660069135136.idtracker@ietfa.amsl.com>
In-Reply-To: <157110890042.24804.1786615660069135136.idtracker@ietfa.amsl.com>
Accept-Language: fr-FR, en-US
Content-Language: fr-FR
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.114.13.247]
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/puqpZLFRnGEWbzc469kitkMueKY>
Subject: Re: [core] Suresh Krishnan's No Objection on draft-ietf-core-hop-limit-06: (with COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 09:00:58 -0000

Hi Suresh, 

Thank you for the review.

Please see inline. 

Cheers,
Med

> -----Message d'origine-----
> De : Suresh Krishnan via Datatracker [mailto:noreply@ietf.org]
> Envoyé : mardi 15 octobre 2019 05:08
> À : The IESG
> Cc : draft-ietf-core-hop-limit@ietf.org; Jaime Jimenez; core-
> chairs@ietf.org; jaime@iki.fi; core@ietf.org
> Objet : Suresh Krishnan's No Objection on draft-ietf-core-hop-limit-06:
> (with COMMENT)
> 
> Suresh Krishnan has entered the following ballot position for
> draft-ietf-core-hop-limit-06: No Objection
> 
> When responding, please keep the subject line intact and reply to all
> email addresses included in the To and CC lines. (Feel free to cut this
> introductory paragraph, however.)
> 
> 
> Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
> for more information about IESG DISCUSS and COMMENT positions.
> 
> 
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-core-hop-limit/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> * Section 3
> 
> "CoAP messages received with a Hop-Limit option ... ***greater than
> '255'***
> MUST be rejected"
> 
> Since the field is only 8 bits long this will never happen, right? If so,
> this
> text about >255 needs to be removed.
> 

[Med] The range is provided because the option format is said to be uint:

   The value of the Hop-Limit option is encoded as an unsigned integer
                                                      ^^^^^^^^^^^^^^^^
   (see Section 3.2 of [RFC7252]).  This value MUST be between 1 and 255
   inclusive.

Which leads to the Length of 1 byte depicted in Table 1.  

> * I would have expected that a CoAP option with NoCacheKey bits all zero
> would
> need to match in order to be served from the cache. 

[Med] We allow to serve from the cache even for lower values when a negative response is cached. If a loop is encountered for, e.g., a hl=15, it will be encountered for a small value, e.g., hl=13. 

Checking also for
> smaller
> values of Hop Limit for sending stored responses seems to (IMHO) complicate
> things for little benefit.

[Med] If there is going to be caching, then every proxy in the chain is likely to cache the response. So, the request will get no further than the first proxy (with the high hop-limit value).