Re: [core] Review of draft-ietf-core-senml-versions-01

[Carsten Bormann <[e-mail]>]

On 12. Feb 2021, at 09:39, Jaime Jiménez <[e-mail]> wrote:
> 
> Dear authors,
> 
> first of all I'd like to apologise for the delay when providing the review.
> 
> While I did not find any mistakes, there are few additions to the document that *could* help clarify it for the benefit of the readers:
> 
> - Mention somewhere in the text that the maximum amount of features is 53 and that therefore the highest version number is 2**53-1 in decimal notation. Therefore readers should not expect the usual linear semantic versioning for each version (1,2,3,4...) but rather (10, 26, 42, 58...).

Actually, that is already mentioned in the IANA Considerations.
I have now added a subsection “Discussion” to Section 2 .

> - Give an example of the current bitmap -for example in a double or float representation- providing all features that are currently supported for bver=26.
> 
> 00000000 00000000
> 00000000 00000000
> 00000000 00000000
> 00000000 00011010

This example has 64 bits; we only have 53…
I’ve put in 0b00000000000000000000000000000000000000000000000001010 as an example.

> - The limitation to 53 versions in total as well as potential feature deprecation was already discussed in various IETFs and neither authors nor the group see that as a limitation. I agree with that providing that expert review is conservative when adding new features. Potentially we could also think about bundling some future features if they are related before publication; but it is very hard to forecast that.

Added discussion of an allocation rate limit of about two codes per year or less.

> Note that, ahead of the shepherd writeup, it would be good to document existing implementations out there.
> 
> Editorial:
> 
> "Network Working Group" should be CoRE.

(Will go away in the RFC.)

> independently selectable "features"
> Use of quotes for features seems unnecessary, as those literally are features.                       

Went for italic (but not in the abstract, where fonts are more easily lost).

Thanks!

Now https://github.com/core-wg/senml-versions/pull/1
(WG members: Please review and approve and/or comment!)

Grüße, Carsten