From nobody Fri Feb 12 01:48:49 2021 Return-Path: X-Original-To: core@ietfa.amsl.com Delivered-To: core@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 491823A14C8 for ; Fri, 12 Feb 2021 01:48:48 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -1.92 X-Spam-Level: X-Spam-Status: No, score=-1.92 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LNHg8w0tohzY for ; Fri, 12 Feb 2021 01:48:44 -0800 (PST) Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 84B993A14C6 for ; Fri, 12 Feb 2021 01:48:44 -0800 (PST) Received: from [192.168.217.152] (p5089a828.dip0.t-ipconnect.de [80.137.168.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4DcTGJ3P3tzyVj; Fri, 12 Feb 2021 10:48:40 +0100 (CET) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) From: Carsten Bormann In-Reply-To: <422b8d83-ee97-4a6c-81ec-3cf004f2cd09@www.fastmail.com> Date: Fri, 12 Feb 2021 10:48:31 +0100 Cc: core@ietf.org Content-Transfer-Encoding: quoted-printable Message-Id: <3388E5A7-FF68-490A-8DA8-075CBF94DEDE@tzi.org> References: <422b8d83-ee97-4a6c-81ec-3cf004f2cd09@www.fastmail.com> To: =?utf-8?Q?Jaime_Jim=C3=A9nez?= X-Mailer: Apple Mail (2.3654.60.0.2.21) Archived-At: Subject: Re: [core] Review of draft-ietf-core-senml-versions-01 X-BeenThere: core@ietf.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Feb 2021 09:48:48 -0000 On 12. Feb 2021, at 09:39, Jaime Jim=C3=A9nez wrote: >=20 > Dear authors, >=20 > first of all I'd like to apologise for the delay when providing the = review. >=20 > While I did not find any mistakes, there are few additions to the = document that *could* help clarify it for the benefit of the readers: >=20 > - Mention somewhere in the text that the maximum amount of features is = 53 and that therefore the highest version number is 2**53-1 in decimal = notation. Therefore readers should not expect the usual linear semantic = versioning for each version (1,2,3,4...) but rather (10, 26, 42, 58...). Actually, that is already mentioned in the IANA Considerations. I have now added a subsection =E2=80=9CDiscussion=E2=80=9D to Section 2 = . > - Give an example of the current bitmap -for example in a double or = float representation- providing all features that are currently = supported for bver=3D26. >=20 > 00000000 00000000 > 00000000 00000000 > 00000000 00000000 > 00000000 00011010 This example has 64 bits; we only have 53=E2=80=A6 I=E2=80=99ve put in = 0b00000000000000000000000000000000000000000000000001010 as an example. > - The limitation to 53 versions in total as well as potential feature = deprecation was already discussed in various IETFs and neither authors = nor the group see that as a limitation. I agree with that providing that = expert review is conservative when adding new features. Potentially we = could also think about bundling some future features if they are related = before publication; but it is very hard to forecast that. Added discussion of an allocation rate limit of about two codes per year = or less. > Note that, ahead of the shepherd writeup, it would be good to document = existing implementations out there. >=20 > Editorial: >=20 > "Network Working Group" should be CoRE. (Will go away in the RFC.) > independently selectable "features" > Use of quotes for features seems unnecessary, as those literally are = features. =20 Went for italic (but not in the abstract, where fonts are more easily = lost). Thanks! Now https://github.com/core-wg/senml-versions/pull/1 (WG members: Please review and approve and/or comment!) Gr=C3=BC=C3=9Fe, Carsten