Re: [core] Warren Kumari's No Objection on draft-ietf-core-problem-details-05: (with COMMENT)

Carsten Bormann <cabo@tzi.org> Wed, 15 June 2022 20:04 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2FB2EC15AACC; Wed, 15 Jun 2022 13:04:13 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.909
X-Spam-Level:
X-Spam-Status: No, score=-6.909 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id m8sv5lc1ptSu; Wed, 15 Jun 2022 13:04:08 -0700 (PDT)
Received: from gabriel-smtp.zfn.uni-bremen.de (gabriel-smtp.zfn.uni-bremen.de [IPv6:2001:638:708:32::15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id B7E22C14F725; Wed, 15 Jun 2022 13:03:23 -0700 (PDT)
Received: from [192.168.217.118] (p5089ad4f.dip0.t-ipconnect.de [80.137.173.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-smtp.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4LNbpH2mfVzDCby; Wed, 15 Jun 2022 22:03:19 +0200 (CEST)
Content-Type: text/plain; charset="utf-8"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
From: Carsten Bormann <cabo@tzi.org>
In-Reply-To: <165513900089.13413.16928329866622205617@ietfa.amsl.com>
Date: Wed, 15 Jun 2022 22:03:18 +0200
Cc: The IESG <iesg@ietf.org>, draft-ietf-core-problem-details@ietf.org, core-chairs@ietf.org, core@ietf.org, jaime@iki.fi
X-Mao-Original-Outgoing-Id: 677016198.6514651-fb8c8851f09840067138ce8f3f16770a
Content-Transfer-Encoding: quoted-printable
Message-Id: <B47F3D94-AD76-4B6E-B386-F0EB8050EAD3@tzi.org>
References: <165513900089.13413.16928329866622205617@ietfa.amsl.com>
To: Warren Kumari <warren@kumari.net>
X-Mailer: Apple Mail (2.3608.120.23.2.7)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/qDfAwqXkiRq_ka5aYIV0LBT_vs4>
Subject: Re: [core] Warren Kumari's No Objection on draft-ietf-core-problem-details-05: (with COMMENT)
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.39
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jun 2022 20:04:13 -0000

Hi Warren,

thank you for these two comments — small things like these do improve the document.
The proposed fixes are at:

https://github.com/core-wg/core-problem-details/pull/36/files

On 2022-06-13, at 18:50, Warren Kumari via Datatracker <noreply@ietf.org> wrote:
> 
> Warren Kumari has entered the following ballot position for
> draft-ietf-core-problem-details-05: No Objection
> […]
> The document, along with other ballot positions, can be found here:
> https://datatracker.ietf.org/doc/draft-ietf-core-problem-details/
> 
> 
> 
> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Thank you for this document, and also for responding to Joel's OpsDir review --
> https://datatracker.ietf.org/doc/review-ietf-core-problem-details-04-opsdir-lc-jaeggli-2022-06-06/
> 
> I have two comments (well, one comment and a nit):
> 1: Introduction: "It is designed to be reused by REST APIs, which can identify
> distinct shapes of these data items specific to their needs." - I like this
> description, but I initially went off trying to find if something (RFC7252,
> STD94, REST, etc) has described shapes before. Section 2 does a nice job of
> describing the term, but putting "shapes" in quotes in the introduction would
> have saved me some rabbit-holing...

The shape thing seems to raise interesting comments...
I just found a couple of quotes on my keyboard and added these to the introduction.

> 2: Section 3.2 / Figure 3 has an example, which helped make this all a lot
> clearer to me. I think that it would be helpful to people not familiar with
> this topic to have an example much earlier in the document...

I don’t think we can change the sequence here, but I added a forward reference for one-click access to an example for those people who want to see it right away.

Grüße, Carsten