[core] draft-ietf-core-comi-11 shepherd review

Carsten Bormann <cabo@tzi.org> Thu, 04 February 2021 04:47 UTC

Return-Path: <cabo@tzi.org>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AB0ED3A0CF6 for <core@ietfa.amsl.com>; Wed, 3 Feb 2021 20:47:45 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XO7np75uByTk for <core@ietfa.amsl.com>; Wed, 3 Feb 2021 20:47:42 -0800 (PST)
Received: from gabriel-vm-2.zfn.uni-bremen.de (gabriel-vm-2.zfn.uni-bremen.de [134.102.50.17]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34D643A0CEB for <core@ietf.org>; Wed, 3 Feb 2021 20:47:41 -0800 (PST)
Received: from [192.168.217.152] (p5089a828.dip0.t-ipconnect.de [80.137.168.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gabriel-vm-2.zfn.uni-bremen.de (Postfix) with ESMTPSA id 4DWQyh1hC1zyWH; Thu, 4 Feb 2021 05:47:40 +0100 (CET)
From: Carsten Bormann <cabo@tzi.org>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\))
Date: Thu, 04 Feb 2021 05:47:39 +0100
Message-Id: <B981A721-73BF-4F63-8A67-3666955452DF@tzi.org>
To: "core@ietf.org WG (core@ietf.org)" <core@ietf.org>
X-Mailer: Apple Mail (2.3654.40.0.2.32)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/s8NpP5ZBoX3T04rbzxenZjXhcY4>
Subject: [core] draft-ietf-core-comi-11 shepherd review
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2021 04:47:46 -0000

In my shepherd review of draft-ietf-core-comi-11, I have found a few points that probably need some WG action before we can submit this draft to IESG.
(I also have submitted a PR addressing some nits, https://github.com/core-wg/comi/pull/1 .)

Specifically:

# Major

*** 5: This whole section is rather disappointing.  What does this
    really do except for pointing at RFC 7959?  Is there any
    recommendation in how to work around the race condition?  The
    recommendation to use indefinite length is not solving any problem
    (does not work except in very fortuitous cases).

*** 6.2.2 How does the pagination work, then?
    This SHOULD is not actionable.

*** 7: This creates confusion between 4.01 and 4.03

# Minor

*** 2.2: While it is not clear whether there will be a SID 0, the text
     seems to imply that this would be encoded in the empty string.
     Should it rather specify a single "A”?

*** Appendix A:  Updated to reference RFC 8949 (see PR).
     Do we need a new module version after this edit?


Grüße, Carsten