Re: [core] [Gen-art] Genart last call review of draft-ietf-core-senml-etch-05

Alissa Cooper <alissa@cooperw.in> Wed, 04 September 2019 19:42 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: core@ietfa.amsl.com
Delivered-To: core@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 57D4E120E00; Wed, 4 Sep 2019 12:42:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=mEUd6zcr; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=rR8xsl4k
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jkP3t96u9s33; Wed, 4 Sep 2019 12:42:02 -0700 (PDT)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A8C7E120DF8; Wed, 4 Sep 2019 12:41:59 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C45B221FE5; Wed, 4 Sep 2019 15:41:58 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 04 Sep 2019 15:41:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h= content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; s=fm1; bh=4 OuzS5LuXLm8LcQepUa32efPufEDl+OlBo2dSqFli/Y=; b=mEUd6zcrXtMBzm3mo 0V2Jf/JOl6m3BAhutMSaD+B9pVFK2GykcSZ9B2opyADeGdw6DtCRsvxby/wXRM78 VVS9FNErCJfqOVSGXaVdra6fFtO0Snoxh8atUtjpOIlx2kph7dc1EXnYe1tap2Sd x3r4vW7rQIMraGS7ItKhmN5NTE7fENws0FdVhBo3IWhR9A07B3VnF3mZ5zb0hgNc VcbqGxJnZSWpd1BlFOuVdWFlD692Q6MToZSAPbgT0bOr2sQ7R7ZA1i6SBoUjGUp1 35oVTXzsM/e5BGc3VYcKys/+XtHaZg3AqOWKBzNRS8LTcB9xVYp3vtqfW+MZ9+iI Qk7Bg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=4OuzS5LuXLm8LcQepUa32efPufEDl+OlBo2dSqFli /Y=; b=rR8xsl4kpBIbuDVNnh7HwA77xcgrrrUbBBzs7UHPWKZSIWgzXFlo12y9G GfZKTV/dxZ70hk9gTCfm7IE+FatVztG4cHu9kUI8HaNmoXFWNXicylP9yB7N2ydl R9qKEwZPeUVOqpF+8f5jHtR3qpyibw8iS3SPa0aJ/N6Vp3hsU/kvg7QqwOd0F9Fl pArNJjK1gv1Bt3HTBISgiQkIFAZVUe8BOslbc/D6RlKrr74icqkWFQkApAsL+3E7 WGpo4W7JZcaND5VfKHYmnxS0BN4LYoWi6QRVuewKN6Oz3EL8Ulcssv70QKley9Ee xOBZ94nU5WE2EOlj+8kC57StXaadQ==
X-ME-Sender: <xms:hhNwXToNGT_vpcuXjOvSTZ_SVicbztj7pNP3guc9j2DKSGJemfLTfA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejhedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjfffgkfhfvffosehtqhhmtdhhtddvnecuhfhrohhmpeetlhhi shhsrgcuvehoohhpvghruceorghlihhsshgrsegtohhophgvrhifrdhinheqnecuffhomh grihhnpehivghtfhdrohhrghenucfkphepudejfedrfeekrdduudejrdejgeenucfrrghr rghmpehmrghilhhfrhhomheprghlihhsshgrsegtohhophgvrhifrdhinhenucevlhhush htvghrufhiiigvpedt
X-ME-Proxy: <xmx:hhNwXZq7vL089bn_WLpR4DjGa5p3WG1gi9e2z_u_5Mn7awWqjw1mDw> <xmx:hhNwXSaNo1q342pkWe2MluIVEFGMtxnFRS92sJRe_P_WzkavRXibaA> <xmx:hhNwXX8dL87MJ9rbEBopehJg6Z-4liHfZSVRPXSHTjiTiIqCXXNLzg> <xmx:hhNwXeOGt6oZxmu4Fx166fKZB88iuUSXOcUtap3XPbkpsEpPk6fZgw>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.74]) by mail.messagingengine.com (Postfix) with ESMTPA id EB3F4D6005A; Wed, 4 Sep 2019 15:41:57 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <156708950337.21012.630829697167091848@ietfa.amsl.com>
Date: Wed, 04 Sep 2019 15:41:56 -0400
Cc: gen-art <gen-art@ietf.org>, ietf@ietf.org, core@ietf.org, draft-ietf-core-senml-etch.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <47334E59-0A7A-445D-A663-9F00E646684D@cooperw.in>
References: <156708950337.21012.630829697167091848@ietfa.amsl.com>
To: Robert Sparks <rjsparks@nostrum.com>
X-Mailer: Apple Mail (2.3445.9.1)
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/sSIZIZKWYUL2Q96WOZf3xAuEK80>
Subject: Re: [core] [Gen-art] Genart last call review of draft-ietf-core-senml-etch-05
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 04 Sep 2019 19:42:04 -0000

Robert, thanks for your review. I pointed to it in my No Objection ballot.

Best,
Alissa


> On Aug 29, 2019, at 10:38 AM, Robert Sparks via Datatracker <noreply@ietf.org> wrote:
> 
> Reviewer: Robert Sparks
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-core-senml-etch-05
> Reviewer: Robert Sparks
> Review Date: 2019-08-29
> IETF LC End Date: 2019-09-02
> IESG Telechat date: 2019-09-05
> 
> Summary: Ready for publication as a Proposed Standard RFC, but with nits to
> consider before publication
> 
> Nits:
> 
> Since the string "-etch-" is in the media type, it might be nice to say in the
> document where it came from.
> 
> I think the text in the interoperability considerations sections of the
> registrations could be improved. You mean to talk about unrecognized keys, not
> unrecognized key-value pairs. I also think the body of the RFC should have a
> very short extensibility section that explicitly says you're doing a similar
> thing as 8424 section 4.4 and point to that section.
> 
> I am a little uncomfortable with the "Fragment Identification" section (4) of
> this document - it feels like a "do what we mean" statement. I don't have text
> to suggest. It may well be that it will be dead-obvious to an implementer what
> to do, but it makes me uneasy.
> 
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art