[core] Genart last call review of draft-ietf-core-sid-15

Linda Dunbar via Datatracker <noreply@ietf.org> Tue, 16 March 2021 17:34 UTC

Return-Path: <noreply@ietf.org>
X-Original-To: core@ietf.org
Delivered-To: core@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 2571F3A14FB; Tue, 16 Mar 2021 10:34:09 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Linda Dunbar via Datatracker <noreply@ietf.org>
To: <gen-art@ietf.org>
Cc: core@ietf.org, draft-ietf-core-sid.all@ietf.org, last-call@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 7.27.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <161591604910.2184.1526890406711267425@ietfa.amsl.com>
Reply-To: Linda Dunbar <linda.dunbar@futurewei.com>
Date: Tue, 16 Mar 2021 10:34:09 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/core/scWbBHOFtn7YksjD9F3bzksulJY>
Subject: [core] Genart last call review of draft-ietf-core-sid-15
X-BeenThere: core@ietf.org
X-Mailman-Version: 2.1.29
List-Id: "Constrained RESTful Environments \(CoRE\) Working Group list" <core.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/core>, <mailto:core-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/core/>
List-Post: <mailto:core@ietf.org>
List-Help: <mailto:core-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/core>, <mailto:core-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Mar 2021 17:34:09 -0000

Reviewer: Linda Dunbar
Review result: Not Ready

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-core-sid-15
Reviewer: Linda Dunbar
Review Date: 2021-03-16
IETF LC End Date: 2021-03-17
IESG Telechat date: Not scheduled for a telechat

Summary:
This document introduces the globally unique 63-bits integers to identify YANG
items which include data nodes, RPCs, their associated inputs/outputs,
notifications, YANG modules, submodules, and features.

Major issues:
- One of the benefits of YANG is its explicit naming and human-understandable
notations. It will be a nightmare if all the YANG items are represented by
integers. YANG items being represented by integers will be worse than the TYPE
values in the TLVs. At least, the TLV types are in the context of the protocols
and their messages. - It will be a tremendous amount of work to map all YANG
items to globally unique integers. - YANG has been widely deployed without the
numbering system. Which environment will need the integer representations? Who
will validate the numbers used? How to validate the YANG modules represented by
those "integers"?

- SID can be mistaken as Segment Identifiers (SID). Suggest using a different
name.

Minor issues:

Nits/editorial comments:

Best Regards,
Linda Dunbar