Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

Roman Danyliw <rdd@cert.org> Tue, 15 October 2019 20:00 UTC

Return-Path: <rdd@cert.org>
X-Original-To: cose@ietfa.amsl.com
Delivered-To: cose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BF6B712007C for <cose@ietfa.amsl.com>; Tue, 15 Oct 2019 13:00:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.999
X-Spam-Level:
X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f_JZhNw6DLGc for <cose@ietfa.amsl.com>; Tue, 15 Oct 2019 13:00:50 -0700 (PDT)
Received: from taper.sei.cmu.edu (taper.sei.cmu.edu [147.72.252.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AE6C512004A for <cose@ietf.org>; Tue, 15 Oct 2019 13:00:50 -0700 (PDT)
Received: from korb.sei.cmu.edu (korb.sei.cmu.edu [10.64.21.30]) by taper.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x9FK0e3V017381; Tue, 15 Oct 2019 16:00:40 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 taper.sei.cmu.edu x9FK0e3V017381
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1571169640; bh=jc9H7k0JmSpvUBBrX+zLSBBdczzUdOB6EUi8IdjMe7s=; h=From:To:CC:Subject:Date:References:In-Reply-To:From; b=Qje1bpLdScYwoS7nBoRePL6R67FStGz4nmWH/v4Ko2II/JikrHIhQFzUDzRjCEzzK WOt5n81YFQINqxqpaclKtCCoHPIYiqw5SYcVEX9B8ZS6FkZhFBRlpJd8Q2v2udnoDX J/VpH0kqU/Zx/64t5yRSneyyJS+Ng56feIk0ktbo=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by korb.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x9FK0EKa031283; Tue, 15 Oct 2019 16:00:14 -0400
Received: from MARATHON.ad.sei.cmu.edu ([10.64.28.250]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0468.000; Tue, 15 Oct 2019 16:00:14 -0400
From: Roman Danyliw <rdd@cert.org>
To: Russ Housley <housley@vigilsec.com>
CC: Laurence Lundblade <lgl@island-resort.com>, Jim Schaad <ietf@augustcellars.com>, cose <cose@ietf.org>, Ben Kaduk <kaduk@mit.edu>, Ivaylo Petrov <ivaylo@ackl.io>
Thread-Topic: [COSE] AD review of draft-ietf-cose-hash-sig-03
Thread-Index: AQHVf6iqNBNekjPGTxOmdU2BtyuZIKdUwfCAgAAWB4CAAEAeAIAHGoGAgAAq+gD//74yQIAARtCA///EMNA=
Date: Tue, 15 Oct 2019 20:00:13 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC01B3489424@marathon>
References: <157072789599.20442.12089124445445995749.idtracker@ietfa.amsl.com> <67AC8C51-9650-4864-8D42-C10A5D56DAC6@vigilsec.com> <F28D499D-A4F2-410C-8DAA-1E8ED3B977B7@island-resort.com> <000001d57fca$1fbb5630$5f320290$@augustcellars.com> <5752A1CB-FF58-421F-BCF9-BF224BD8CBB7@island-resort.com> <D393B44E-8D98-499C-BAF1-61DE4BB17C3B@island-resort.com> <A7FDD58C-BCF1-4D8C-91E3-F5C93AFD221D@vigilsec.com> <359EC4B99E040048A7131E0F4E113AFC01B34893E9@marathon> <A21C4F33-C973-4DF9-9BB0-82E734B6D353@vigilsec.com>
In-Reply-To: <A21C4F33-C973-4DF9-9BB0-82E734B6D353@vigilsec.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: multipart/alternative; boundary="_000_359EC4B99E040048A7131E0F4E113AFC01B3489424marathon_"
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/cose/JaaNaJKwtyBj60i9etjVld4RlBA>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03
X-BeenThere: cose@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CBOR Object Signing and Encryption <cose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cose>, <mailto:cose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cose/>
List-Post: <mailto:cose@ietf.org>
List-Help: <mailto:cose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cose>, <mailto:cose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 20:00:54 -0000

Hi Russ!

This new text (and timing after the LC) works for me.  Thanks.

Roman

From: Russ Housley [mailto:housley@vigilsec.com]
Sent: Tuesday, October 15, 2019 3:33 PM
To: Roman Danyliw <rdd@cert.org>
Cc: Laurence Lundblade <lgl@island-resort.com>om>; Jim Schaad <ietf@augustcellars.com>om>; cose <cose@ietf.org>rg>; Ben Kaduk <kaduk@mit.edu>du>; Ivaylo Petrov <ivaylo@ackl.io>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

I have added this to the introduction to the Examples:

   This appendix provides a non-normative example ...

I will post it after resolving any other Last Call comments that come along.

Russ



On Oct 15, 2019, at 3:22 PM, Roman Danyliw <rdd@cert.org<mailto:rdd@cert.org>> wrote:


From: COSE [mailto:cose-bounces@ietf.org] On Behalf Of Russ Housley
Sent: Tuesday, October 15, 2019 3:16 PM
To: Laurence Lundblade <lgl@island-resort.com<mailto:lgl@island-resort.com>>
Cc: Roman Danyliw <rdd@cert.org<mailto:rdd@cert.org>>; Jim Schaad <ietf@augustcellars.com<mailto:ietf@augustcellars.com>>; cose <cose@ietf.org<mailto:cose@ietf.org>>; Ben Kaduk <kaduk@mit.edu<mailto:kaduk@mit.edu>>; Ivaylo Petrov <ivaylo@ackl.io<mailto:ivaylo@ackl.io>>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

Laurence:

I'll let Jim respond to the format question, but I think the reference to GitHub in informative,

[Roman] Irrespective of the Sign0 vs. 1 formatting.  This highlights a good point -- I don’t think the text explicitly says these examples are non-normative.  It probably should.

Roman

Russ




On Oct 15, 2019, at 12:41 PM, Laurence Lundblade <lgl@island-resort.com<mailto:lgl@island-resort.com>> wrote:

Hi

Didn’t see any response to this. I also understand bette and can comment more clearly.

I really do think that s/COSE_Sign0/COSE_Sign1/ is necessary for the document to be correct.

I also think the Appendix A examples should be like the examples in RFC 8152 Appendix C. The examples should be just in CBOR diag, not in the JSON-format test framework input format. Is the reference to https://github.com/cose-wg/Examples in the Appendix considered normative?

LL





On Oct 10, 2019, at 9:13 PM, Laurence Lundblade <lgl@island-resort.com<mailto:lgl@island-resort.com>> wrote:

Well I understand better — this is JSON formatted inputs / outputs for a test suite used by COSE-C?

But still…

What is a COSE_Sign0? Everywhere I look, I see it is a deprecated name for a COSE_SIgn1.

Shouldn’t the examples here look like the examples in RFC 8152? Should this use a new style for examples?

LL


On Oct 10, 2019, at 5:23 PM, Jim Schaad <ietf@augustcellars.com<mailto:ietf@augustcellars.com>> wrote:

No that would be the format that I use in the examples with all of the inputs as well.  You should just use the cbor_diag field, and read section 8 of the CBOR draft for how multiple lies are done.

From: COSE <cose-bounces@ietf.org<mailto:cose-bounces@ietf.org>> On Behalf Of Laurence Lundblade
Sent: Thursday, October 10, 2019 4:05 PM
To: Russ Housley <housley@vigilsec.com<mailto:housley@vigilsec.com>>
Cc: Roman D. Danyliw <rdd@cert.org<mailto:rdd@cert.org>>; Ivaylo Petrov <ivaylo@ackl.io<mailto:ivaylo@ackl.io>>; Ben Kaduk <kaduk@mit.edu<mailto:kaduk@mit.edu>>; cose <cose@ietf.org<mailto:cose@ietf.org>>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03


On Oct 10, 2019, at 1:24 PM, Russ Housley <housley@vigilsec.com<mailto:housley@vigilsec.com>> wrote:

  This appendix provides an example of a COSE full message signature
  and an example of a COSE_Sign0 message.  The display format includes
  "\" to indicate that the same field continues on the next line, and it
  includes "|" to separate items within a field.

Doesn’t COSE only have a COSE_Sign1?  COSE_Sign0 is mentioned as wrong in errata.

The example in A.2 doesn’t look like a COSE_Sign1 at all.

LL

_______________________________________________
COSE mailing list
COSE@ietf.org<mailto:COSE@ietf.org>
https://www.ietf.org/mailman/listinfo/cose


_______________________________________________
COSE mailing list
COSE@ietf.org<mailto:COSE@ietf.org>
https://www.ietf.org/mailman/listinfo/cose