Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

Jim Schaad <ietf@augustcellars.com> Tue, 15 October 2019 21:33 UTC

Return-Path: <ietf@augustcellars.com>
X-Original-To: cose@ietfa.amsl.com
Delivered-To: cose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 55A9012080E for <cose@ietfa.amsl.com>; Tue, 15 Oct 2019 14:33:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.899
X-Spam-Level:
X-Spam-Status: No, score=-1.899 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id W6tz2gB67btp for <cose@ietfa.amsl.com>; Tue, 15 Oct 2019 14:32:59 -0700 (PDT)
Received: from mail2.augustcellars.com (augustcellars.com [50.45.239.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D54CA120866 for <cose@ietf.org>; Tue, 15 Oct 2019 14:32:58 -0700 (PDT)
Received: from Jude (192.168.1.159) by mail2.augustcellars.com (192.168.1.201) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 15 Oct 2019 14:32:50 -0700
From: Jim Schaad <ietf@augustcellars.com>
To: 'Roman Danyliw' <rdd@cert.org>, 'Russ Housley' <housley@vigilsec.com>
CC: 'Laurence Lundblade' <lgl@island-resort.com>, 'cose' <cose@ietf.org>, "'Ben Kaduk'" <kaduk@mit.edu>, 'Ivaylo Petrov' <ivaylo@ackl.io>
References: <157072789599.20442.12089124445445995749.idtracker@ietfa.amsl.com> <67AC8C51-9650-4864-8D42-C10A5D56DAC6@vigilsec.com> <F28D499D-A4F2-410C-8DAA-1E8ED3B977B7@island-resort.com> <000001d57fca$1fbb5630$5f320290$@augustcellars.com> <5752A1CB-FF58-421F-BCF9-BF224BD8CBB7@island-resort.com> <D393B44E-8D98-499C-BAF1-61DE4BB17C3B@island-resort.com> <A7FDD58C-BCF1-4D8C-91E3-F5C93AFD221D@vigilsec.com> <359EC4B99E040048A7131E0F4E113AFC01B34893E9@marathon> <A21C4F33-C973-4DF9-9BB0-82E734B6D353@vigilsec.com> <359EC4B99E040048A7131E0F4E113AFC01B3489424@marathon>
In-Reply-To: <359EC4B99E040048A7131E0F4E113AFC01B3489424@marathon>
Date: Tue, 15 Oct 2019 14:32:49 -0700
Message-ID: <021f01d583a0$19d827a0$4d8876e0$@augustcellars.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0220_01D58365.6D7C83F0"
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQH0J6XExm1ebiz8FIK3yuh9o09PmwJBbKINAa21ojQCdiIH0AJqThmlAWEAt9QB3vH3XgIgf82MAh9bQFUC4IWmAaaFcZ7g
Content-Language: en-us
X-Originating-IP: [192.168.1.159]
Archived-At: <https://mailarchive.ietf.org/arch/msg/cose/JlcDjnYyotm41W1AbBSxLtxcePQ>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03
X-BeenThere: cose@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CBOR Object Signing and Encryption <cose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cose>, <mailto:cose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cose/>
List-Post: <mailto:cose@ietf.org>
List-Help: <mailto:cose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cose>, <mailto:cose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2019 21:33:02 -0000

Will take care of the sample after the final assignment of the algorithm identifier by IANA

 

From: Roman Danyliw <rdd@cert.org> 
Sent: Tuesday, October 15, 2019 1:00 PM
To: Russ Housley <housley@vigilsec.com>
Cc: Laurence Lundblade <lgl@island-resort.com>om>; Jim Schaad <ietf@augustcellars.com>om>; cose <cose@ietf.org>rg>; Ben Kaduk <kaduk@mit.edu>du>; Ivaylo Petrov <ivaylo@ackl.io>
Subject: RE: [COSE] AD review of draft-ietf-cose-hash-sig-03

 

Hi Russ!

 

This new text (and timing after the LC) works for me.  Thanks.

 

Roman

 

From: Russ Housley [mailto:housley@vigilsec.com] 
Sent: Tuesday, October 15, 2019 3:33 PM
To: Roman Danyliw <rdd@cert.org <mailto:rdd@cert.org> >
Cc: Laurence Lundblade <lgl@island-resort.com <mailto:lgl@island-resort.com> >; Jim Schaad <ietf@augustcellars.com <mailto:ietf@augustcellars.com> >; cose <cose@ietf.org <mailto:cose@ietf.org> >; Ben Kaduk <kaduk@mit.edu <mailto:kaduk@mit.edu> >; Ivaylo Petrov <ivaylo@ackl.io <mailto:ivaylo@ackl.io> >
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

 

I have added this to the introduction to the Examples:

 

   This appendix provides a non-normative example ...

 

I will post it after resolving any other Last Call comments that come along.

 

Russ

 

 

On Oct 15, 2019, at 3:22 PM, Roman Danyliw <rdd@cert.org <mailto:rdd@cert.org> > wrote:

 

 

From: COSE [ <mailto:cose-bounces@ietf.org> mailto:cose-bounces@ietf.org] On Behalf Of Russ Housley
Sent: Tuesday, October 15, 2019 3:16 PM
To: Laurence Lundblade < <mailto:lgl@island-resort.com> lgl@island-resort.com>
Cc: Roman Danyliw < <mailto:rdd@cert.org> rdd@cert.org>gt;; Jim Schaad < <mailto:ietf@augustcellars.com> ietf@augustcellars.com>gt;; cose < <mailto:cose@ietf.org> cose@ietf.org>gt;; Ben Kaduk < <mailto:kaduk@mit.edu> kaduk@mit.edu>gt;; Ivaylo Petrov < <mailto:ivaylo@ackl.io> ivaylo@ackl.io>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

 

Laurence:

 

I'll let Jim respond to the format question, but I think the reference to GitHub in informative,

 

[Roman] Irrespective of the Sign0 vs. 1 formatting.  This highlights a good point -- I don’t think the text explicitly says these examples are non-normative.  It probably should.

 

Roman

 

Russ

 





On Oct 15, 2019, at 12:41 PM, Laurence Lundblade < <mailto:lgl@island-resort.com> lgl@island-resort.com> wrote:

 

Hi

 

Didn’t see any response to this. I also understand bette and can comment more clearly.

 

I really do think that s/COSE_Sign0/COSE_Sign1/ is necessary for the document to be correct.

 

I also think the Appendix A examples should be like the examples in RFC 8152 Appendix C. The examples should be just in CBOR diag, not in the JSON-format test framework input format. Is the reference to  <https://github.com/cose-wg/Examples> https://github.com/cose-wg/Examples in the Appendix considered normative?

 

LL

 

 





On Oct 10, 2019, at 9:13 PM, Laurence Lundblade < <mailto:lgl@island-resort.com> lgl@island-resort.com> wrote:

 

Well I understand better — this is JSON formatted inputs / outputs for a test suite used by COSE-C?

 

But still…

 

What is a COSE_Sign0? Everywhere I look, I see it is a deprecated name for a COSE_SIgn1.

 

Shouldn’t the examples here look like the examples in RFC 8152? Should this use a new style for examples?

 

LL

 

 

On Oct 10, 2019, at 5:23 PM, Jim Schaad < <mailto:ietf@augustcellars.com> ietf@augustcellars.com> wrote:

 

No that would be the format that I use in the examples with all of the inputs as well.  You should just use the cbor_diag field, and read section 8 of the CBOR draft for how multiple lies are done.

 

From: COSE < <mailto:cose-bounces@ietf.org> cose-bounces@ietf.org> On Behalf Of Laurence Lundblade
Sent: Thursday, October 10, 2019 4:05 PM
To: Russ Housley < <mailto:housley@vigilsec.com> housley@vigilsec.com>
Cc: Roman D. Danyliw < <mailto:rdd@cert.org> rdd@cert.org>gt;; Ivaylo Petrov < <mailto:ivaylo@ackl.io> ivaylo@ackl.io>gt;; Ben Kaduk < <mailto:kaduk@mit.edu> kaduk@mit.edu>gt;; cose < <mailto:cose@ietf.org> cose@ietf.org>
Subject: Re: [COSE] AD review of draft-ietf-cose-hash-sig-03

 

 

On Oct 10, 2019, at 1:24 PM, Russ Housley < <mailto:housley@vigilsec.com> housley@vigilsec.com> wrote:

 

  This appendix provides an example of a COSE full message signature
  and an example of a COSE_Sign0 message.  The display format includes
  "\" to indicate that the same field continues on the next line, and it
  includes "|" to separate items within a field.

 

Doesn’t COSE only have a COSE_Sign1?  COSE_Sign0 is mentioned as wrong in errata.

 

The example in A.2 doesn’t look like a COSE_Sign1 at all.

 

LL

 

_______________________________________________
COSE mailing list
 <mailto:COSE@ietf.org> COSE@ietf.org
 <https://www.ietf.org/mailman/listinfo/cose> https://www.ietf.org/mailman/listinfo/cose

 

 

_______________________________________________
COSE mailing list
 <mailto:COSE@ietf.org> COSE@ietf.org
 <https://www.ietf.org/mailman/listinfo/cose> https://www.ietf.org/mailman/listinfo/cose