[COSE] AD Review of draft-ietf-cose-hash-sig-03

Roman Danyliw <rdd@cert.org> Thu, 10 October 2019 17:17 UTC

Return-Path: <rdd@cert.org>
X-Original-To: cose@ietfa.amsl.com
Delivered-To: cose@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CE614120116 for <cose@ietfa.amsl.com>; Thu, 10 Oct 2019 10:17:34 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=cert.org
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id L8sl09eFCG1Z for <cose@ietfa.amsl.com>; Thu, 10 Oct 2019 10:17:33 -0700 (PDT)
Received: from veto.sei.cmu.edu (veto.sei.cmu.edu [147.72.252.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 34D17120113 for <cose@ietf.org>; Thu, 10 Oct 2019 10:17:33 -0700 (PDT)
Received: from delp.sei.cmu.edu (delp.sei.cmu.edu [10.64.21.31]) by veto.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x9AHHS2f026800 for <cose@ietf.org>; Thu, 10 Oct 2019 13:17:29 -0400
DKIM-Filter: OpenDKIM Filter v2.11.0 veto.sei.cmu.edu x9AHHS2f026800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cert.org; s=yc2bmwvrj62m; t=1570727849; bh=+RIpN3AoyC+K75TKTCfmZieD9KCQPUQ68XOlb7eIepE=; h=From:To:Subject:Date:From; b=eVDGvQBLjyzz2TIAfdE36NACDNrMKQNqxrPEZlJnPMeKhgHXi3US7FQHihaZDxFVt CFCN2NDn2RKn+e7zUN3T2i+HFzgVnpoATNTFpEv2TfehSwJrOTWudk4i+LlfX6Llxs QmQQvu3oB+dR2FhwrrBye1S1Yj2hsGl3uJWszCmM=
Received: from CASSINA.ad.sei.cmu.edu (cassina.ad.sei.cmu.edu [10.64.28.249]) by delp.sei.cmu.edu (8.14.7/8.14.7) with ESMTP id x9AHHP5s026255 for <cose@ietf.org>; Thu, 10 Oct 2019 13:17:25 -0400
Received: from MARATHON.ad.sei.cmu.edu ([10.64.28.250]) by CASSINA.ad.sei.cmu.edu ([10.64.28.249]) with mapi id 14.03.0468.000; Thu, 10 Oct 2019 13:17:25 -0400
From: Roman Danyliw <rdd@cert.org>
To: "cose@ietf.org" <cose@ietf.org>
Thread-Topic: AD Review of draft-ietf-cose-hash-sig-03
Thread-Index: AdV/jjO+NBNekjPGTxOmdU2BtyuZIA==
Date: Thu, 10 Oct 2019 17:17:25 +0000
Message-ID: <359EC4B99E040048A7131E0F4E113AFC01B348271C@marathon>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.64.22.6]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/cose/LO5i8er--pj7DK0llDKlXtNP7fg>
Subject: [COSE] AD Review of draft-ietf-cose-hash-sig-03
X-BeenThere: cose@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: CBOR Object Signing and Encryption <cose.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/cose>, <mailto:cose-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/cose/>
List-Post: <mailto:cose@ietf.org>
List-Help: <mailto:cose-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/cose>, <mailto:cose-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Oct 2019 17:17:35 -0000

Hi!

The following is my AD review of draft-ietf-cose-hash-sig-03:

** Section 3.  Per "The signature value is a large byte string.  The byte string is designed for easy parsing, and it includes a counter and type codes that indirectly provide all of the information that is needed to parse the byte string during signature validation."
-- please propagate the clarifying edits of the form made on the related sentence of Section 3.0 in draft-ietf-lamps-cms-hash-sig (to clarify the exact parameters in the byte string and where this byte string is defined)

-- the examples in Appendix A seem to imply a particular formatting (e.g., using the | to separate parameters), this should be clarified in this text

 ** This draft (COSE) and draft-ietf-lamps-cms-hash-sig (CMS) share common text.  A number of changes were made to draft-lamps-cms-hash-sig in response to AD feedback and the IESG review (version -09 and -10).  Please propagate these changes (where they are appropriate):

-- Abstract and Section 1.  Expand "HSS/LMS".

-- from CMS Section 1.0 to COSE Section 1.0

-- from CMS Section 1.3 to COSE Section 1.1

-- from CMS Section 2.0 to COSE Section 2.0

-- from CMS Section 2.1 to COSE Section 2.1

-- from CMS Section 2.2 to COSE Section 2.2

-- from CMS Section 2.3 to COSE Section 2.3

-- from CMS Section 6.0 to COSE Section 6.0

Regards,
Roman