Re: [Crypto-panel] Request for document review: draft-dolmatov-magma

Russ Housley <housley@vigilsec.com> Wed, 16 October 2019 19:49 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: crypto-panel@ietfa.amsl.com
Delivered-To: crypto-panel@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id AECFA120831 for <crypto-panel@ietfa.amsl.com>; Wed, 16 Oct 2019 12:49:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.896
X-Spam-Level:
X-Spam-Status: No, score=-1.896 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oKYY5SYktQ1t for <crypto-panel@ietfa.amsl.com>; Wed, 16 Oct 2019 12:49:57 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90094120805 for <crypto-panel@irtf.org>; Wed, 16 Oct 2019 12:49:57 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id E799E300B1F for <crypto-panel@irtf.org>; Wed, 16 Oct 2019 15:49:55 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kbUdedojo09V for <crypto-panel@irtf.org>; Wed, 16 Oct 2019 15:49:54 -0400 (EDT)
Received: from a860b60074bd.fios-router.home (unknown [138.88.156.37]) by mail.smeinc.net (Postfix) with ESMTPSA id D5DFF300A31; Wed, 16 Oct 2019 15:49:53 -0400 (EDT)
From: Russ Housley <housley@vigilsec.com>
Message-Id: <332EAEFC-F99F-40F1-BFAA-D11C193F9B93@vigilsec.com>
Content-Type: multipart/alternative; boundary="Apple-Mail=_2F04F42F-5A46-4899-B4BB-EE86F51B7C1C"
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Date: Wed, 16 Oct 2019 15:49:54 -0400
In-Reply-To: <537ceb97-7902-1b51-b517-b51a0215dab8@isode.com>
Cc: "crypto-panel@irtf.org" <crypto-panel@irtf.org>, Adrian Farrel <rfc-ise@rfc-editor.org>
To: Alexey Melnikov <alexey.melnikov@isode.com>
References: <537ceb97-7902-1b51-b517-b51a0215dab8@isode.com>
X-Mailer: Apple Mail (2.3445.104.11)
Archived-At: <https://mailarchive.ietf.org/arch/msg/crypto-panel/iHhVN1Y6LXqHi7SZkmGK6HfXQ1k>
Subject: Re: [Crypto-panel] Request for document review: draft-dolmatov-magma
X-BeenThere: crypto-panel@irtf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: <crypto-panel.irtf.org>
List-Unsubscribe: <https://www.irtf.org/mailman/options/crypto-panel>, <mailto:crypto-panel-request@irtf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/crypto-panel/>
List-Post: <mailto:crypto-panel@irtf.org>
List-Help: <mailto:crypto-panel-request@irtf.org?subject=help>
List-Subscribe: <https://www.irtf.org/mailman/listinfo/crypto-panel>, <mailto:crypto-panel-request@irtf.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2019 19:50:12 -0000

I do not see any obvious problems, but I did not try to write code ...

I do not understand Section 4; I cannot figure out why it is in a
document that describes the Magma block cipher.

Section 3.2 says:

   A<<<_11  cyclic rotation of string A belonging to V_32 by 11
      components in the direction of components having greater indices

Since components are enumerated from right to left starting from zero,
can't this be greatly simplified by saying "left cyclic rotation".
Also, a comma is missing at the end of the definition.

Russ

> On Oct 16, 2019, at 3:44 PM, Alexey Melnikov <alexey.melnikov@isode.com> wrote:
> 
> Dear Crypto Review Panel members,
> 
> Independent Stream Editor has asked for review of:
> 
>  https://datatracker.ietf.org/doc/draft-dolmatov-magma/ <https://datatracker.ietf.org/doc/draft-dolmatov-magma/>
> in particular he wants to know:
> 
> 1)  can the document be unambiguously implemented
> 
> and
> 
> 2) whether there are any obvious security holes that should be noted as caveats
> 
> 
> 
> Thank you,
> 
> Alexey
> 
> _______________________________________________
> Crypto-panel mailing list
> Crypto-panel@irtf.org
> https://www.irtf.org/mailman/listinfo/crypto-panel