Re: [Curdle] Adam Roach's No Objection on draft-ietf-curdle-cms-eddsa-signatures-07: (with COMMENT)

Russ Housley <housley@vigilsec.com> Wed, 11 October 2017 22:40 UTC

Return-Path: <housley@vigilsec.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 192FC132C3F for <curdle@ietfa.amsl.com>; Wed, 11 Oct 2017 15:40:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=unavailable autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xIXdJE3ERtvx for <curdle@ietfa.amsl.com>; Wed, 11 Oct 2017 15:40:55 -0700 (PDT)
Received: from mail.smeinc.net (mail.smeinc.net [209.135.209.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 406671326DF for <curdle@ietf.org>; Wed, 11 Oct 2017 15:40:54 -0700 (PDT)
Received: from localhost (localhost [127.0.0.1]) by mail.smeinc.net (Postfix) with ESMTP id 715D13005C6 for <curdle@ietf.org>; Wed, 11 Oct 2017 18:40:53 -0400 (EDT)
X-Virus-Scanned: amavisd-new at mail.smeinc.net
Received: from mail.smeinc.net ([127.0.0.1]) by localhost (mail.smeinc.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id g_GCiOA750xJ for <curdle@ietf.org>; Wed, 11 Oct 2017 18:40:51 -0400 (EDT)
Received: from a860b60074bd.home (pool-108-45-101-150.washdc.fios.verizon.net [108.45.101.150]) by mail.smeinc.net (Postfix) with ESMTPSA id A1D92300265; Wed, 11 Oct 2017 18:40:51 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
From: Russ Housley <housley@vigilsec.com>
In-Reply-To: <150767748641.24759.5760552454791266636.idtracker@ietfa.amsl.com>
Date: Wed, 11 Oct 2017 18:40:51 -0400
Cc: IESG <iesg@ietf.org>, Daniel Migault <daniel.migault@ericsson.com>, curdle <curdle@ietf.org>, curdle-chairs <curdle-chairs@ietf.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7ED70645-3F34-4B7C-AC53-A7CACCFBC6D8@vigilsec.com>
References: <150767748641.24759.5760552454791266636.idtracker@ietfa.amsl.com>
To: Adam Roach <adam@nostrum.com>
X-Mailer: Apple Mail (2.3273)
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/3mgJ-onzqgXBxVxODqVDqPPPNjg>
Subject: Re: [Curdle] Adam Roach's No Objection on draft-ietf-curdle-cms-eddsa-signatures-07: (with COMMENT)
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2017 22:40:56 -0000

Thanks for the careful review.  I have made the changes described below in my edit buffer.


> ----------------------------------------------------------------------
> COMMENT:
> ----------------------------------------------------------------------
> 
> Section 1.2:
> 
>   CMS values are generated using ASN.1 [X680], which uses the Basic
>   Encoding Rules (BER) and the Distinguished Encoding Rules (DER)
>   [X690].
> 
> Recommend:
> 
>   CMS values are generated using ASN.1 [X680], using the Basic
>   Encoding Rules (BER) and the Distinguished Encoding Rules (DER)
>   [X690].
> 
> (Rationale: ASN.1 has many more encodings than this, and the original phrasing
> implies that these are the only two.)

I suggest:

   CMS values are generated using ASN.1 [X680] with the Basic
   Encoding Rules (BER) and the Distinguished Encoding Rules (DER)
   [X690].

> I'm a little surprised that there are no citations for Curve25519, Curve488,
> and "Schnorr's signature system." If it is realistic add citations for these, I
> believe it would be an improvement.

I added two informative references:

   [CURVE25519]
              Bernstein, D., "Curve25519: new Diffie-Hellman speed
              records", DOI 10.1007/11745853_14, February 2006,
              <http://cr.yp.to/ecdh.html>.

   [CURVE448] Hamburg, M., "Ed448-Goldilocks, a new elliptic curve",
              June 2015, <http://eprint.iacr.org/2015/625>.

Russ