Re: [Curdle] AD Review of draft-ietf-curdle-gss-keyex-sha2-05

[Hubert Kario <[e-mail]>]

On Tuesday, 29 May 2018 21:27:34 CEST Eric Rescorla wrote:
> On Mon, May 21, 2018 at 10:27 AM, Simo Sorce <[e-mail]> wrote:
> > On Fri, 2018-05-18 at 14:12 -0700, Eric Rescorla wrote:
> > > These changes look fine, though they only address some of my comments.
> > 
> > Just for clarity, is the change to describe the whole DH exchange in
> > one place what you see missing ? Is that a deal breaker ?
> > Anything else ?
> 
> That and the repeated text that is the same for each group.

the fix for repeated text about groups is already merged to master, for ECDHE: 
https://github.com/simo5/ietf/blob/eb03480d5c49e7340302e4974435f382ba26a911/
draft-ietf-curdle-gss-keyex-sha2.xml#L537-L553
and for FFDHE:
https://github.com/simo5/ietf/blob/eb03480d5c49e7340302e4974435f382ba26a911/
draft-ietf-curdle-gss-keyex-sha2.xml#L148-L164

> I'm not sure it's a dealbreaker, but it's a real point of concern for me.
> Is there
> strong WG consensus to retain the current structure, or is this just what
> happens
> to be there.
> 
> -Ekr
> 
> > Simo.
> > 
> > > On Tue, May 1, 2018 at 12:08 PM, Simo Sorce <[e-mail]> wrote:
> > > > On Wed, 2018-04-25 at 12:55 -0700, Eric Rescorla wrote:
> > > > > On Wed, Apr 25, 2018 at 11:53 AM, Hubert Kario <[e-mail]>
> > > > 
> > > > wrote:
> > > > > > I think you're misunderstanding me. My point is that there are
> > 
> > already
> > 
> > > > > > > documents
> > > > > > > which describe how to generate the private and public keys for
> > 
> > EC.
> > 
> > > > You
> > > > 
> > > > > > > should
> > > > > > > be referring to them, not recapitulating their contents here.
> > > > > > 
> > > > > > proposed in https://github.com/simo5/ietf/pull/24
> > > > > 
> > > > > I will review this.
> > > > 
> > > > Hi Eric,
> > > > did you have time to look at this ?
> > > > Or do you prefer to get a new draft with these changes ?
> > > > 
> > > > Simo.


-- 
Regards,
Hubert Kario
Senior Quality Engineer, QE BaseOS Security team
Web: www.cz.redhat.com
Red Hat Czech s.r.o., Purkyňova 115, 612 00  Brno, Czech Republic