[Curdle] Genart last call review of draft-ietf-curdle-cms-ecdh-new-curves-07

Roni Even <ron.even.tlv@gmail.com> Thu, 25 May 2017 10:57 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: curdle@ietf.org
Delivered-To: curdle@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id B41F012946B; Thu, 25 May 2017 03:57:16 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Roni Even <ron.even.tlv@gmail.com>
To: gen-art@ietf.org
Cc: draft-ietf-curdle-cms-ecdh-new-curves.all@ietf.org, curdle@ietf.org, ietf@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 6.51.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <149570983670.8681.5001417855088402577@ietfa.amsl.com>
Date: Thu, 25 May 2017 03:57:16 -0700
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/RWUjbd-SSv7D2QCyJgLcUZAtNbA>
Subject: [Curdle] Genart last call review of draft-ietf-curdle-cms-ecdh-new-curves-07
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2017 10:57:17 -0000

Reviewer: Roni Even
Review result: Ready with Nits

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-curdle-cms-ecdh-new-curves-??
Reviewer: Roni Even
Review Date: 2017-05-25
IETF LC End Date: 2017-05-28
IESG Telechat date: Not scheduled for a telechat

Summary:
The document is ready for publication as a standard track RFC

Major issues:

Minor issues:

Nits/editorial comments: 

In general it was easy to read and follow.  Maybe it will be good to
repeat in section 3.2 the definition of KeyAgreeRecipientInfo . This
is done is section 2 for ECC-CMS-SharedInfo but it is not crucial.

1. There is no ToC
2. In section 2.2 fourth paragraph "is used two places" - "in two .."