Re: [Curdle] new AD review comments on draft-ietf-curdle-ssh-ed25519-ed448-08

denis bider <denisbider.ietf@gmail.com> Wed, 31 July 2019 23:19 UTC

Return-Path: <denisbider.ietf@gmail.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 607AA1200FF; Wed, 31 Jul 2019 16:19:25 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.998
X-Spam-Level:
X-Spam-Status: No, score=-1.998 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZX_FURgbyWxI; Wed, 31 Jul 2019 16:19:22 -0700 (PDT)
Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9CE4F1200B5; Wed, 31 Jul 2019 16:19:22 -0700 (PDT)
Received: by mail-ot1-x32b.google.com with SMTP id j19so33556525otq.2; Wed, 31 Jul 2019 16:19:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=norOYDFxH4s130tMUIr7lDyXoiLCe3qOkzQ6jahv2Cc=; b=aRJk05xLmiUCutD73Oq0+dBti5ljnqXREVAOcv4iJ+pBphgwtiaF2Sg27En9Uil9m4 QWx5gQxg7m5sXrfHPaAXfPXnjfu+S3i0AZVg0XwB7nvx/Wd6dGJmkKTBzKqSPgoaWMHp CI5MGZOpApbIP7i00epM9bvsvAr+5Had1C6AXvMIGydHbT2AM5TMHqbyOqey4Q9qJV6+ a7qJa22wPYtswa9Ed6eRqcpNITTWY9/nmae20RaOmDNwaPh+UEOVB/VSK+d6fJbHqBA8 Jq4rDdTaZzHwfcrDI9mOhIUUpPPDmT42sSmen7xzYa8aHlsuna1yHDyRys6NE0gzfC14 fvYw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=norOYDFxH4s130tMUIr7lDyXoiLCe3qOkzQ6jahv2Cc=; b=ZwGB8qdWaZvrZSK3dPLoYpqxE3tdxNMcMAKv2dXMsfwZB5nYY3YmTff4R3+J1BgyP0 QZZV/zhhu659Y+cCcoz1wsOLx6Tj9hofkyQKe78MatIdBuFlEDKPPPl26BpyJRV4kLaQ ALx0U0Vfrnv7ImlmYWiek1YBKDDeTqPKjmBmHg/hAshQo/OEXgHP+ZNBXefS0ajO7Pfu BvdsxMrAU0QNB6fk4r6VaGrFdwrh/spS1nQnzy9XHcREgcQ2CAAz4qI63Rku9IDlYNSX b0ning0a9z0/mCjCeEyVyp+QzdoJx85SqMez6SWZv+q/k26NckAWbTnVnDzMk20ysBWw Y2fw==
X-Gm-Message-State: APjAAAUdbQgd8ThqwKEZoXRQPD5rickid4QxmXiRvpFRhgxyfjx+SsCr HS6lN5j/DMGSw2a+qtcLcjkH+q5ZoqKF+pobPJY=
X-Google-Smtp-Source: APXvYqyLPDMCkZCLAXELj/UeMr+3ONJvOyHCNHl7aDocjhM6anvNVCx52vdl6fK1AvHeY7B+qdQ3dykBtNK9D9tbpPk=
X-Received: by 2002:a05:6830:13d9:: with SMTP id e25mr62246444otq.197.1564615161938; Wed, 31 Jul 2019 16:19:21 -0700 (PDT)
MIME-Version: 1.0
References: <20190604174029.GC8678@prolepsis.kaduk.org> <DM6PR15MB3531AACEA6B575BBACAFD413E3160@DM6PR15MB3531.namprd15.prod.outlook.com> <CAOp4FwTKAW+vkEbsYTPUVUSB6ve2=uTGiTKwQUB0trZ981MTWw@mail.gmail.com> <DM6PR15MB3531792B7CB48B7E08D67E2CE3170@DM6PR15MB3531.namprd15.prod.outlook.com> <20190607222610.GH83686@kduck.mit.edu> <20190730213418.GQ47715@kduck.mit.edu> <CAOp4FwR+MqeJFzxdzXYq1L3_sQEM2i2M1Z2LpK1TCPw3Hq_-tA@mail.gmail.com>
In-Reply-To: <CAOp4FwR+MqeJFzxdzXYq1L3_sQEM2i2M1Z2LpK1TCPw3Hq_-tA@mail.gmail.com>
From: denis bider <denisbider.ietf@gmail.com>
Date: Wed, 31 Jul 2019 18:19:10 -0500
Message-ID: <CADPMZDADX-s6bvnuRy+Wq1iKmSLmSQa+pgQVWvx63B=MzV7EjQ@mail.gmail.com>
To: Loganaden Velvindron <loganaden@gmail.com>
Cc: Benjamin Kaduk <kaduk@mit.edu>, "draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org" <draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org>, Daniel Migault <daniel.migault@ericsson.com>, "curdle@ietf.org" <curdle@ietf.org>, bjh21@bjh21.me.uk
Content-Type: multipart/alternative; boundary="000000000000f00711058f025aab"
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/jel2BZU8YEDUHeFH-NSgpJQRJbQ>
Subject: Re: [Curdle] new AD review comments on draft-ietf-curdle-ssh-ed25519-ed448-08
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jul 2019 23:19:26 -0000

> I would suggest standards track given that ed25519
> is already public key is already implemented by OpenSSH.

Just to confirm, there are other implementations too.

For example, Ed25519 was introduced in Bitvise SSH Server and SSH Client in
versions 7.21 (released end of 2016):

https://www.bitvise.com/ssh-server-version-history-7

denis


On Wed, Jul 31, 2019 at 1:34 AM Loganaden Velvindron <loganaden@gmail.com>
wrote:

> On Wed, Jul 31, 2019 at 1:34 AM Benjamin Kaduk <kaduk@mit.edu> wrote:
> >
> > Cycling back on this, my reading of the archive suggests that we want an
> > -09 to include Daniel's suggested text to clarify on (1), and we need to
> > hear from Ben about (3).
> >
> > Does that sound right to everyone or am I missing something?
> >
> I would suggest standards track given that ed25519 is already public key is
> already implemented by OpenSSH.
>
> http://www.openssh.com/txt/release-6.5
>
> > Thanks,
> >
> > Ben
> >
> > On Fri, Jun 07, 2019 at 05:26:11PM -0500, Benjamin Kaduk wrote:
> > > On Thu, Jun 06, 2019 at 02:56:46PM +0000, Daniel Migault wrote:
> > > > This is correct, for some reasons I reviewed version 07. So version
> 08 is solving the opsdir issue. I will close the thread on the mailing list.
> > >
> > > Ah, thank you.  Thanks also to Loganaden for the updates in the -08,
> and
> > > sorry for not having confirmed that they did address the opsdir review
> > > comment.
> > >
> > > > The SSHF Record includes the algorithm used for the public key, the
> type of the fingerprint. The current draft only adds a registry for the
> algorithm. I believe the confusion might be that the current text  seems to
> indicate some additional changes for example in the generation of the
> finger print.  Maybe the text below around the following lines clarifies
> the purpose of the changes.
> > >
> > > That seems likely.
> > >
> > > > If so, the only remaining point is the IPR declaration.
> > >
> > > [adding Ben to the To: list to try to answer this question.]
> > >
> > > -Ben
> > >
> > > > OLD:
> > > > The generation of SSHFP resource records for "ssh-ed25519" keys is
> > > >    described in [RFC7479].
> > > >
> > > >    The generation of SSHFP resource records for "ssh-ed448" keys is
> > > >    described as follows.
> > > >
> > > >    the SSHFP Resource Record for the Ed448 public key with SHA-256
> > > >    fingerprint would be example be:
> > > >
> > > >    example.com.  IN SSHFP TBD 2 ( a87f1b687ac0e57d2a081a2f2826723
> > > >    34d90ed316d2b818ca9580ea384d924 01 )
> > > >
> > > >    The 2 here indicates SHA-256 [RFC6594].
> > > >
> > > > NEW:
> > > >
> > > > The generation of SSHFP resource records for "ssh-ed25519" keys is
> > > >    described in [RFC7479].
> > > >
> > > > The SSHFP resource records for "ssh-ed448" keys is generated
> similarly,
> > > > with the algorithm field indicating a Ed448 public key.
> > > >
> > > > The SSHFP Resource Record for the Ed448 public key with SHA-256
> > > > fingerprint would be example be:
> > > >
> > > > example.com.  IN SSHFP TBD 2 ( a87f1b687ac0e57d2a081a2f2826723
> > > > 34d90ed316d2b818ca9580ea384d924 01 )
> > > >
> > > > The 2 here indicates SHA-256 [RFC6594].
> > > >
> > > > From: Loganaden Velvindron <loganaden@gmail.com>
> > > > Sent: Thursday, June 06, 2019 3:02 AM
> > > > To: Daniel Migault <daniel.migault@ericsson.com>
> > > > Cc: Benjamin Kaduk <kaduk@mit.edu>;
> draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org; curdle@ietf.org
> > > > Subject: Re: new AD review comments on
> draft-ietf-curdle-ssh-ed25519-ed448-08
> > > >
> > > > I already published rev08 to address those issues:
> > > >
> https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-curdle-ssh-ed25519-ed448-08.txt
> > > >
> > > > On Wed, Jun 5, 2019 at 5:52 PM Daniel Migault <
> daniel.migault@ericsson.com<mailto:daniel.migault@ericsson.com>> wrote:
> > > > Thanks Ben for the follow-up, please see my responses inline for (2)
> and (4). I believe a version 08 is needed to address (1) and (2).
> > > > Yours,
> > > > Daniel
> > > >
> > > > -----Original Message-----
> > > > From: Benjamin Kaduk <kaduk@mit.edu<mailto:kaduk@mit.edu>>
> > > > Sent: Tuesday, June 04, 2019 1:41 PM
> > > > To: draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org<mailto:
> draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org>
> > > > Cc: curdle@ietf.org<mailto:curdle@ietf.org>
> > > > Subject: new AD review comments on
> draft-ietf-curdle-ssh-ed25519-ed448-08
> > > >
> > > > Hi all,
> > > >
> > > > I'm just about ready to send this to the IESG, but there seems to be
> a few things to fix, first:
> > > >
> > > > (1) In Section 8 we say "The generation of SSHFP resource records
> for "ssh-ed448" keys is described as follows." but then give only an
> example and not a description of what to do.  We need to say more about
> this procedure
> > > >
> > > > (2) I'm not sure if the chain on the opsdir review got fully
> resolved; see
> https://mailarchive.ietf.org/arch/msg/curdle/DZc2Sr19zJ71nnC3pSIF0uPhaCk
> > > > <mglt>
> > > > The current version has not accordingly been updated.
> > > > </mglt>
> > > >
> > > > (3) The shepherd writeup says that Ben did not confirm IPR
> (non)disclosure per BCPs 78 and 79 -- Ben, can you please do so now?
> > > >
> > > > (4) Daniel, can you please update the shepherd writeup to reflect
> the discussions with the directorate reviewers about document status?  I'm
> sure that some IESG members will ask "why not Informational?" if we don't
> forestall them.
> > > >
> > > > <mglt>
> > > > I have update the shepherd as follows:
> > > >
> > > > (1) What type of RFC is being requested (BCP, Proposed Standard,
> > > > Internet Standard, Informational, Experimental, or Historic)?  Why
> > > > is this the proper type of RFC?  Is this type of RFC indicated in the
> > > > title page header?
> > > >
> > > > The requested status is Standard Track. This is necessary for
> > > > inter-operability  and as such the Standard Track seems the
> > > > most appropriated status.
> > > >
> > > > The OPS Directorate wondered why version 07 was a Standard Track
> > > > document and not an informational document as no normative 2119
> words.
> > > >
> > > > The reason for being a standard track is that we expect the
> implementation
> > > > that implement SSH to follow these recommendations. The consensus was
> > > > to explicitly mention it in the document around the lines:
> > > >
> > > > "Standard implementations of SSH SHOULD implement these signature
> algorithms."
> > > > </mglt>
> > > > Thanks,
> > > >
> > > > Ben
>
> _______________________________________________
> Curdle mailing list
> Curdle@ietf.org
> https://www.ietf.org/mailman/listinfo/curdle
>