[Curdle] AD Review: draft-ietf-curdle-cms-eddsa-signatures-05.txt

Eric Rescorla <ekr@rtfm.com> Fri, 05 May 2017 20:14 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1A442128799 for <curdle@ietfa.amsl.com>; Fri, 5 May 2017 13:14:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.599
X-Spam-Level:
X-Spam-Status: No, score=-2.599 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=rtfm-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id knxWDU0ZhO5Y for <curdle@ietfa.amsl.com>; Fri, 5 May 2017 13:14:08 -0700 (PDT)
Received: from mail-yw0-x229.google.com (mail-yw0-x229.google.com [IPv6:2607:f8b0:4002:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF0EC12869B for <curdle@ietf.org>; Fri, 5 May 2017 13:14:07 -0700 (PDT)
Received: by mail-yw0-x229.google.com with SMTP id k11so8140647ywb.1 for <curdle@ietf.org>; Fri, 05 May 2017 13:14:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rtfm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to; bh=ZmwSYEB2N3HN5u53vsU89pVHpY8VxlO8wBOmkVPJTeE=; b=kuH2Cn9hsdDvt5FqL5pHOK0cDHP3DR2yJNhFkBJXo/qgFQVCIMWo9kWYqPfFMLfE+O CwwERaANhBKs9AQQbsday26zBcYYxMFryr82xUlO+dryxDtdbyKiRhZ5r5k4t/ipYqLr cz7z6VahAHhGttQab2efrYzyNv60erM82Ss6ihYDFNVKpTJjz9Wl7zHKTePK0jvJxtP4 TgWa0lnU6fmTl3WhQS4jj3yF/+oEs5xDhYLnl+lL1GXSNWPl6fGi7QZ88CoLokI3Pvxt s7H++YHAn6fCka+GZlDuX2JU1jhuXu9Asj8EsembqL7ngp6sfIMTEEaeuc0EOtwxO4SS lmqA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZmwSYEB2N3HN5u53vsU89pVHpY8VxlO8wBOmkVPJTeE=; b=VQPrq+4LFWTH3HYoX4Fxx37UD92s/kunF+KPO2kRCvDv2dZVVJpUY+IeC1W7L/p9H5 AfchB2RYK4LV3HOQwTLXMi4ojFCGa5RHqDZabetkzoP6TuLht0Nvonou0eqspp3b2KHA T83hcDedAv6uKwaAs3xaIIoeOWRd5f0Hr5sC6aJ8Mfee5ynMdEYp1NhlUnIx9JCJsKfi wfAjEiMyTMQaNeD1exn2u+PHRG79W3j7bah+hzl5YJMonfbmM0smKOJLU3LxiqLqm/uw Bn4qwrLlpEZtN9Pl39v1yxrJPZR89JEaS0qE8ks8fgSljAwjSiwIWNHDtfBe1OHmp+6u tqQg==
X-Gm-Message-State: AN3rC/4xK9YJEJntO7+PYRoBnOMK9PlbR3nxNrTO1FBL3moMjkcHA18G nONoATdeWNTjgQKarukVCiMtkbV82jd0baM=
X-Received: by 10.129.146.78 with SMTP id j75mr14028624ywg.3.1494015246884; Fri, 05 May 2017 13:14:06 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.129.131.150 with HTTP; Fri, 5 May 2017 13:13:26 -0700 (PDT)
From: Eric Rescorla <ekr@rtfm.com>
Date: Fri, 05 May 2017 13:13:26 -0700
Message-ID: <CABcZeBMRYwdQnxUuBrCEsM-BeTFfARg3ZFn=tWh+5FMdv2WGYw@mail.gmail.com>
To: curdle <curdle@ietf.org>
Content-Type: multipart/alternative; boundary="94eb2c09350414ea9e054ecc8892"
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/mfZxHsoxc9Hm-EuSqSQ9hzh7rSA>
Subject: [Curdle] AD Review: draft-ietf-curdle-cms-eddsa-signatures-05.txt
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 05 May 2017 20:14:09 -0000

TECHNICAL
S 3.1 and 3.2.
- The text here I think means "you can provide this hash and
  if you do the parameters field of the hash MUST be absent".
  Is that correct?

- Is there some reason to not prescribe exactly one form here?
  I.e., require id-sha512 (etc.) or require it not be there?

- Also, TLS has converged on talking about an "identity" hash
  for the PureEd forms. Was this discussed and rejected?


EDITORIAL
RFC 7748 uses "curveXXX" not "CurveXXX"

S 2.1
   Each algorithms are identified by an object identifier, and the
   algorithm identifier may contain parameters if needed.

Each algorithm is


S 2.4.
Please note that || means "concatenation"