Re: [Curdle] new AD review comments on draft-ietf-curdle-ssh-ed25519-ed448-08

Daniel Migault <daniel.migault@ericsson.com> Tue, 30 July 2019 23:57 UTC

Return-Path: <mglt.ietf@gmail.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CCF2A1200A4; Tue, 30 Jul 2019 16:57:48 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.557
X-Spam-Level:
X-Spam-Status: No, score=-1.557 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.091, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3OdjiXv3DYpH; Tue, 30 Jul 2019 16:57:46 -0700 (PDT)
Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com [209.85.222.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 18C5912004E; Tue, 30 Jul 2019 16:57:46 -0700 (PDT)
Received: by mail-ua1-f44.google.com with SMTP id j21so26271855uap.2; Tue, 30 Jul 2019 16:57:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gzvF0JAe5uTse8ZJl7fmPVvBuktPU3CKTR7mOvwmcRE=; b=qeipEpEZJxq/ys76I8bZbfHaCjIC8b3PLleO70igGG2kK1LrKfmDy6IWyRAmvf9j8m F38+sb4AeXomhT/uV5LF0FGHoMFYEqaVBxS3UdUUF2J+DeEdZCXAHFGDfK63gT10OjxV 85zqTIe2/25UWwu22BXIG3eNFS0+VM38d1Hq7S66ulBLwU0EudieBcAbio9UuQsv76EL Wdk6lEUYNhShILgQtqolSanBBGe+4Xf0vCkPTVecJsC1ed/opZYfx604e2SS1/vO24DN WrMAV4kc3BIGoMCGNj66PNvqZHHeLSNTHPgrkuFFpIXtWHPTnVwqpBa/oMY8eE0l2t3e XBfg==
X-Gm-Message-State: APjAAAWMNo3PsaztRWWjGkhkYMMnMt5tYcSLYoJBdePp95ZJC09fpnfu eTxpDsKc2ezOO6NucZU0WFDMV/B9l6XpLjmcynQ=
X-Google-Smtp-Source: APXvYqxuWO3L2isMUmyP+tsDOktLU/uPUJFeENZ7CCNx33O2lBwT12TrYCsf/PEr/GtzpZPaxraJ4VdDnjsVKbv1dRU=
X-Received: by 2002:ab0:70ab:: with SMTP id q11mr21649806ual.88.1564531065135; Tue, 30 Jul 2019 16:57:45 -0700 (PDT)
MIME-Version: 1.0
References: <20190604174029.GC8678@prolepsis.kaduk.org> <DM6PR15MB3531AACEA6B575BBACAFD413E3160@DM6PR15MB3531.namprd15.prod.outlook.com> <CAOp4FwTKAW+vkEbsYTPUVUSB6ve2=uTGiTKwQUB0trZ981MTWw@mail.gmail.com> <DM6PR15MB3531792B7CB48B7E08D67E2CE3170@DM6PR15MB3531.namprd15.prod.outlook.com> <20190607222610.GH83686@kduck.mit.edu> <20190730213418.GQ47715@kduck.mit.edu>
In-Reply-To: <20190730213418.GQ47715@kduck.mit.edu>
From: Daniel Migault <daniel.migault@ericsson.com>
Date: Tue, 30 Jul 2019 19:57:34 -0400
Message-ID: <CADZyTknHZ8-EvAxBAU0Ga_ifSmLZBWSKEFo22mK=y_1iULMyGQ@mail.gmail.com>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: bjh21@bjh21.me.uk, Loganaden Velvindron <loganaden@gmail.com>, "draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org" <draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org>, "curdle@ietf.org" <curdle@ietf.org>
Content-Type: multipart/alternative; boundary="00000000000060c808058eeec63d"
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/mjzl4-oUOdJ1ElSOvtbnAIOuH00>
Subject: Re: [Curdle] new AD review comments on draft-ietf-curdle-ssh-ed25519-ed448-08
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Jul 2019 23:57:49 -0000

Hi,

I believe that is all we need to do.

Yours,
Daniel

On Tue, Jul 30, 2019 at 5:34 PM Benjamin Kaduk <kaduk@mit.edu> wrote:

> Cycling back on this, my reading of the archive suggests that we want an
> -09 to include Daniel's suggested text to clarify on (1), and we need to
> hear from Ben about (3).
>
> Does that sound right to everyone or am I missing something?
>
> Thanks,
>
> Ben
>
> On Fri, Jun 07, 2019 at 05:26:11PM -0500, Benjamin Kaduk wrote:
> > On Thu, Jun 06, 2019 at 02:56:46PM +0000, Daniel Migault wrote:
> > > This is correct, for some reasons I reviewed version 07. So version 08
> is solving the opsdir issue. I will close the thread on the mailing list.
> >
> > Ah, thank you.  Thanks also to Loganaden for the updates in the -08, and
> > sorry for not having confirmed that they did address the opsdir review
> > comment.
> >
> > > The SSHF Record includes the algorithm used for the public key, the
> type of the fingerprint. The current draft only adds a registry for the
> algorithm. I believe the confusion might be that the current text  seems to
> indicate some additional changes for example in the generation of the
> finger print.  Maybe the text below around the following lines clarifies
> the purpose of the changes.
> >
> > That seems likely.
> >
> > > If so, the only remaining point is the IPR declaration.
> >
> > [adding Ben to the To: list to try to answer this question.]
> >
> > -Ben
> >
> > > OLD:
> > > The generation of SSHFP resource records for "ssh-ed25519" keys is
> > >    described in [RFC7479].
> > >
> > >    The generation of SSHFP resource records for "ssh-ed448" keys is
> > >    described as follows.
> > >
> > >    the SSHFP Resource Record for the Ed448 public key with SHA-256
> > >    fingerprint would be example be:
> > >
> > >    example.com.  IN SSHFP TBD 2 ( a87f1b687ac0e57d2a081a2f2826723
> > >    34d90ed316d2b818ca9580ea384d924 01 )
> > >
> > >    The 2 here indicates SHA-256 [RFC6594].
> > >
> > > NEW:
> > >
> > > The generation of SSHFP resource records for "ssh-ed25519" keys is
> > >    described in [RFC7479].
> > >
> > > The SSHFP resource records for "ssh-ed448" keys is generated similarly,
> > > with the algorithm field indicating a Ed448 public key.
> > >
> > > The SSHFP Resource Record for the Ed448 public key with SHA-256
> > > fingerprint would be example be:
> > >
> > > example.com.  IN SSHFP TBD 2 ( a87f1b687ac0e57d2a081a2f2826723
> > > 34d90ed316d2b818ca9580ea384d924 01 )
> > >
> > > The 2 here indicates SHA-256 [RFC6594].
> > >
> > > From: Loganaden Velvindron <loganaden@gmail.com>
> > > Sent: Thursday, June 06, 2019 3:02 AM
> > > To: Daniel Migault <daniel.migault@ericsson.com>
> > > Cc: Benjamin Kaduk <kaduk@mit.edu>;
> draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org; curdle@ietf.org
> > > Subject: Re: new AD review comments on
> draft-ietf-curdle-ssh-ed25519-ed448-08
> > >
> > > I already published rev08 to address those issues:
> > >
> https://tools.ietf.org/rfcdiff?difftype=--hwdiff&url2=draft-ietf-curdle-ssh-ed25519-ed448-08.txt
> > >
> > > On Wed, Jun 5, 2019 at 5:52 PM Daniel Migault <
> daniel.migault@ericsson.com<mailto:daniel.migault@ericsson.com>> wrote:
> > > Thanks Ben for the follow-up, please see my responses inline for (2)
> and (4). I believe a version 08 is needed to address (1) and (2).
> > > Yours,
> > > Daniel
> > >
> > > -----Original Message-----
> > > From: Benjamin Kaduk <kaduk@mit.edu<mailto:kaduk@mit.edu>>
> > > Sent: Tuesday, June 04, 2019 1:41 PM
> > > To: draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org<mailto:
> draft-ietf-curdle-ssh-ed25519-ed448.all@ietf.org>
> > > Cc: curdle@ietf.org<mailto:curdle@ietf.org>
> > > Subject: new AD review comments on
> draft-ietf-curdle-ssh-ed25519-ed448-08
> > >
> > > Hi all,
> > >
> > > I'm just about ready to send this to the IESG, but there seems to be a
> few things to fix, first:
> > >
> > > (1) In Section 8 we say "The generation of SSHFP resource records for
> "ssh-ed448" keys is described as follows." but then give only an example
> and not a description of what to do.  We need to say more about this
> procedure
> > >
> > > (2) I'm not sure if the chain on the opsdir review got fully resolved;
> see
> https://mailarchive.ietf.org/arch/msg/curdle/DZc2Sr19zJ71nnC3pSIF0uPhaCk
> > > <mglt>
> > > The current version has not accordingly been updated.
> > > </mglt>
> > >
> > > (3) The shepherd writeup says that Ben did not confirm IPR
> (non)disclosure per BCPs 78 and 79 -- Ben, can you please do so now?
> > >
> > > (4) Daniel, can you please update the shepherd writeup to reflect the
> discussions with the directorate reviewers about document status?  I'm sure
> that some IESG members will ask "why not Informational?" if we don't
> forestall them.
> > >
> > > <mglt>
> > > I have update the shepherd as follows:
> > >
> > > (1) What type of RFC is being requested (BCP, Proposed Standard,
> > > Internet Standard, Informational, Experimental, or Historic)?  Why
> > > is this the proper type of RFC?  Is this type of RFC indicated in the
> > > title page header?
> > >
> > > The requested status is Standard Track. This is necessary for
> > > inter-operability  and as such the Standard Track seems the
> > > most appropriated status.
> > >
> > > The OPS Directorate wondered why version 07 was a Standard Track
> > > document and not an informational document as no normative 2119 words.
> > >
> > > The reason for being a standard track is that we expect the
> implementation
> > > that implement SSH to follow these recommendations. The consensus was
> > > to explicitly mention it in the document around the lines:
> > >
> > > "Standard implementations of SSH SHOULD implement these signature
> algorithms."
> > > </mglt>
> > > Thanks,
> > >
> > > Ben
>