Re: [Curdle] AD Review of draft-ietf-curdle-gss-keyex-sha2-05

Eric Rescorla <ekr@rtfm.com> Tue, 29 May 2018 19:28 UTC

Return-Path: <ekr@rtfm.com>
X-Original-To: curdle@ietfa.amsl.com
Delivered-To: curdle@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B141512E8A9 for <curdle@ietfa.amsl.com>; Tue, 29 May 2018 12:28:17 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.608
X-Spam-Level:
X-Spam-Status: No, score=-2.608 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, T_DKIMWL_WL_MED=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=rtfm-com.20150623.gappssmtp.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P_U3-HlcSuQx for <curdle@ietfa.amsl.com>; Tue, 29 May 2018 12:28:15 -0700 (PDT)
Received: from mail-oi0-x22b.google.com (mail-oi0-x22b.google.com [IPv6:2607:f8b0:4003:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6377112EBD5 for <curdle@ietf.org>; Tue, 29 May 2018 12:28:15 -0700 (PDT)
Received: by mail-oi0-x22b.google.com with SMTP id t22-v6so10707176oih.6 for <curdle@ietf.org>; Tue, 29 May 2018 12:28:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rtfm-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=EqYIHWXBIRSWQ0di3+S9tnshSrSIlYRkim2jc8v0Knk=; b=IDwvmOa0da3My1bYXA+TNwiLWlmIOyHAWWEcN0DupvDEW33kCNK2Aov7mjrDHeMO5s m1AeuRE+ZBHnI+R1NwBuRTMS+TDVsruUlKeTSsM0ynxzL3FC+oZvP2KQpbDmr5f0L0A1 DZtiXcmUnbnqqPMvlEeHOeI2H51RcfeEYMP+BboP+9Am88vF/6oUh1s9F2TiqYf1RKqg 4SwhK45pNayu5A137MX5L0rUEjUJt0Ody2mnANvHMR/MCdxLhsgpRd0EgZae3JCXcdX/ G4WTfr1wPBPUtiZlfrrpZVqP3lDQ92KzgEJ/iMhD5kp+98lUqttWcD1l/nY+fLIsn4Pr rKQQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=EqYIHWXBIRSWQ0di3+S9tnshSrSIlYRkim2jc8v0Knk=; b=tbazU9ECXOZixCsRHrT8D7bhTVAJ8Icw/SiRBJB4FLDETJmxdZUyoSvULtpF8PDV8E BO7AeOtebzE/SghL3ORVUU3IlkbQjy4Q3kRhrWnpo/xa5faNWZO7Obazxs/ACfimqeTz 8ZncsdvL8AfgunbdPxpifAOpfJJC6lyUW+PxzRjHpjybRZ7vcF1TU42wKeOUPg+FiLF4 kGjXrB7aUI2gXTzkAajfFj9UZiTmltqdcaVdSESHywa/qUV5ZCKVUCEkZTOJjGubhMR8 MN7Y0yXkHPNogOXbD5CyTGKlWCnkfg5rvcDwxiQRhZWeYOJLUhgW+n55+KTwvaAZ2xEa aRcw==
X-Gm-Message-State: ALKqPwdUzIjWpZTFm7DS5r7Y4ZqHjuKj4cQZviO82clZCtq8oLgPq3RU DbiIa6tR9zm3fWr7x75t0hI1j1F88LCENlT8v38wSA==
X-Google-Smtp-Source: ADUXVKIJZWo93rB2Fj/6v4s4qo1msF0kQhonk2JzSSfwWNO6BdjP1cAIqPrLv8IQIhrtIEq8TLLfNqmLrp3U6ivxXus=
X-Received: by 2002:aca:4f0d:: with SMTP id d13-v6mr300315oib.138.1527622094729; Tue, 29 May 2018 12:28:14 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:ac9:66:0:0:0:0:0 with HTTP; Tue, 29 May 2018 12:27:34 -0700 (PDT)
In-Reply-To: <1526923646.10011.43.camel@redhat.com>
References: <CABcZeBNCUSpGihHz6bPBSALS4-34Tm7W36BCZ_Ev8OQz3KtVag@mail.gmail.com> <1555475.KUsr8aTfev@pintsize.usersys.redhat.com> <CABcZeBP5LRFuH37166YMiXKce-GgJhnji_msYMrac=eQ531AMQ@mail.gmail.com> <3446969.zDdGGYQIsg@pintsize.usersys.redhat.com> <CABcZeBPeNGVy51uz78dk2REYKG8yugFvB3XdZ5PBLLFnrALTRA@mail.gmail.com> <1525201687.32101.39.camel@redhat.com> <CABcZeBOnQDS=+Uz+Ue-6ytP+bu13+PfKhAmCHqna6C858jrymg@mail.gmail.com> <1526923646.10011.43.camel@redhat.com>
From: Eric Rescorla <ekr@rtfm.com>
Date: Tue, 29 May 2018 12:27:34 -0700
Message-ID: <CABcZeBO9fhkjcfqomnmyY8YJw93u9t7B=QC05aDGBwGgAOpd_w@mail.gmail.com>
To: Simo Sorce <ssorce@redhat.com>
Cc: Hubert Kario <hkario@redhat.com>, curdle <curdle@ietf.org>
Content-Type: multipart/alternative; boundary="0000000000004eca10056d5d3c88"
Archived-At: <https://mailarchive.ietf.org/arch/msg/curdle/rq_HkEC3VRfxHK6rgNauwdtxjOc>
Subject: Re: [Curdle] AD Review of draft-ietf-curdle-gss-keyex-sha2-05
X-BeenThere: curdle@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: "List for discussion of potential new security area wg." <curdle.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/curdle>, <mailto:curdle-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/curdle/>
List-Post: <mailto:curdle@ietf.org>
List-Help: <mailto:curdle-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/curdle>, <mailto:curdle-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 29 May 2018 19:28:18 -0000

On Mon, May 21, 2018 at 10:27 AM, Simo Sorce <ssorce@redhat.com> wrote:

> On Fri, 2018-05-18 at 14:12 -0700, Eric Rescorla wrote:
> > These changes look fine, though they only address some of my comments.
>
> Just for clarity, is the change to describe the whole DH exchange in
> one place what you see missing ? Is that a deal breaker ?
> Anything else ?
>

That and the repeated text that is the same for each group.

I'm not sure it's a dealbreaker, but it's a real point of concern for me.
Is there
strong WG consensus to retain the current structure, or is this just what
happens
to be there.

-Ekr


> Simo.
>
> > On Tue, May 1, 2018 at 12:08 PM, Simo Sorce <ssorce@redhat.com> wrote:
> >
> > > On Wed, 2018-04-25 at 12:55 -0700, Eric Rescorla wrote:
> > > > On Wed, Apr 25, 2018 at 11:53 AM, Hubert Kario <hkario@redhat.com>
> > >
> > > wrote:
> > > >
> > > > > I think you're misunderstanding me. My point is that there are
> already
> > > > > > documents
> > > > > > which describe how to generate the private and public keys for
> EC.
> > >
> > > You
> > > > > > should
> > > > > > be referring to them, not recapitulating their contents here.
> > > > >
> > > > > proposed in https://github.com/simo5/ietf/pull/24
> > > >
> > > >
> > > > I will review this.
> > >
> > > Hi Eric,
> > > did you have time to look at this ?
> > > Or do you prefer to get a new draft with these changes ?
> > >
> > > Simo.
> > >
> > >
> > >
>