Re: [Dcrup] [taugh.com-standards] Benjamin Kaduk's No Objection on draft-ietf-dcrup-dkim-crypto-13: (with COMMENT)

"John R. Levine" <johnl@iecc.com> Sat, 16 June 2018 19:07 UTC

Return-Path: <johnl@iecc.com>
X-Original-To: dcrup@ietfa.amsl.com
Delivered-To: dcrup@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62D81130E3D for <dcrup@ietfa.amsl.com>; Sat, 16 Jun 2018 12:07:54 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=unavailable autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1536-bit key) header.d=iecc.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8nfsnGFDX-o2 for <dcrup@ietfa.amsl.com>; Sat, 16 Jun 2018 12:07:52 -0700 (PDT)
Received: from gal.iecc.com (gal.iecc.com [IPv6:2001:470:1f07:1126:0:43:6f73:7461]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A71D124D68 for <dcrup@ietf.org>; Sat, 16 Jun 2018 12:07:52 -0700 (PDT)
Received: (qmail 8595 invoked from network); 16 Jun 2018 19:01:10 -0000
DKIM-Signature: v=1; a=rsa-sha256; c=simple; d=iecc.com; h=date:message-id:from:to:cc:subject:in-reply-to:references:mime-version:content-type:user-agent; s=218f.5b255e76.k1806; bh=wkCUH5oTm522AoeG4sdjEGcxYj+ngtgOBbu6wHiukWA=; b=lysSSK11uLv2gjP0uVi3SesNkYOGDbn0Zxv6ji7N3C7W6mi2TfUCcySL9FdpEhW6WeAzP1D+Q/0/nD8ufS2WUHctf8yPjzm6ziBZqP2jWxmwc6LVW7e4OPQYzPsryHJw1N0pqyOJlUp8+TBviEHnN9KCbyIA81EOcgQEGlelaxA4Ku9qJb9edhl3ZIDlVlicJQrs0/hc9plx42z4dBf/DlnW1YV3L/KrmO1XqmhMaVjY3gp0WB6YS+6XlNUE5CCt
Received: from localhost ([IPv6:2001:470:1f07:1126::78:696d:6170]) by imap.iecc.com ([IPv6:2001:470:1f07:1126::78:696d:6170]) with ESMTPS (TLS1.2/X.509/AEAD) via TCP6; 16 Jun 2018 19:01:10 -0000
Date: Sat, 16 Jun 2018 15:01:09 -0400
Message-ID: <alpine.OSX.2.21.1806161448290.10727@ary.qy>
From: "John R. Levine" <johnl@iecc.com>
To: Benjamin Kaduk <kaduk@mit.edu>
Cc: The IESG <iesg@ietf.org>, dcrup-chairs@ietf.org, fenton@bluepopcorn.net, dcrup@ietf.org
In-Reply-To: <20180616182747.GX64971@kduck.kaduk.org>
References: <152916023988.6185.8096866196786504366.idtracker@ietfa.amsl.com> <alpine.OSX.2.21.1806161055500.9832@ary.qy> <20180616182747.GX64971@kduck.kaduk.org>
User-Agent: Alpine 2.21 (OSX 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"; format="flowed"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dcrup/ZvsuIjVuKayZvbX_wUIGeWflrxw>
Subject: Re: [Dcrup] [taugh.com-standards] Benjamin Kaduk's No Objection on draft-ietf-dcrup-dkim-crypto-13: (with COMMENT)
X-BeenThere: dcrup@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: DKIM Crypto Update <dcrup.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dcrup>, <mailto:dcrup-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dcrup/>
List-Post: <mailto:dcrup@ietf.org>
List-Help: <mailto:dcrup-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dcrup>, <mailto:dcrup-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 16 Jun 2018 19:07:55 -0000

> % I believe the [FIPS-180-4-2015] reference should be replaced with a
> % reference to RFC-6376
>
> Still relevant.  (This is the citation for SHA-256; we generally
> prefer IETF references to external references.)

RFC 6376 is the DKIM spec that we are updating.  It uses SHA-256 and 
defines it by referring to the FIPS document.  I suppose I could change it 
to "see RFC6376 reference FIPS-180-3-2008" but that seems cruel, and would 
miss the fact that 180-3 has been updated since 6376 was published.

> % Remove or indicate the RFC Editor should remove the following text:
> %
> %       Discussion Venue:    Discussion about this draft is directed to the
> %       dcrup@ietf.org [1] mailing list.
>
> Still relevant.

Sorry, relevant to what?  Surely you're not saying that the staff in the 
RPC don't know to remove this kind of stuff as they turn drafts into RFCs.

> % This sentence doesn't parse easily:
> %
> %      This is an additional DKIM signature algorithm added to Section 3.3
> %    of [RFC6376] as envisioned in Section 3.3.4 of [RFC6376].
> %
> % It should simply say something like "This document adds an
> % additional key algorithm type to the DKIM Key Type Registry and a
> % new signature type to the DKIM Hash Algorithms Registry"
>
> Still relevant, though AFAICT only the Key Type Registry is
> impacted.

Having rewritten that sentence several times to get WG consensus, I am not 
inclined to mess with it unless it is wrong, which I am reasonbly sure it 
is not.

> % Section 4 and 8 have an introductory lines that says "update as
> % follows" followed by a dot instead of a colon. That is a little
> % confusing to the reader, as if some text is missing before the dot.
>
> Still relevant (though I guess I would prefer "as described in the
> following sections" to using a colon).

Copyediting nit, the RPC will make it match whatever the style is.

> suggested changes, it's really unclear what conclusion to draw when
> the review is met with a curtain of silence.

I already wrote back to Paul, didn't realize I needed to tell the entire 
IETF.

Regards,
John Levine, johnl@iecc.com, Primary Perpetrator of "The Internet for Dummies",
Please consider the environment before reading this e-mail. https://jl.ly

PS: if I sound crabby, my defense is that today is Porchfest in my village 
and I've been hearing to my neighbors play bad folk music for the past 
three hours.