Re: [Dcrup] [Gen-art] Genart last call review of draft-ietf-dcrup-dkim-crypto-12

Alissa Cooper <alissa@cooperw.in> Wed, 20 June 2018 19:00 UTC

Return-Path: <alissa@cooperw.in>
X-Original-To: dcrup@ietfa.amsl.com
Delivered-To: dcrup@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6EA0C1311C3; Wed, 20 Jun 2018 12:00:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.701
X-Spam-Level:
X-Spam-Status: No, score=-2.701 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=cooperw.in header.b=yp09zSVn; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=rHNByLnD
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3sbV9Y2jJtmq; Wed, 20 Jun 2018 12:00:39 -0700 (PDT)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 63C8D13124D; Wed, 20 Jun 2018 12:00:34 -0700 (PDT)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B40F321D34; Wed, 20 Jun 2018 15:00:33 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 20 Jun 2018 15:00:33 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cooperw.in; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=CzhuiMAlDPjMyT/uhd03DDznHkbkh +ZlFNrF3WToGEk=; b=yp09zSVno6kE3NhpUT6HG7es4PvpfV/fTut1L8m4ZCSdy m6+rgv0P7wmygey5KUa52d0zOK86fJzOHUhXFf9Ct7gASmrhkaLqt2rdb/PtFhy+ MTM1xXcxOhEboPrBH9kFNLGuFS5cbLLrTCbU5ktD/oEhAO9lHhs1xvYeloT3oXry LgfX0UGZVajeQFrZqpZQKO3u0XEFI8DMei3Ow+nYKq+NaeD4nayNu4KvsB/O48Xw xEGIITvPFniGc/rRyceeOwgc0SbFxiil/xb9NTQZDfTxI+sIHyHWD7MN+xcA2t9g 0dAMxdK6ZoDrMutZ8WQqAc0ONXWTl8nVgnPpOPYAQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=CzhuiM AlDPjMyT/uhd03DDznHkbkh+ZlFNrF3WToGEk=; b=rHNByLnD8o5aZj6yqeDE2S l58Ukas27FHe+1gZ93ZT9OjTaXEcZafrrKR4O9d+SBz53ylh6LwmCkwPT1hRQJW4 QM6G1Q2PVgkGqrrTQzj5FHcOJolYeU44AFr1ld/hx8W68kTBvxhLjfbZp1A/X5JV OZINj02FDeR/W3kdOI1A8rF58+5AMSBXg9zJu7rSr2Jq1WHEKPHemCRtw04mFM43 jHvYFs8awZWpby9SSdgCM3Y+DsJlP4BWSvTV3xbu7Qslq7tCA1dXXlamHV7WX745 tjEYj43+rc3CqFiDo1XJJgkp0MAbZgN/U74PfM/pDhxAJT5jF64pyml3AP7g79nw ==
X-ME-Proxy: <xmx:UaQqW07gFgJLvEiVUcbF4D6HA1HCSzMO8GscUwqkaDQYinzSPoLLJQ> <xmx:UaQqW2RciieJXKS3yiNt7CZEiKDDf73bby4DyZPT5yqzhcaNTHYIwQ> <xmx:UaQqW7X0CwjZNCfoKZmw0TpG32hsf1QctDBkN8-5QE8Kq5JvNrLKFA> <xmx:UaQqW22vuuwVMvNnLq0jSJ6viisggbUDRAgqTKWMgZ8hv2BJWde83g> <xmx:UaQqW-CV1gsC0Oj9rTpQKDEoSDinzfHmSaBROnXFJmuzohoHhN5v0Q> <xmx:UaQqW33XCUUIdoiDjt7oBfN0dyXKc8Pcw1AMGRq_rPyBcglPKao2bw>
X-ME-Sender: <xms:UaQqW76cioCZHvPdg-Ni6VxhsDHUD2ELa5K5n9GMgz2ADXvtxvG84Q>
Received: from rtp-alcoop-nitro2.cisco.com (unknown [173.38.117.75]) by mail.messagingengine.com (Postfix) with ESMTPA id 2211410273; Wed, 20 Jun 2018 15:00:33 -0400 (EDT)
Content-Type: text/plain; charset="us-ascii"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
From: Alissa Cooper <alissa@cooperw.in>
In-Reply-To: <152873414342.2872.16681801090252484956@ietfa.amsl.com>
Date: Wed, 20 Jun 2018 15:00:32 -0400
Cc: General Area Review Team <gen-art@ietf.org>, dcrup@ietf.org, draft-ietf-dcrup-dkim-crypto.all@ietf.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <1C53D9C5-490D-4494-860F-C5DF50B181C9@cooperw.in>
References: <152873414342.2872.16681801090252484956@ietfa.amsl.com>
To: Pete Resnick <presnick@qti.qualcomm.com>
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/dcrup/lmdQFPbySFN3E0aa4Ay0D2JO08c>
Subject: Re: [Dcrup] [Gen-art] Genart last call review of draft-ietf-dcrup-dkim-crypto-12
X-BeenThere: dcrup@ietf.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: DKIM Crypto Update <dcrup.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dcrup>, <mailto:dcrup-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dcrup/>
List-Post: <mailto:dcrup@ietf.org>
List-Help: <mailto:dcrup-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dcrup>, <mailto:dcrup-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Jun 2018 19:00:55 -0000

Pete, thanks for your review. I think the whole point of chartering DCRUP was to produce documents such as this.

John, thanks for updating to reference RFC 8174, although I agree with Adam that the boilerplate should match 8174.

Thanks,
Alissa

> On Jun 11, 2018, at 12:22 PM, Pete Resnick <presnick@qti.qualcomm.com> wrote:
> 
> Reviewer: Pete Resnick
> Review result: Ready with Nits
> 
> I am the assigned Gen-ART reviewer for this draft. The General Area
> Review Team (Gen-ART) reviews all IETF documents being processed
> by the IESG for the IETF Chair.  Please treat these comments just
> like any other last call comments.
> 
> For more information, please see the FAQ at
> 
> <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.
> 
> Document: draft-ietf-dcrup-dkim-crypto-12
> Reviewer: Pete Resnick
> Review Date: 2018-06-11
> IETF LC End Date: 2018-06-12
> IESG Telechat date: 2018-06-21
> 
> Summary: Nice simple document; Ready to go with nits.
> 
> Major issues:
> 
> None.
> 
> Minor issues:
> 
> None.
> 
> Nits/editorial comments:
> 
> Nit: You should update the 2119 template to the 8174 template.
> 
> Comment: If this kind of update is only going to happen every 6 or 7 years, I
> guess it's fine, but all that this document really does is: - Trivially update
> the ABNF - Add the algorithm to the registry - Update the normative
> instructions to indicate that this new algorithm be used. That really could
> have all be done with a registry update if the registry had a field for
> normative instructions for use of the algorithm. I suppose it's no longer a big
> deal to add one more document to the eight-odd-thousand RFCs, but still...
> 
> pr
> 
> _______________________________________________
> Gen-art mailing list
> Gen-art@ietf.org
> https://www.ietf.org/mailman/listinfo/gen-art