Re: [Dcrup] I-D Action: draft-ietf-dcrup-dkim-usage-02.txt

Martin Thomson <martin.thomson@gmail.com> Sat, 10 June 2017 09:42 UTC

Return-Path: <martin.thomson@gmail.com>
X-Original-To: dcrup@ietfa.amsl.com
Delivered-To: dcrup@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D28C11201F2; Sat, 10 Jun 2017 02:42:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.7
X-Spam-Level:
X-Spam-Status: No, score=-2.7 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HshM-7TxpZX4; Sat, 10 Jun 2017 02:42:37 -0700 (PDT)
Received: from mail-lf0-x22b.google.com (mail-lf0-x22b.google.com [IPv6:2a00:1450:4010:c07::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9B0AB126D46; Sat, 10 Jun 2017 02:42:36 -0700 (PDT)
Received: by mail-lf0-x22b.google.com with SMTP id v20so37124858lfa.1; Sat, 10 Jun 2017 02:42:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U/XPBijQCZaMgpIeuXwnknSlXEGscb3oFTyVYZTV1NQ=; b=OaNT2wEf8N3veG+u00DscE/f/rnP3AySvIgQl1W//XIFJbl86CnwZ9zAeRql3KN5TU 2NWbDXU3zS5EDAaqcg2c7E+mCd6n2bV3N3VbSJIy3aj9eynqVOSGxScPgCGCl3+vl6IE CYlphMklvGwpBoGndfOK99tJKCoOsIMXS5xHLb7Z2/2Y2tCCRGmpwXropr7V+d6bS3mI YirfWODf+WB+foEyq8ki/pkFCxYvCr5H3CYrXS9z8CVfxlVzkmaO1TPTbNOcL0OIdGwe LS5s7wu1Y3kRelgjI2MgCGr+/rKmqKyGUaciSKMobqbQ8me89WsDyYAIlRg4sW4Y+fqI iROw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U/XPBijQCZaMgpIeuXwnknSlXEGscb3oFTyVYZTV1NQ=; b=t/EqULTLf3ut097V4Zd5ufAG3FCXMLdthi6ABR+IfEGCXOJdyWc4JpGGxTZT81yQAU Pj/1tO4mQ7SfNDb3vvHyzDP9C8jjLbTW3o8Ud600jOxT+vew9a7FKT5W9akdqZKmPfN6 qHXkqYIR8m7kw2DVsQT9QYdZOUrP6pwfhf3NCYlaqejV6hYXB/9oDg55Pelfh/grM+Fr BlgFTcUj1d1SptU1wgZqeumMiMsUCx4XfwPIAfUfgjgjRnm1kjPtyoqp+ebkBcEcDzQl Eld5pkfU4xF7kUg4SKiAvBVLv8B+3gjkYVWPV34eWOAso5jMDmuNSPQqn9U9UbfZs6wk E5NA==
X-Gm-Message-State: AODbwcATKajOat5WC9CKKr8kLwovIr/XMOmqdZ1uEipM/4p4pSZ2s9Ki suBXoiIZU00bQZbu2sz/WakgmcPIQZYgPFo=
X-Received: by 10.46.77.196 with SMTP id c65mr10887192ljd.113.1497087754687; Sat, 10 Jun 2017 02:42:34 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.46.8.66 with HTTP; Sat, 10 Jun 2017 02:42:34 -0700 (PDT)
In-Reply-To: <149690083334.25644.8501543904193079634@ietfa.amsl.com>
References: <149690083334.25644.8501543904193079634@ietfa.amsl.com>
From: Martin Thomson <martin.thomson@gmail.com>
Date: Sat, 10 Jun 2017 10:42:34 +0100
Message-ID: <CABkgnnWdaecFqcVMSNYy8F7Z1_ijYG9-Vt2cw+AHoedziRXHDA@mail.gmail.com>
To: internet-drafts@ietf.org
Cc: i-d-announce@ietf.org, dcrup@ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: <https://mailarchive.ietf.org/arch/msg/dcrup/uqrXt403FD6qxxGCsdcBG94ybXo>
Subject: Re: [Dcrup] I-D Action: draft-ietf-dcrup-dkim-usage-02.txt
X-BeenThere: dcrup@ietf.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: DKIM Crypto Update <dcrup.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/dcrup>, <mailto:dcrup-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/dcrup/>
List-Post: <mailto:dcrup@ietf.org>
List-Help: <mailto:dcrup-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/dcrup>, <mailto:dcrup-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 10 Jun 2017 09:42:39 -0000

I find the construction of this draft strange.  Why not simply say
"verifiers MUST implement and use rsa-sha256 instead of rsa-sha1"?
The remainder of the text is largely unchanged, which took me a while
to validate.

The problem here is that removing the definition of rsa-sha1 is not
the point.  The code point can't be undefined (Section 7 gets that
right), and we don't really benefit from having the definition
removed.  What we want is to have rsa-sha256 implemented and deployed.

So say two things, just to be perfectly clear:

1. DKIM implementations MUST NOT rely on rsa-sha1, it's busted.

2. DKIM implementations MUST use rsa-sha256.  Signers MUST create
signatures using rsa-sha256 and verifiers MUST verify those
signatures.

I disagree with John about the publication of this draft without the
new schemes.  It's worth doing now and the extra overheads of
publication are small.

Nits:

Section 3, two errors here:

> One algorithms, rsa-sha256, is currenlty defined.

Section 3.2 s/,/ / here:

> DKIM,[RFC6376]

Section 6 has an extra period.

Collapse Section 7.1 into Section 7:

"""
IANA is requested to update the "sha1" registration in the "DKIM Hash
Algorithms" as follows:
<table>
"""





On 8 June 2017 at 06:47,  <internet-drafts@ietf.org> wrote:
>
> A New Internet-Draft is available from the on-line Internet-Drafts directories.
> This draft is a work item of the DKIM Crypto Update of the IETF.
>
>         Title           : Cryptographic Algorithm and Key Usage Update to DKIM
>         Author          : Scott Kitterman
>         Filename        : draft-ietf-dcrup-dkim-usage-02.txt
>         Pages           : 6
>         Date            : 2017-06-07
>
> Abstract:
>    The cryptographic algorithm and key size requirements included when
>    DKIM was designed in the last decade are functionally obsolete and in
>    need of immediate revision.  This document updates DKIM requirements
>    to those minimaly suitable for operation with currently specified
>    algorithms.  This document updates RFC 6376.
>
>
> The IETF datatracker status page for this draft is:
> https://datatracker.ietf.org/doc/draft-ietf-dcrup-dkim-usage/
>
> There are also htmlized versions available at:
> https://tools.ietf.org/html/draft-ietf-dcrup-dkim-usage-02
> https://datatracker.ietf.org/doc/html/draft-ietf-dcrup-dkim-usage-02
>
> A diff from the previous version is available at:
> https://www.ietf.org/rfcdiff?url2=draft-ietf-dcrup-dkim-usage-02
>
>
> Please note that it may take a couple of minutes from the time of submission
> until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> Dcrup mailing list
> Dcrup@ietf.org
> https://www.ietf.org/mailman/listinfo/dcrup