Re: [Detnet] Genart last call review of draft-ietf-detnet-mpls-over-udp-ip-06

Balázs Varga A <balazs.a.varga@ericsson.com> Thu, 01 October 2020 12:52 UTC

Return-Path: <balazs.a.varga@ericsson.com>
X-Original-To: detnet@ietfa.amsl.com
Delivered-To: detnet@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0B1B33A0FB0; Thu, 1 Oct 2020 05:52:04 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.301
X-Spam-Level:
X-Spam-Status: No, score=-3.301 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PFABRhzpmQ1b; Thu, 1 Oct 2020 05:52:02 -0700 (PDT)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00042.outbound.protection.outlook.com [40.107.0.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DED823A0F7C; Thu, 1 Oct 2020 05:52:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a105JlehJw5jnO+DYuDfrfVgvvmzL8M9qqVO8hYoc8OAl+WQ7Lix2yDdxS8sqzXuoDx5O0oPqzJXB6jTveIqnpEBVxI3Qlq4wb4/AjbQ4fmtTjFyKVfZVDpFHZusXRa76GFz/mn7fYktwNhr6WteZOLGleLpHGSPFoMKdCEhxK0IbgKFZXsrfIT2I3EDxHjD4KPe1SfymSc2kKZDvnRGzHz5CfMq6aF5dCMc8WPA1j4W66ZHezazCmKbBVofANQtHc+gO3oecyDiKpIIuBBpcXaZUxM45SveU2BgOPH6KkLaiQ/p+zavJojvlqi7UpXK1kJvUpkydtQxv1IW852K9g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r0//JEnn0CQTtZMqxg9REN+Q0UP92sNV3V3oSaIsanY=; b=C2mTAqcY/Ug8le+AjonC2HcLYTu3q+s/1gNIuMMvUeq6EL64atd8Ym2QvrdMp5RPop4Gn9+DvqtQSdi9IUrlg9zGnh/Jo4+e7KmFSY1fpjZRbt+bErxsb+6okepHGL3TKMXTsZIGz2hb4UCTSkeBP6kJ2Zk4vkaBN/EuVQAjP4QM0iHNUxzkS3n5DlFPLkHP1pyLmKGzjJVaWrLiJnNOvmDu+VINwX89Yrn9FY0D1NZiFDyET413OYAjnBSQ0S3rWuVlVPvE0weE9G3PElnXmz3V51dh7DBoW+G2QgJr1eWRLulkPueMQ/M0OhRdKgHMF0GKYftQNSRAMU4h/9L7ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ericsson.com; dmarc=pass action=none header.from=ericsson.com; dkim=pass header.d=ericsson.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r0//JEnn0CQTtZMqxg9REN+Q0UP92sNV3V3oSaIsanY=; b=IXnP61nhDVchAXJkjFTnACI5PqvYID4l8rFBWO1A1LKQiEJuumXTv2EKOZAxrI4eh0xjxUfZYqUNsyvnCzjF9d7kh2XdEu7QMwhFLJcE2JwOuXcy4ni6aYNJQDLT91EluyHUXd/hf/z+mnpkoPJXLRjidaAAouYCCVKwE74ZlWY=
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com (2603:10a6:208:22::25) by AM0PR07MB5410.eurprd07.prod.outlook.com (2603:10a6:208:fe::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.23; Thu, 1 Oct 2020 12:51:59 +0000
Received: from AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::59ca:540d:b7f3:58b9]) by AM0PR0702MB3603.eurprd07.prod.outlook.com ([fe80::59ca:540d:b7f3:58b9%6]) with mapi id 15.20.3433.035; Thu, 1 Oct 2020 12:51:59 +0000
From: Balázs Varga A <balazs.a.varga@ericsson.com>
To: Christer Holmberg <christer.holmberg@ericsson.com>, "gen-art@ietf.org" <gen-art@ietf.org>
CC: "last-call@ietf.org" <last-call@ietf.org>, "detnet@ietf.org" <detnet@ietf.org>, "draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org" <draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org>
Thread-Topic: Genart last call review of draft-ietf-detnet-mpls-over-udp-ip-06
Thread-Index: AQHWgKEvqgownTDRvk65miM8DI1HN6mC1Q2w
Date: Thu, 01 Oct 2020 12:51:59 +0000
Message-ID: <AM0PR0702MB3603C715BBFE92CD24FDFCD3AC300@AM0PR0702MB3603.eurprd07.prod.outlook.com>
References: <159899327760.7783.10121478920467674215@ietfa.amsl.com>
In-Reply-To: <159899327760.7783.10121478920467674215@ietfa.amsl.com>
Accept-Language: hu-HU, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: ericsson.com; dkim=none (message not signed) header.d=none;ericsson.com; dmarc=none action=none header.from=ericsson.com;
x-originating-ip: [94.21.192.99]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: dbfb1107-6c5a-4346-68f4-08d86608c927
x-ms-traffictypediagnostic: AM0PR07MB5410:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <AM0PR07MB54108A866FEC2D192A982B19AC300@AM0PR07MB5410.eurprd07.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: hC7yu2YyifBEYNak1BK+Zv3O9ltVx0s3j9a7PtaX/LmApQKglUkHKHZ0MEx5WdtPwnmzF6GRow6VQ69C7Pg20gz1kaitOPzQAJAiuOtOJsg3goH3tsrNjaI4lFDfvht1GWJToZURmBQ7UBIicXFSodm9hGbjMTP7U61LLydilAV8gblwJtKDE8kc2ji0OUy8CLHNGk6JFXEqU2udSCDFnN4NURpOrvwRHdEl34U6Xa9BaVbJx/HU1QCqQLaZLRYJzF1MfQb/g/ynP4z5z4ivY0NYLnGcqPlBtb7OdbquA6TPZjnRCPycwyrneJgJiDOmpq+aljnY1QcsF+p/2MEgBuCMi8V2b8twraATuxusGropAd0A99kBuGpKMsHCDP9/bukQ4T5qIDoG8UTxBU/t8g==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0702MB3603.eurprd07.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(83380400001)(83080400001)(2906002)(4326008)(9686003)(85182001)(76116006)(66946007)(66476007)(66556008)(5660300002)(450100002)(52536014)(71200400001)(66446008)(64756008)(66574015)(110136005)(6506007)(53546011)(54906003)(316002)(186003)(33656002)(7696005)(86362001)(478600001)(26005)(85202003)(8676002)(8936002)(55016002); DIR:OUT; SFP:1101;
x-ms-exchange-antispam-messagedata: 93WP50YpJt2ZYCSpR3VIYyTwTPfWq8AIadlbKIvoQ+/g6DsYlgCbE/QwdV2+bMZRuz/LXzBgmpQMKipyuO7joX5rthFrH8yZeL7BZbjAE9uJDbHQyZ8SQn1lCFQqXU9oZzJQjgUo63wSlHZghKeoJ6WFO/y1et7Qny1XJlmDNL2FvmwAtZs8pIzMDHCMzapad18gO71Aqa7iF+DjrAtyrFUWRuHfpdlv8WVLVPAHxNI5t9jsi8yIPoL0sKcFsyx8urjSy4vLXryU5dz13WyXvfqzMfePOsemA1wfkA+UBgZwbYPbIssDu6yA+00iv1r7CV9YO0pF3uXuB6IXnWRpcLOiz6F2reLEnKFjBuI2iYJRpvpGZ437wxKDv+hnioeH5jZCPaKialyuTRIiqjwCY2s7iLw4UVfC+QgTEliDNPgA+h4SRL1WjaBxcJhOQ/DfKz1f4ISRGrJ69urMyud1bp9kfUYTpCaOdVDDxrHmZrxDxAEWxpbObQ43Yj0JwTWrIqxjCgu1srHeY1h2zl37zoJuWpGCp20+zK/1Js3A3Ey3WOzkRuomykVCETH2sWHETrRSFcAAIOzNrUTYfEeN8SNAsPX9y0zEq6qimk8EvaBe4TEgVfV3qihOsfWEnTYSassUTtrjAP8yPE31Q3P3mw==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: ericsson.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR0702MB3603.eurprd07.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbfb1107-6c5a-4346-68f4-08d86608c927
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2020 12:51:59.2030 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BUMk9UdbJRt1XKRd7jBIlSlt/pM8CzHhDB11EWmaUNoAUbgrx8fVAK4CFBNjWyJgM8P1UoqW/p/LsqfHTCqjt1LfBKBkJaV3FN8pwFJbCHg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR07MB5410
Archived-At: <https://mailarchive.ietf.org/arch/msg/detnet/XNyQtC6sl-7RjtSHqDG2iJcDQA8>
Subject: Re: [Detnet] Genart last call review of draft-ietf-detnet-mpls-over-udp-ip-06
X-BeenThere: detnet@ietf.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussions on Deterministic Networking BoF and Proposed WG <detnet.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/detnet>, <mailto:detnet-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/detnet/>
List-Post: <mailto:detnet@ietf.org>
List-Help: <mailto:detnet-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/detnet>, <mailto:detnet-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Oct 2020 12:52:04 -0000

Hi Christer,

Thanks for the review. I agree with all your comments and will be corrected in next version. In detail:
Q1, Yes, RFC 7510 statement does apply to this document. Statement will be added to the introduction section.
DetNet documents focus on solutions for networks that are under a single administrative control or within a 
closed group of administrative control.
Q2, OK, second paragraph will be moved to the end of the introduction section as proposed.
Q3, OK, Terminology will be aligned with RFC 7510 (i.e., MPLS-in-UDP).

Cheers
Bala'zs

-----Original Message-----
From: Christer Holmberg via Datatracker <noreply@ietf.org> 
Sent: Tuesday, September 1, 2020 10:48 PM
To: gen-art@ietf.org
Cc: last-call@ietf.org; detnet@ietf.org; draft-ietf-detnet-mpls-over-udp-ip.all@ietf.org
Subject: Genart last call review of draft-ietf-detnet-mpls-over-udp-ip-06

Reviewer: Christer Holmberg
Review result: Almost Ready

I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair.  Please treat these comments just like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-detnet-mpls-over-udp-ip-06
Reviewer: Christer Holmberg
Review Date: 2020-09-01
IETF LC End Date: 2020-09-10
IESG Telechat date: Not scheduled for a telechat

Summary: In general I think the document is almost ready for publication, but I have a few minor issues and nits that I would like the authors to address.

Major issues: N/A

Minor issues:

Q1: In the last paragraph of Section 4, there is a statement from RFC 7510 aboout MPLS-in-UDP not being allowed on the general Internet etc. I think it should be explicitly indicated whether that also applies to this document. The document talks about "IP networks", but it is unclear what the scope really is.
And, if  the RFC 7510 statement does apply to this document, I think it shall be stated much earlier: either in the Introduction, or in a dedicated Applicability Section.

Nits/editorial comments:

Q2: In the Introduction, I like to have the this-document-does-this-and-that text at the end. If possible, please consider moving the 2nd paragraph to the end of the Section.

Q3: The first sentence of Section 3 says:

    "This document builds on the specification of MPLS over UDP defined in
    [RFC7510]."

...and Section 4 says "MPLS over UDP/IP encapsulation".

RFC 7510 talks about MPLS-in-UDP, so please align the terminology.